mirror of
1
Fork 0
forgejo/web_src/js/features/comp
wxiaoguang 704f3aa91c
Fine tune markdown editor toolbar (#24046)
1. Remove unnecessary `btn-link` `muted` classes
* Link is link, button is button, I can't see a real requirement to make
a button like a link.
* If anyone insists, please help to show me real example from modern
frameworks / websites, how and why they do so.
    * No need to duplicate a lot of class names on similar elements
* Declare styles clearly, for example, `markdown-toolbar` itself should
have `display: flex`, but not use `gt-df` to overwrite the `display:
block`.
2. Remove unnecessary `role` attribute
    * https://github.com/github/markdown-toolbar-element/issues/70
* The `markdown-toolbar-element` does want to add `role=button`, but
there is a bug.
* So we do the similar thing as upstream does (add the role by JS),
until they fix their bugs.
3. Indent `markdown-switch-easymde` (before it doesn't have a proper
indent)

Screenshot:

![image](https://user-images.githubusercontent.com/2114189/231090912-f6ba01cb-d0eb-40ad-bf8c-ffc597d9a778.png)
2023-04-11 16:36:18 +08:00
..
ColorPicker.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
ComboMarkdownEditor.js Fine tune markdown editor toolbar (#24046) 2023-04-11 16:36:18 +08:00
ImagePaste.js Introduce GitHub markdown editor, keep EasyMDE as fallback (#23876) 2023-04-03 18:06:57 +08:00
LabelEdit.js Scoped labels: set aria-disabled on muted Exclusive option for a11y (#23306) 2023-03-05 21:25:25 +08:00
QuickSubmit.js move handleGlobalEnterQuickSubmit into a separate file to avoid cycle-import (#20679) 2022-08-05 18:08:29 +08:00
ReactionSelector.js Use data-tooltip-content for tippy tooltip (#23649) 2023-03-24 18:35:38 +08:00
SearchUserBox.js JS refactors (#22227) 2022-12-24 00:03:11 +08:00
WebHookEditor.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00