mirror of
1
Fork 0
forgejo/templates/repo
oliverpool cb7ba8969d
fix: release page for empty or non-existing target (#24659)
Backport #24470

Fixes #24145

---

To solve the bug, I added a "computed" `TargetBehind` field to the
`Release` model, which indicates the target branch of a release. This is
particularly useful if the target branch was deleted in the meantime (or
is empty).

I also did a micro-optimization in `calReleaseNumCommitsBehind`. Instead
of checking that a branch exists and then call `GetBranchCommit`, I
immediately call `GetBranchCommit` and handle the `git.ErrNotExist`
error.

This optimization is covered by the added unit test.

_contributed in the context of @forgejo_
2023-05-12 14:14:41 -04:00
..
actions Fix actions frontend bugs (pagination, long name alignment) and small simplify (#23370) (#23436) 2023-03-13 09:09:00 +02:00
branch Make branches list page operations remember current page (#23420) (#23460) 2023-03-14 20:51:14 +08:00
cite Copy citation file content, in APA and BibTex format, on repo home page (#19999) 2022-11-11 18:02:50 +01:00
diff Fix code view (diff) broken layout (#23096) (#23918) 2023-04-04 16:02:29 +02:00
editor Fix broken code editor diff preview (#23307) (#23320) 2023-03-06 12:05:35 -06:00
find Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
graph Improve commit graph page UI alignment (#23751) (#23754) 2023-03-27 17:27:08 -04:00
issue Improve milestone filter on issues page (#22423) (#24440) 2023-04-30 19:01:12 +02:00
migrate Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
projects Fix no edit/close/delete button in org repo project view page (#24349) 2023-04-26 07:38:41 -04:00
pulls Discolor pull request tab labels (#23950) (#23987) 2023-04-07 22:32:42 -04:00
release fix: release page for empty or non-existing target (#24659) 2023-05-12 14:14:41 -04:00
settings Wrap too long push mirror addresses (#21120) (#24334) 2023-04-25 12:47:26 -04:00
tag
wiki Fix new wiki page mirror (#24518) 2023-05-04 16:30:47 -04:00
activity.tmpl
blame.tmpl
branch_dropdown.tmpl Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
clone_buttons.tmpl Move helpers to be prefixed with `gt-` (#22879) 2023-02-13 17:59:59 +00:00
clone_script.tmpl
commit_page.tmpl
commit_status.tmpl Fix missing commit status in PR which from forked repo (#23351) (#23453) 2023-03-14 08:11:31 +08:00
commit_statuses.tmpl Fix hidden commit status on multiple checks (#22889) 2023-02-20 16:43:04 +08:00
commits.tmpl Move helpers to be prefixed with `gt-` (#22879) 2023-02-13 17:59:59 +00:00
commits_list.tmpl
commits_list_small.tmpl
commits_table.tmpl Move helpers to be prefixed with `gt-` (#22879) 2023-02-13 17:59:59 +00:00
create.tmpl Make label templates have consistent behavior and priority (#23749) (#24071) 2023-04-12 16:05:10 +02:00
create_helper.tmpl
empty.tmpl
file_info.tmpl
forks.tmpl
graph.tmpl
header.tmpl
home.tmpl Fix and move "Use this template" button (#23398) (#23408) 2023-03-11 01:41:04 +08:00
icon.tmpl
packages.tmpl
search.tmpl
shabox_badge.tmpl
sub_menu.tmpl Add tags list for repos whose release setting is disabled (#23465) (#24369) 2023-04-27 12:40:36 +08:00
sub_menu_release_tag.tmpl
unicode_escape_prompt.tmpl
upload.tmpl
user_cards.tmpl
view_file.tmpl
view_list.tmpl Add wrapper to author to avoid long name ui problem (#23030) (#23098) 2023-02-24 10:45:18 +08:00
watchers.tmpl Fix user-cards format (#24428) (#24431) 2023-04-29 22:05:34 -04:00