mirror of
1
Fork 0
forgejo/cmd
Allen Wild 2186a99c76 cmd/serv: actually exit after fatal errors (#7458)
Regression in 356854fc5f, where
a log.Fatal call was removed. log.Fatal calls os.Exit(1) as intended,
but without it the fail() function returns normally and execution
continues past the fatal error, causing a panic.

This is visible as a go panic log and stack trace returned to the SSH
client, which is not only ugly, it leaks server and build system
information.

Fix by removing the stray return statement so that the fail() function
always calls os.Exit(1).

Fixes: https://github.com/go-gitea/gitea/issues/7457
Signed-off-by: Allen Wild <allenwild93@gmail.com>
2019-07-13 21:38:18 +01:00
..
admin.go Add CLI commands to manage LDAP authentication source (#6681) 2019-06-17 14:32:20 -04:00
admin_auth_ldap.go Add CLI commands to manage LDAP authentication source (#6681) 2019-06-17 14:32:20 -04:00
admin_auth_ldap_test.go Add CLI commands to manage LDAP authentication source (#6681) 2019-06-17 14:32:20 -04:00
cert.go Add golangci (#6418) 2019-06-12 15:41:28 -04:00
cmd.go Disallow empty titles (#5785) 2019-01-21 13:45:32 +02:00
convert.go Add command to convert mysql database from utf8 to utf8mb4 (#7144) 2019-06-08 21:53:45 +08:00
dump.go Change verbose flag in dump command to avoid colliding with global version flag (#6822) 2019-05-01 21:36:09 +01:00
generate.go Rename LFS_JWT_SECRET to include OAUTH2 as well (#6826) 2019-05-01 22:32:06 -04:00
hook.go #6946 Run hooks on merge/edit and cope with protected branches (#6961) 2019-07-01 09:18:13 +08:00
keys.go Make CustomPath, CustomConf and AppWorkPath configurable at build (#6631) 2019-04-29 14:08:21 -04:00
migrate.go Make CustomPath, CustomConf and AppWorkPath configurable at build (#6631) 2019-04-29 14:08:21 -04:00
serv.go cmd/serv: actually exit after fatal errors (#7458) 2019-07-13 21:38:18 +01:00
web.go Use certmanager provided TLSConfig for LetsEncrypt (#7229) 2019-06-17 13:33:55 -04:00
web_graceful.go Better logging (#6038) (#6095) 2019-04-02 08:48:31 +01:00
web_windows.go fix windows build broken by #416 2016-12-31 17:16:02 +08:00