272ae03341
Backport #28348 by @AdamMajer nogogit GetBranchNames() lists branches sorted in reverse commit date order. On the other hand the gogit implementation doesn't apply any ordering resulting in unpredictable behaviour. In my case, the unit tests requiring particular order fail repo_branch_test.go:24: Error Trace: ./gitea/modules/git/repo_branch_test.go:24 Error: elements differ extra elements in list A: ([]interface {}) (len=1) { (string) (len=6) "master" } extra elements in list B: ([]interface {}) (len=1) { (string) (len=7) "branch1" } listA: ([]string) (len=2) { (string) (len=6) "master", (string) (len=7) "branch2" } listB: ([]string) (len=2) { (string) (len=7) "branch1", (string) (len=7) "branch2" } Test: TestRepository_GetBranches To fix this, we sort branches based on their commit date in gogit implementation. Fixes: #28318 Co-authored-by: Adam Majer <amajer@suse.de> |
||
|---|---|---|
| .. | ||
| foreachref | ||
| internal | ||
| pipeline | ||
| tests/repos | ||
| url | ||
| README.md | ||
| batch_reader.go | ||
| blame.go | ||
| blame_test.go | ||
| blob.go | ||
| blob_gogit.go | ||
| blob_nogogit.go | ||
| blob_test.go | ||
| command.go | ||
| command_race_test.go | ||
| command_test.go | ||
| commit.go | ||
| commit_convert_gogit.go | ||
| commit_info.go | ||
| commit_info_gogit.go | ||
| commit_info_nogogit.go | ||
| commit_info_test.go | ||
| commit_reader.go | ||
| commit_test.go | ||
| diff.go | ||
| diff_test.go | ||
| error.go | ||
| git.go | ||
| git_test.go | ||
| hook.go | ||
| last_commit_cache.go | ||
| last_commit_cache_gogit.go | ||
| last_commit_cache_nogogit.go | ||
| log_name_status.go | ||
| notes.go | ||
| notes_gogit.go | ||
| notes_nogogit.go | ||
| notes_test.go | ||
| parse_gogit.go | ||
| parse_gogit_test.go | ||
| parse_nogogit.go | ||
| parse_nogogit_test.go | ||
| ref.go | ||
| ref_test.go | ||
| remote.go | ||
| repo.go | ||
| repo_archive.go | ||
| repo_attribute.go | ||
| repo_attribute_test.go | ||
| repo_base.go | ||
| repo_base_gogit.go | ||
| repo_base_nogogit.go | ||
| repo_blame.go | ||
| repo_blob.go | ||
| repo_blob_gogit.go | ||
| repo_blob_nogogit.go | ||
| repo_blob_test.go | ||
| repo_branch.go | ||
| repo_branch_gogit.go | ||
| repo_branch_nogogit.go | ||
| repo_branch_test.go | ||
| repo_commit.go | ||
| repo_commit_gogit.go | ||
| repo_commit_nogogit.go | ||
| repo_commit_test.go | ||
| repo_commitgraph.go | ||
| repo_commitgraph_gogit.go | ||
| repo_compare.go | ||
| repo_compare_test.go | ||
| repo_gpg.go | ||
| repo_hook.go | ||
| repo_index.go | ||
| repo_language_stats.go | ||
| repo_language_stats_gogit.go | ||
| repo_language_stats_nogogit.go | ||
| repo_language_stats_test.go | ||
| repo_object.go | ||
| repo_ref.go | ||
| repo_ref_gogit.go | ||
| repo_ref_nogogit.go | ||
| repo_ref_test.go | ||
| repo_stats.go | ||
| repo_stats_test.go | ||
| repo_tag.go | ||
| repo_tag_gogit.go | ||
| repo_tag_nogogit.go | ||
| repo_tag_test.go | ||
| repo_test.go | ||
| repo_tree.go | ||
| repo_tree_gogit.go | ||
| repo_tree_nogogit.go | ||
| sha1.go | ||
| sha1_gogit.go | ||
| sha1_nogogit.go | ||
| sha1_test.go | ||
| signature.go | ||
| signature_gogit.go | ||
| signature_nogogit.go | ||
| submodule.go | ||
| submodule_test.go | ||
| tag.go | ||
| tag_test.go | ||
| tree.go | ||
| tree_blob.go | ||
| tree_blob_gogit.go | ||
| tree_blob_nogogit.go | ||
| tree_entry.go | ||
| tree_entry_gogit.go | ||
| tree_entry_mode.go | ||
| tree_entry_nogogit.go | ||
| tree_entry_test.go | ||
| tree_gogit.go | ||
| tree_nogogit.go | ||
| utils.go | ||
README.md
Git Module
This module is merged from https://github.com/go-gitea/git which is a Go module to access Git through shell commands. Now it's a part of gitea's main repository for easier pull request.