mirror of
1
Fork 0
forgejo/routers/install
wxiaoguang b4460cf541
Make "install page" respect environment config (#25648) (#25799)
Backport #25648

Replace #25580

Fix #19453

The problem was: when users set "GITEA__XXX__YYY" , the "install page"
doesn't respect it.

So, to make the result consistent and avoid surprising end users, now
the "install page" also writes the environment variables to the config
file.

And, to make things clear, there are enough messages on the UI to tell
users what will happen.

There are some necessary/related changes to `environment-to-ini.go`:

* The "--clear" flag is removed and it was incorrectly written there.
The "clear" operation should be done if INSTALL_LOCK=true
* The "--prefix" flag is removed because it's never used, never
documented and it only causes inconsistent behavior.

The only conflict during backport is "ui divider" in
templates/install.tmpl
2023-07-10 11:51:05 +00:00
..
install.go Make "install page" respect environment config (#25648) (#25799) 2023-07-10 11:51:05 +00:00
routes.go Fix install page context, make the install page tests really test (#24858) 2023-05-23 09:29:15 +08:00
routes_test.go Fix install page context, make the install page tests really test (#24858) 2023-05-23 09:29:15 +08:00