mirrors
/
forgejo
mirror of
1
Fork 0
Code Issues Releases Activity
forgejo/modules/git
History
zeripath 0d25292fbc
Prevent panic in doctor command when running default checks (#21791) (#21807) 
Backport #21791

There was a bug introduced in #21352 due to a change of behaviour caused
by #19280. This causes a panic on running the default doctor checks
because the panic introduced by #19280 assumes that the only way
opts.StdOut and opts.Stderr can be set in RunOpts is deliberately.
Unfortunately, when running a git.Command the provided RunOpts can be
set, therefore if you share a common set of RunOpts these two values can
be set by the previous commands.

This PR stops using common RunOpts for the commands in that doctor check
but secondly stops RunCommand variants from changing the provided
RunOpts.

Signed-off-by: Andrew Thornton <art27@cantab.net>
 		2022-11-14 10:58:32 +08:00
..
foreachref Go 1.19 format (#20758) 2022-08-30 21:15:45 -05:00
pipeline Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2022-10-24 20:29:17 +01:00
tests/repos Auto merge pull requests when all checks succeeded via API (#9307) 2022-05-08 01:05:52 +08:00
url Fix some mirror bugs (#18649) 2022-06-11 21:50:14 +08:00
README.md
…
batch_reader.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
blame.go Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2022-10-24 20:29:17 +01:00
blame_test.go
…
blob.go
…
blob_gogit.go Remove legacy `+build:` constraint (#19582) 2022-05-02 23:22:45 +08:00
blob_nogogit.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
blob_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
command.go Prevent panic in doctor command when running default checks (#21791) (#21807) 2022-11-14 10:58:32 +08:00
command_race_test.go Remove legacy `+build:` constraint (#19582) 2022-05-02 23:22:45 +08:00
command_test.go Follow improve code quality (#21465) 2022-10-15 14:18:31 +02:00
commit.go Refactor git command arguments and make all arguments to be safe to be used (#21535) 2022-10-23 22:44:45 +08:00
commit_convert_gogit.go Remove legacy `+build:` constraint (#19582) 2022-05-02 23:22:45 +08:00
commit_info.go
…
commit_info_gogit.go Slightly simplify LastCommitCache (#20444) 2022-07-25 16:39:42 +01:00
commit_info_nogogit.go Slightly simplify LastCommitCache (#20444) 2022-07-25 16:39:42 +01:00
commit_info_test.go test: use `T.TempDir` to create temporary test directory (#21043) 2022-09-04 16:14:53 +01:00
commit_reader.go
…
commit_test.go Use for a repo action one database transaction (#19576) 2022-05-03 21:46:28 +02:00
diff.go Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2022-10-24 20:29:17 +01:00
diff_test.go
…
error.go Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2022-10-24 20:29:17 +01:00
git.go Refactor git command arguments and make all arguments to be safe to be used (#21535) 2022-10-23 22:44:45 +08:00
git_test.go Refactor legacy git init (#20376) 2022-08-09 11:22:24 +08:00
hook.go
…
last_commit_cache.go Slightly simplify LastCommitCache (#20444) 2022-07-25 16:39:42 +01:00
last_commit_cache_gogit.go Slightly simplify LastCommitCache (#20444) 2022-07-25 16:39:42 +01:00
last_commit_cache_nogogit.go Slightly simplify LastCommitCache (#20444) 2022-07-25 16:39:42 +01:00
log_name_status.go Refactor git command arguments and make all arguments to be safe to be used (#21535) 2022-10-23 22:44:45 +08:00
notes.go
…
notes_gogit.go Slightly simplify LastCommitCache (#20444) 2022-07-25 16:39:42 +01:00
notes_nogogit.go Slightly simplify LastCommitCache (#20444) 2022-07-25 16:39:42 +01:00
notes_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
parse_gogit.go Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2022-10-24 20:29:17 +01:00
parse_gogit_test.go Remove legacy `+build:` constraint (#19582) 2022-05-02 23:22:45 +08:00
parse_nogogit.go Refactor parseTreeEntries, speed up tree list (#21368) 2022-10-08 01:20:53 +08:00
parse_nogogit_test.go Refactor parseTreeEntries, speed up tree list (#21368) 2022-10-08 01:20:53 +08:00
ref.go Add more checks in migration code (#21011) 2022-09-04 13:47:56 +03:00
remote.go Refactor git command arguments and make all arguments to be safe to be used (#21535) 2022-10-23 22:44:45 +08:00
repo.go Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2022-10-24 20:29:17 +01:00
repo_archive.go Refactor git command arguments and make all arguments to be safe to be used (#21535) 2022-10-23 22:44:45 +08:00
repo_attribute.go Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2022-10-24 20:29:17 +01:00
repo_attribute_test.go
…
repo_base.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_base_gogit.go Slightly simplify LastCommitCache (#20444) 2022-07-25 16:39:42 +01:00
repo_base_nogogit.go Slightly simplify LastCommitCache (#20444) 2022-07-25 16:39:42 +01:00
repo_blame.go Refactor git command arguments and make all arguments to be safe to be used (#21535) 2022-10-23 22:44:45 +08:00
repo_blob.go
…
repo_blob_gogit.go Remove legacy `+build:` constraint (#19582) 2022-05-02 23:22:45 +08:00
repo_blob_nogogit.go Remove legacy `+build:` constraint (#19582) 2022-05-02 23:22:45 +08:00
repo_blob_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_branch.go Refactor git command arguments and make all arguments to be safe to be used (#21535) 2022-10-23 22:44:45 +08:00
repo_branch_gogit.go Auto merge pull requests when all checks succeeded via API (#9307) 2022-05-08 01:05:52 +08:00
repo_branch_nogogit.go Refactor git command arguments and make all arguments to be safe to be used (#21535) 2022-10-23 22:44:45 +08:00
repo_branch_test.go Sort branches and tags by date descending (#21136) 2022-09-14 14:11:24 +02:00
repo_commit.go Refactor git command arguments and make all arguments to be safe to be used (#21535) 2022-10-23 22:44:45 +08:00
repo_commit_gogit.go Refactor git command arguments and make all arguments to be safe to be used (#21535) 2022-10-23 22:44:45 +08:00
repo_commit_nogogit.go Refactor git command arguments and make all arguments to be safe to be used (#21535) 2022-10-23 22:44:45 +08:00
repo_commit_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_commitgraph.go Remove `git.Command.Run` and `git.Command.RunInDir*` (#19280) 2022-04-01 10:55:30 +08:00
repo_commitgraph_gogit.go Remove legacy `+build:` constraint (#19582) 2022-05-02 23:22:45 +08:00
repo_compare.go Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2022-10-24 20:29:17 +01:00
repo_compare_test.go test: use `T.TempDir` to create temporary test directory (#21043) 2022-09-04 16:14:53 +01:00
repo_gpg.go Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2022-10-24 20:29:17 +01:00
repo_hook.go
…
repo_index.go Refactor git command arguments and make all arguments to be safe to be used (#21535) 2022-10-23 22:44:45 +08:00
repo_language_stats.go
…
repo_language_stats_gogit.go Remove legacy git code (ver < 2.0), fine tune markup tests (#19930) 2022-06-16 23:47:44 +08:00
repo_language_stats_nogogit.go Refactor parseTreeEntries, speed up tree list (#21368) 2022-10-08 01:20:53 +08:00
repo_language_stats_test.go Remove legacy `+build:` constraint (#19582) 2022-05-02 23:22:45 +08:00
repo_object.go Remove `git.Command.Run` and `git.Command.RunInDir*` (#19280) 2022-04-01 10:55:30 +08:00
repo_ref.go
…
repo_ref_gogit.go Remove legacy `+build:` constraint (#19582) 2022-05-02 23:22:45 +08:00
repo_ref_nogogit.go Remove legacy `+build:` constraint (#19582) 2022-05-02 23:22:45 +08:00
repo_ref_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_stats.go Refactor git command arguments and make all arguments to be safe to be used (#21535) 2022-10-23 22:44:45 +08:00
repo_stats_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_tag.go Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) 2022-10-24 20:29:17 +01:00
repo_tag_gogit.go Remove legacy `+build:` constraint (#19582) 2022-05-02 23:22:45 +08:00
repo_tag_nogogit.go Refactor git command arguments and make all arguments to be safe to be used (#21535) 2022-10-23 22:44:45 +08:00
repo_tag_test.go test: use `T.TempDir` to create temporary test directory (#21043) 2022-09-04 16:14:53 +01:00
repo_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_tree.go Refactor git command arguments and make all arguments to be safe to be used (#21535) 2022-10-23 22:44:45 +08:00
repo_tree_gogit.go Refactor git command arguments and make all arguments to be safe to be used (#21535) 2022-10-23 22:44:45 +08:00
repo_tree_nogogit.go Remove legacy `+build:` constraint (#19582) 2022-05-02 23:22:45 +08:00
sha1.go Add more checks in migration code (#21011) 2022-09-04 13:47:56 +03:00
sha1_gogit.go Remove legacy `+build:` constraint (#19582) 2022-05-02 23:22:45 +08:00
sha1_nogogit.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
sha1_test.go probe if sha before exec git (#21467) 2022-10-17 16:40:37 +02:00
signature.go
…
signature_gogit.go Go 1.19 format (#20758) 2022-08-30 21:15:45 -05:00
signature_nogogit.go Go 1.19 format (#20758) 2022-08-30 21:15:45 -05:00
submodule.go
…
submodule_test.go
…
tag.go
…
tag_test.go
…
tree.go Refactor git command arguments and make all arguments to be safe to be used (#21535) 2022-10-23 22:44:45 +08:00
tree_blob.go
…
tree_blob_gogit.go Remove legacy `+build:` constraint (#19582) 2022-05-02 23:22:45 +08:00
tree_blob_nogogit.go Remove legacy `+build:` constraint (#19582) 2022-05-02 23:22:45 +08:00
tree_entry.go
…
tree_entry_gogit.go Remove legacy `+build:` constraint (#19582) 2022-05-02 23:22:45 +08:00
tree_entry_mode.go
…
tree_entry_nogogit.go Remove legacy `+build:` constraint (#19582) 2022-05-02 23:22:45 +08:00
tree_entry_test.go Remove legacy `+build:` constraint (#19582) 2022-05-02 23:22:45 +08:00
tree_gogit.go Refactor parseTreeEntries, speed up tree list (#21368) 2022-10-08 01:20:53 +08:00
tree_nogogit.go Refactor git command arguments and make all arguments to be safe to be used (#21535) 2022-10-23 22:44:45 +08:00
utils.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
utils_test.go
…

README.md

Git Module

This module is merged from https://github.com/go-gitea/git which is a Go module to access Git through shell commands. Now it's a part of gitea's main repository for easier pull request.