mirror of
1
Fork 0
forgejo/templates/repo/issue/view_content
oliverpool 0fc61c8836 [BUG] split code conversations in diff tab (#2306)
Follow-up of #2282 and #2296 (which tried to address #2278)

One of the issue with the previous PR is that when a conversation on the Files tab was marked as "resolved", it would fetch all the comments for that line (even the outdated ones, which should not be shown on this page - except when explicitly activated).

To properly fix this, I have changed `FetchCodeCommentsByLine` to `FetchCodeConversation`. Its role is to fetch all comments related to a given (review, path, line) and reverted my changes in the template (which were based on a misunderstanding).

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2306
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
2024-02-16 12:16:11 +00:00
..
add_reaction.tmpl Improve and fix bugs surrounding reactions (#24760) 2023-05-28 01:34:18 +00:00
attachments.tmpl Always use `ctx.Locale.Tr` inside templates (#27231) 2023-09-25 08:56:50 +00:00
comments.tmpl [gitea] Rework spellchecking, add `lint-spell` (#29106) 2024-02-10 10:53:43 +01:00
comments_delete_time.tmpl Always use `ctx.Locale.Tr` inside templates (#27231) 2023-09-25 08:56:50 +00:00
context_menu.tmpl Always use `ctx.Locale.Tr` inside templates (#27231) 2023-09-25 08:56:50 +00:00
conversation.tmpl [BUG] split code conversations in diff tab (#2306) 2024-02-16 12:16:11 +00:00
pull.tmpl Add merge style `fast-forward-only` (#28954) 2024-02-14 17:19:19 +01:00
pull_merge_instruction.tmpl Add merge style `fast-forward-only` (#28954) 2024-02-14 17:19:19 +01:00
reactions.tmpl Add non-JS fallback for reaction tooltips (#28785) 2024-01-15 09:42:59 +08:00
reference_issue_dialog.tmpl Always use `ctx.Locale.Tr` inside templates (#27231) 2023-09-25 08:56:50 +00:00
show_role.tmpl Add `member`, `collaborator`, `contributor`, and `first-time contributor` roles and tooltips (#26658) 2023-08-24 13:06:17 +08:00
sidebar.tmpl Introduce htmx and use it to avoid full page load on `Subscribe` and `Follow` (#28908) 2024-01-30 15:45:54 +01:00
update_branch_by_merge.tmpl Always use `ctx.Locale.Tr` inside templates (#27231) 2023-09-25 08:56:50 +00:00
watching.tmpl Introduce htmx and use it to avoid full page load on `Subscribe` and `Follow` (#28908) 2024-01-30 15:45:54 +01:00