mirror of
1
Fork 0
forgejo/templates
wxiaoguang affdd40296
Make issue title edit buttons focusable and fix incorrect ajax requests (#22807)
Replace #19922 , which is stale since my last review:
https://github.com/go-gitea/gitea/pull/19922#pullrequestreview-1003546506
and https://github.com/go-gitea/gitea/pull/19922#issuecomment-1153181546

Close #19769

Changes:
1. Use `<button>` instead of `<div>` for buttons
2. Prevent default event handler in `initGlobalButtonClickOnEnter`
3. Fix the incorrect call to `pullrequest_targetbranch_change`
4. Add a slight margin-left to the input element to make UI look better

The logic in repo-issue.js is not ideal, but this PR isn't going to
touch the logic.

This is also an example for future developers to understand how to make
buttons work properly.

### Before


![image](https://user-images.githubusercontent.com/2114189/217262515-ec0462f7-7051-46a5-bfa2-2f6c6a807b7d.png)

### After

* Add a slight margin-left.
* The `Cancel` button is focused.


![image](https://user-images.githubusercontent.com/2114189/217264891-934c9c8d-d190-4866-98b5-666cea57e28d.png)

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2023-02-09 12:11:16 -05:00
..
admin Map OIDC groups to Orgs/Teams (#21441) 2023-02-08 14:44:42 +08:00
api/packages/pypi Add Package Registry (#16510) 2022-03-30 16:42:47 +08:00
base Improve notification and stopwatch styles (#22169) 2023-02-09 13:42:18 +08:00
code Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 2023-02-06 12:09:18 -06:00
custom Add footer extra links template (#9576) 2020-01-03 20:41:56 +02:00
explore Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
mail Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 2023-02-06 12:09:18 -06:00
org Add Cargo package registry (#21888) 2023-02-05 18:12:31 +08:00
package Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 2023-02-06 12:09:18 -06:00
projects Fix more HTMLURL in templates (#22831) 2023-02-09 11:31:30 -05:00
repo Make issue title edit buttons focusable and fix incorrect ajax requests (#22807) 2023-02-09 12:11:16 -05:00
shared Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 2023-02-06 12:09:18 -06:00
status Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
swagger Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 2023-02-06 12:09:18 -06:00
user Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 2023-02-06 12:09:18 -06:00
home.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
install.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
post-install.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00