mirror of
1
Fork 0
forgejo/modules/setting
Giteabot 257287954c
Fix the permission of team's `Actions` unit issue (#24536) (#24545)
Backport #24536 by @sillyguodong

close #24449

The unit of `Actions` should be contorlled not only by
`repository.DISABLED_REPO_UNITS` but also by `actions.ENABLED`
in the `app.ini`.
Previously, the permission of the team's `Actions` unit was not
controlled by `actions.Enabled`. So, even if the user sets
`actions.Enabled` to false, he can still select the permission of the
`Actions` unit for the team.

This PR makes the permissions of the team's `Actions` unit also
controlled by `actions.Enabled`. Just append`TypeActions` into
`DisabledRepoUnits` slice when initializing if `actions.Enabled` is
false.


### Changes:

If `Actions` is set disbaled in `app.ini`, like below:
```yaml
[actions]
ENABLED = false
```

1. If user try to create/edit a team, will prompt user that `Actions` is
disbaled.
 

![image](https://user-images.githubusercontent.com/33891828/236370415-961082b2-82d2-4d9e-8025-83872ad08cbb.png)

2. `actions` is not displayed in the sidebar on the team details page


![image](https://user-images.githubusercontent.com/33891828/236371817-f39f9bc9-5926-4b88-b5e6-d93617fcfb07.png)

Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com>
2023-05-05 15:07:02 +02:00
..
actions.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
admin.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
api.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
attachment.go Add `.patch` to `attachment.ALLOWED_TYPES` (#23580) (#23582) 2023-03-19 16:48:44 -04:00
cache.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
camo.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
config_provider.go handle deprecated settings (#22992) 2023-02-20 16:18:26 -06:00
cors.go Fix incorrect CORS default values (#24206) (#24217) 2023-04-19 16:23:25 -04:00
cron.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
cron_test.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
database.go Refactor `setting.Database.UseXXX` to methods (#23354) (#23356) 2023-03-07 20:11:44 +08:00
database_sqlite.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
database_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
federation.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
git.go Support reflogs (#22451) (#23438) 2023-03-13 12:20:10 +00:00
highlight.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
i18n.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
incoming_email.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
indexer.go handle deprecated settings (#22992) 2023-02-20 16:18:26 -06:00
indexer_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
lfs.go handle deprecated settings (#22992) 2023-02-20 16:18:26 -06:00
log.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
mailer.go handle deprecated settings (#22992) 2023-02-20 16:18:26 -06:00
mailer_test.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
markup.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
metrics.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
migrations.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
mime_type_map.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
mirror.go handle deprecated settings (#22992) 2023-02-20 16:18:26 -06:00
oauth2.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
other.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
packages.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
packages_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
picture.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
project.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
proxy.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
queue.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
repository.go Fix the permission of team's `Actions` unit issue (#24536) (#24545) 2023-05-05 15:07:02 +02:00
security.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
server.go handle deprecated settings (#22992) 2023-02-20 16:18:26 -06:00
service.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
session.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
setting.go Fix incorrect CurrentUser check for docker rootless (#24435) 2023-04-29 23:47:04 -04:00
setting_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
ssh.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
storage.go Make minio package support legacy MD5 checksum (#23768) (#23770) 2023-03-29 00:02:13 +08:00
storage_test.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
task.go handle deprecated settings (#22992) 2023-02-20 16:18:26 -06:00
time.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
ui.go Don't set meta `theme-color` by default (#24340) (#24346) 2023-04-26 01:33:15 -04:00
webhook.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00