mirror of
1
Fork 0
forgejo/web_src/js
cloudchamb3r c163bf6fb5
Fix null errors on conversation holder (#32258) (#32266)
fix #32258

Errors in the issue was due to unhandled null check. so i fixed it.

### Detailed description for Issue & Fix
To reproduce that issue, the comment must be deleted on Conversation
tab.
#### Before Delete
<img width="1032" alt="image"
src="https://github.com/user-attachments/assets/72df61ba-7db6-44c9-bebc-ca1178dd27f1">

#### After Delete (AS-IS)
<img width="1010" alt="image"
src="https://github.com/user-attachments/assets/36fa537e-4f8e-4535-8d02-e538c50f0dd8">

gitea already have remove logic for `timeline-item-group`, but because
of null ref exception the later logic that removes `timeline-item-group`
could be not be called correctly.

(cherry picked from commit 603fca1e27bc29c1e700cc1bd284eb619d2436c8)
2024-10-20 09:35:34 +02:00
..
components Merge pull request 'fix: Don't double escape delete branch text' (#5615) from gusted/forgejo-avoid-double-escape into forgejo 2024-10-19 21:21:33 +00:00
features Fix null errors on conversation holder (#32258) (#32266) 2024-10-20 09:35:34 +02:00
markup fix unchecking check boxes like [X] 2024-07-28 14:18:34 +00:00
modules Add form field id generation, remove duplicated ids (#30546) 2024-04-22 08:09:00 +02:00
render Use vitest globals (#27102) 2023-09-27 04:37:13 +00:00
standalone [CHORE] Proper chunking for swagger 2024-08-22 15:48:05 +02:00
utils [PORT] Enable `no-jquery/no-parse-html-literal` and fix violation (gitea#31684) 2024-07-28 16:52:02 +02:00
vendor Vendor `jquery.are-you-sure` with strict mode fixes (#26901) 2023-09-06 00:02:44 +00:00
webcomponents Move settings button back to the right in repo and org header 2024-04-26 23:59:08 +02:00
bootstrap.js Suppress Monaco JavaScript errors in Safari (#3805) 2024-05-18 21:07:09 +00:00
bootstrap.test.js Avoid duplicate JS error messages on UI (#28873) 2024-01-21 14:23:08 +00:00
htmx.js Auto-update the system status in admin dashboard (#29163) 2024-02-17 23:24:31 +01:00
index.js Implement CSS-only input toggling, refactor related forms 2024-08-21 15:03:19 +02:00
jquery.js Forbid variables containing jQuery collections not having the `$` prefix (#29839) 2024-03-20 08:46:30 +01:00
svg.js ui: update pull request icons (#4455) 2024-07-16 14:38:46 +00:00
svg.test.js Use vitest globals (#27102) 2023-09-27 04:37:13 +00:00
utils.js enforce maxlength in frontend (#29389) 2024-02-26 22:30:27 +01:00
utils.test.js test(js): false negative in sleep test 2024-07-02 19:35:35 +02:00
vitest.setup.js [BUG] Render emojis in labels in issue info popup 2024-03-30 11:18:46 +01:00