mirror of
1
Fork 0
forgejo/templates
wxiaoguang 389e83f7eb
Improve `<SvgIcon>` to make it output `svg` node and optimize performance (#23570)
Before, the Vue `<SvgIcon>` always outputs DOM nodes like: 

```html
<span class="outer-class">
    <svg class="class-name-defined" ...></svg>
</span>
```

The `span` is redundant and I guess such layout and the inconsistent
`class/class-name` attributes would cause bugs sooner or later.

This PR makes the `<SvgIcon>` clear, and it's faster than before,
because it doesn't need to parse the whole SVG string.

Before: 

<details>

![image](https://user-images.githubusercontent.com/2114189/226156474-ce2c57cd-b869-486a-b75b-1eebdac8cdf7.png)

</details>

After:

![image](https://user-images.githubusercontent.com/2114189/226155774-108f49ed-7512-40c3-94a2-a6e8da18063d.png)

---------

Co-authored-by: silverwind <me@silverwind.io>
2023-03-23 11:24:16 +08:00
..
admin Fix `.locale.Tr` function not found in delete modal (#23468) 2023-03-20 20:41:57 -04:00
api/packages/pypi Add Package Registry (#16510) 2022-03-30 16:42:47 +08:00
base Use a general approch to improve a11y for all checkboxes and dropdowns. (#23542) 2023-03-22 10:52:01 +08:00
code Fix 'View File' button in code search (#23478) 2023-03-14 22:19:27 -04:00
custom Add footer extra links template (#9576) 2020-01-03 20:41:56 +02:00
explore Fix long name ui issues and label ui issue (#23541) 2023-03-18 17:07:59 +01:00
mail Revert relative links to absolute links in mail templates (#23267) 2023-03-03 22:43:30 +08:00
org Replace a few fontawesome icons with svg (#23602) 2023-03-20 21:42:02 -04:00
package Convert `<div class="button">` to `<button class="button">` (#23337) 2023-03-14 11:34:09 +08:00
projects Improve `<SvgIcon>` to make it output `svg` node and optimize performance (#23570) 2023-03-23 11:24:16 +08:00
repo Improve `<SvgIcon>` to make it output `svg` node and optimize performance (#23570) 2023-03-23 11:24:16 +08:00
shared Display the version of runner in the runner list (#23490) 2023-03-19 22:19:40 -04:00
status Move helpers to be prefixed with `gt-` (#22879) 2023-02-13 17:59:59 +00:00
swagger Add absent repounits to create/edit repo API (#23500) 2023-03-16 12:30:42 -05:00
user Improve `<SvgIcon>` to make it output `svg` node and optimize performance (#23570) 2023-03-23 11:24:16 +08:00
home.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
install.tmpl Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
post-install.tmpl Fix various bugs for "install" page (#23194) 2023-03-04 10:12:02 +08:00