mirror of
1
Fork 0
forgejo/web_src/js/components
wxiaoguang 389e83f7eb
Improve `<SvgIcon>` to make it output `svg` node and optimize performance (#23570)
Before, the Vue `<SvgIcon>` always outputs DOM nodes like: 

```html
<span class="outer-class">
    <svg class="class-name-defined" ...></svg>
</span>
```

The `span` is redundant and I guess such layout and the inconsistent
`class/class-name` attributes would cause bugs sooner or later.

This PR makes the `<SvgIcon>` clear, and it's faster than before,
because it doesn't need to parse the whole SVG string.

Before: 

<details>

![image](https://user-images.githubusercontent.com/2114189/226156474-ce2c57cd-b869-486a-b75b-1eebdac8cdf7.png)

</details>

After:

![image](https://user-images.githubusercontent.com/2114189/226155774-108f49ed-7512-40c3-94a2-a6e8da18063d.png)

---------

Co-authored-by: silverwind <me@silverwind.io>
2023-03-23 11:24:16 +08:00
..
.eslintrc.yaml Fix eslint parsing errors, remove eslint-plugin-html (#20323) 2022-07-15 17:38:18 +08:00
ActionRunStatus.vue Improve `<SvgIcon>` to make it output `svg` node and optimize performance (#23570) 2023-03-23 11:24:16 +08:00
ActivityHeatmap.vue Add pagination for dashboard and user activity feeds (#22937) 2023-02-24 16:15:10 -05:00
ContextPopup.vue Improve `<SvgIcon>` to make it output `svg` node and optimize performance (#23570) 2023-03-23 11:24:16 +08:00
DashboardRepoList.vue Remove stars in dashboard repo list (#23530) 2023-03-17 00:43:58 -04:00
DiffFileList.vue Move helpers to be prefixed with `gt-` (#22879) 2023-02-13 17:59:59 +00:00
DiffFileTree.vue Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
DiffFileTreeItem.vue Add `title` to PR file tree items (#22918) 2023-02-16 00:57:25 -05:00
PullRequestMergeForm.vue Refactor branch/tag selector to Vue SFC (#23421) 2023-03-14 17:51:20 +08:00
RepoActionView.vue Replace Less with CSS (#23481) 2023-03-14 22:20:19 -04:00
RepoActivityTopAuthors.vue Refactor dashboard repo list to Vue SFC (#23405) 2023-03-14 12:09:06 +08:00
RepoBranchTagSelector.vue Refactor branch/tag selector to Vue SFC (#23421) 2023-03-14 17:51:20 +08:00