mirror of
1
Fork 0
forgejo/routers
zeripath 858c35b731
Ensure BlameReaders close at end of request (#12102)
#11716 reports multiple git blame processes hanging around
this was thought to be due to timeouts, however on closer look this
appears to be due to the Close() function of the BlameReader hanging
with a blocked stdout pipe.

This PR fixes this Close function to:

* Cancel the context of the cmd
* Close the StdoutReader - ensuring that the output pipe is closed

Further it makes the context of the `git blame` command a child of the
request context - ensuring that even if Close() is not called, on
cancellation of the Request the blame is command will also be cancelled.

Fixes #11716
Closes #11727

Signed-off-by: Andrew Thornton <art27@cantab.net>
2020-07-01 14:01:17 +01:00
..
admin Refactor Cron and merge dashboard tasks (#10745) 2020-05-16 19:31:38 -04:00
api/v1 Do not override API issue pagination with UI settings (#12068) 2020-06-27 17:09:24 -04:00
dev Display ui time with customize time location (#7792) 2019-08-15 22:46:21 +08:00
events Add EventSource support (#11235) 2020-05-07 22:49:00 +01:00
org Fix visibility of forked public repos from private orgs (#11717) 2020-06-06 20:45:12 -04:00
private Protect default branch against deletion (#11115) 2020-05-06 12:08:45 +01:00
repo Ensure BlameReaders close at end of request (#12102) 2020-07-01 14:01:17 +01:00
routes Move serviceworker to workbox and fix SSE interference (#11538) 2020-05-21 21:45:34 -04:00
user Add hide activity option (#11353) 2020-06-05 16:01:53 -04:00
utils Handle push rejection message in Merge & Web Editor (#10373) 2020-02-22 15:08:48 +02:00
home.go Ensure public repositories in private organizations are visible and fix admin organizations list (#11465) 2020-05-18 00:27:54 +01:00
init.go Refactor Cron and merge dashboard tasks (#10745) 2020-05-16 19:31:38 -04:00
install.go Whenever the ctx.Session is updated, release it to save it before sending the redirect (#11456) 2020-05-17 15:43:29 +03:00
metrics.go Use gitea forked macaron (#7933) 2019-08-23 12:40:29 -04:00
swagger_json.go Add gitea-vet (#10948) 2020-04-05 07:20:50 +01:00