mirror of
1
Fork 0
forgejo/models
Giteabot f6919e3e53
Respect original content when creating secrets (#24745) (#24746)
Backport #24745 by @wolfogre

Fix #24721.

Follow what GitHub does:
- Don't trim spaces for secrets.
- Newline should be `\n` instead of `\r\n`.

Did some tests with:

```yaml
name: secrets
on: push
jobs:
  show_secrets:
    runs-on: ubuntu-latest
    steps:
      - name: Dump secrets context
        run: echo '${{ toJSON(secrets) }}' | base64
```

`AAAAAA`:
```text
   AAAAAA
AAAAAA

```
`BBBBBB`:
```text

BBBBBB
BBBBBB
```

On GitHub:

<img width="675" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/0ec60652-c2a3-47bb-9f9d-7e81665355a8">

On Gitea (before):

<img width="673" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/cce818bf-5edc-4656-86e1-2c81c304cdb2">

On Gitea (after):

<img width="673" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/0b3b15af-4d48-4bab-a334-4738a1b0eb4a">

Co-authored-by: Jason Song <i@wolfogre.com>
(cherry picked from commit e4f200e616)
2023-05-23 07:42:33 +02:00
..
actions Fix run list broken when trigger user deleted (#24706) (#24709) 2023-05-16 07:42:23 +02:00
activities Refactor `setting.Database.UseXXX` to methods (#23354) (#23356) 2023-03-07 20:11:44 +08:00
admin Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
asymkey Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
auth Fix 500 error if there is a name conflict when edit authentication source (#23832) (#23852) 2023-03-31 12:53:25 -04:00
avatars Avoid warning for system setting when start up (#23054) (#23116) 2023-02-24 16:46:11 -05:00
db Improve milestone filter on issues page (#22423) (#24440) 2023-04-30 19:01:12 +02:00
dbfs Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
fixtures fix: release page for empty or non-existing target (#24659) 2023-05-16 07:42:22 +02:00
git Fix branch protection priority (#24045) (#24061) 2023-04-11 21:07:38 +02:00
issues Refresh the refernce of the closed PR when reopening (#24231) (#24587) 2023-05-08 12:48:06 +02:00
migrations Drop migration for ForeignReference (#23605) (#23666) 2023-03-24 16:57:00 -04:00
organization Fix owner team access mode value in team_unit table (#24224) 2023-04-22 08:53:03 +02:00
packages Use ghost user if package creator does not exist (#23822) (#23915) 2023-04-04 20:37:28 +08:00
perm Rename `repo.GetOwner` to `repo.LoadOwner` (#22967) 2023-02-18 20:11:03 +08:00
project Refactor `setting.Database.UseXXX` to methods (#23354) (#23356) 2023-03-07 20:11:44 +08:00
pull refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
repo fix: release page for empty or non-existing target (#24659) 2023-05-16 07:42:22 +02:00
secret Respect original content when creating secrets (#24745) (#24746) 2023-05-23 07:42:33 +02:00
system Avoid warning for system setting when start up (#23054) (#23116) 2023-02-24 16:46:11 -05:00
unit Rename actions unit to `repo.actions` and add docs for it (#23733) (#23881) 2023-04-03 12:54:36 +02:00
unittest Refactor `setting.Database.UseXXX` to methods (#23354) (#23356) 2023-03-07 20:11:44 +08:00
user [BRANDING] reserve forgejo-actions username 2023-05-10 11:05:22 +02:00
webhook Support system hook API (#14537) 2023-01-28 19:12:10 +01:00
error.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
fixture_generation.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
fixture_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
main_test.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
migrate.go Check primary keys for all tables and drop ForeignReference (#21721) 2022-12-23 19:35:43 +08:00
migrate_test.go Check primary keys for all tables and drop ForeignReference (#21721) 2022-12-23 19:35:43 +08:00
org.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
org_team.go Remove org users who belong to no teams (#24247) (#24313) 2023-04-24 22:50:32 -04:00
org_team_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
org_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo.go Avoid warning for system setting when start up (#23054) (#23116) 2023-02-24 16:46:11 -05:00
repo_collaboration.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
repo_collaboration_test.go Rename `repo.GetOwner` to `repo.LoadOwner` (#22967) 2023-02-18 20:11:03 +08:00
repo_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_transfer.go Always reuse transaction (#22362) 2023-01-08 09:34:58 +08:00
repo_transfer_test.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00