mirror of
1
Fork 0
forgejo/services/repository
oliverpool 07bc099401 [BUG] split code conversations in diff tab (#2306)
Follow-up of #2282 and #2296 (which tried to address #2278)

One of the issue with the previous PR is that when a conversation on the Files tab was marked as "resolved", it would fetch all the comments for that line (even the outdated ones, which should not be shown on this page - except when explicitly activated).

To properly fix this, I have changed `FetchCodeCommentsByLine` to `FetchCodeConversation`. Its role is to fetch all comments related to a given (review, path, line) and reverted my changes in the template (which were based on a misunderstanding).

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2306
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
2024-02-16 14:06:43 +01:00
..
archiver Next round of `db.DefaultContext` refactor (#27089) 2023-09-16 14:39:12 +00:00
files [BUG] split code conversations in diff tab (#2306) 2024-02-16 14:06:43 +01:00
adopt.go Delete repos of org when purge delete user (#27273) (#27728) 2023-11-01 10:03:12 +08:00
adopt_test.go Use more specific test methods (#24265) 2023-04-22 17:56:27 -04:00
avatar.go Improve avatar uploading / resizing / compressing, remove Fomantic card module (#24653) 2023-05-13 20:59:11 +02:00
avatar_test.go Use context parameter in services/repository (#23186) 2023-02-28 16:17:51 -06:00
branch.go services: Gracefully handle missing branches 2024-01-15 00:15:12 +01:00
cache.go Use the type RefName for all the needed places and fix pull mirror sync bugs (#24634) 2023-05-26 01:04:48 +00:00
check.go move repository deletion to service layer (#26948) 2023-09-08 04:51:15 +00:00
collaboration.go Fix `DeleteCollaboration` transaction behaviour (#28886) (#28889) 2024-01-31 14:18:26 +01:00
collaboration_test.go Next round of `db.DefaultContext` refactor (#27089) 2023-09-16 14:39:12 +00:00
commit.go Show branches and tags that contain a commit (#25180) 2023-07-27 12:47:41 +02:00
create.go move repository deletion to service layer (#26948) 2023-09-08 04:51:15 +00:00
create_test.go More refactoring of `db.DefaultContext` (#27083) 2023-09-15 06:13:19 +00:00
delete.go Delete repos of org when purge delete user (#27273) (#27728) 2023-11-01 10:03:12 +08:00
delete_test.go Delete repos of org when purge delete user (#27273) (#27728) 2023-11-01 10:03:12 +08:00
fork.go Another round of `db.DefaultContext` refactor (#27103) (#27262) 2023-09-25 19:24:35 +02:00
fork_test.go Add option to prohibit fork if user reached maximum limit of repositories (#21848) 2022-12-27 15:21:14 -06:00
hooks.go Add user webhooks (#21563) 2023-03-10 08:28:32 -06:00
lfs.go Fix bugs in LFS meta garbage collection (#26122) 2023-07-26 07:02:53 +00:00
lfs_test.go Delete repos of org when purge delete user (#27273) (#27728) 2023-11-01 10:03:12 +08:00
main_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
push.go Also sync DB branches on push if necessary (#28361) (#28403) 2023-12-12 15:21:33 +01:00
repository.go Next round of `db.DefaultContext` refactor (#27089) 2023-09-16 14:39:12 +00:00
repository_test.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
review.go Use context parameter in services/repository (#23186) 2023-02-28 16:17:51 -06:00
review_test.go Use context parameter in services/repository (#23186) 2023-02-28 16:17:51 -06:00
template.go Move notification interface to services layer (#26915) 2023-09-05 18:37:47 +00:00
transfer.go [MODERATION] User blocking 2023-11-13 13:58:02 +01:00
transfer_test.go [MODERATION] User blocking 2023-11-13 13:58:02 +01:00