mirror of
1
Fork 0
forgejo/services/mailer
KN4CK3R 637451a45e
Rework markup link rendering (#26745)
Fixes #26548

This PR refactors the rendering of markup links. The old code uses
`strings.Replace` to change some urls while the new code uses more
context to decide which link should be generated.

The added tests should ensure the same output for the old and new
behaviour (besides the bug).

We may need to refactor the rendering a bit more to make it clear how
the different helper methods render the input string. There are lots of
options (resolve links / images / mentions / git hashes / emojis / ...)
but you don't really know what helper uses which options. For example,
we currently support images in the user description which should not be
allowed I think:

<details>
  <summary>Profile</summary> 

https://try.gitea.io/KN4CK3R

![grafik](https://github.com/go-gitea/gitea/assets/1666336/109ae422-496d-4200-b52e-b3a528f553e5)

</details>

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-01-15 08:49:24 +00:00
..
incoming Even more `db.DefaultContext` refactor (#27352) 2023-10-03 10:30:41 +00:00
token Use minio/sha256-simd for accelerated SHA256 (#23052) 2023-02-22 14:21:46 -05:00
mail.go Rework markup link rendering (#26745) 2024-01-15 08:49:24 +00:00
mail_comment.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
mail_issue.go Clean up template locale usage (#27856) 2023-10-31 22:11:48 +08:00
mail_release.go Rework markup link rendering (#26745) 2024-01-15 08:49:24 +00:00
mail_repo.go Clean up template locale usage (#27856) 2023-10-31 22:11:48 +08:00
mail_team_invite.go Clean up template locale usage (#27856) 2023-10-31 22:11:48 +08:00
mail_test.go Add support for incoming emails (#22056) 2023-01-14 23:57:10 +08:00
mailer.go Clean up template locale usage (#27856) 2023-10-31 22:11:48 +08:00
mailer_test.go Prevent multiple `To` recipients (#22566) 2023-01-22 08:23:52 -06:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
notify.go Penultimate round of `db.DefaultContext` refactor (#27414) 2023-10-11 04:24:07 +00:00