mirror of
1
Fork 0
forgejo/models/issues
Jason Song 477a1cc40e
Improve utils of slices (#22379)
- Move the file `compare.go` and `slice.go` to `slice.go`.
- Fix `ExistsInSlice`, it's buggy
  - It uses `sort.Search`, so it assumes that the input slice is sorted.
- It passes `func(i int) bool { return slice[i] == target })` to
`sort.Search`, that's incorrect, check the doc of `sort.Search`.
- Conbine `IsInt64InSlice(int64, []int64)` and `ExistsInSlice(string,
[]string)` to `SliceContains[T]([]T, T)`.
- Conbine `IsSliceInt64Eq([]int64, []int64)` and `IsEqualSlice([]string,
[]string)` to `SliceSortedEqual[T]([]T, T)`.
- Add `SliceEqual[T]([]T, T)` as a distinction from
`SliceSortedEqual[T]([]T, T)`.
- Redesign `RemoveIDFromList([]int64, int64) ([]int64, bool)` to
`SliceRemoveAll[T]([]T, T) []T`.
- Add `SliceContainsFunc[T]([]T, func(T) bool)` and
`SliceRemoveAllFunc[T]([]T, func(T) bool)` for general use.
- Add comments to explain why not `golang.org/x/exp/slices`.
- Add unit tests.
2023-01-11 13:31:16 +08:00
..
assignees.go Improve utils of slices (#22379) 2023-01-11 13:31:16 +08:00
assignees_test.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
comment.go Use context parameter in models/git (#22367) 2023-01-09 11:50:54 +08:00
comment_list.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
comment_test.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
content_history.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
content_history_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
dependency.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
dependency_test.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
issue.go Improve utils of slices (#22379) 2023-01-11 13:31:16 +08:00
issue_index.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_list.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
issue_list_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_lock.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
issue_project.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
issue_test.go Check primary keys for all tables and drop ForeignReference (#21721) 2022-12-23 19:35:43 +08:00
issue_user.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_user_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_watch.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_watch_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_xref.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
issue_xref_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
label.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
label_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
main_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
milestone.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
milestone_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
pull.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
pull_list.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
pull_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
reaction.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
reaction_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
review.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
review_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
stopwatch.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
stopwatch_test.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
tracked_time.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
tracked_time_test.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00