mirror of
1
Fork 0
forgejo/routers/api/v1/repo
Gergely Nagy be8d16438a
Fix `/api/v1/{owner}/{repo}/issue_templates`
When issue templates were moved into services in
def4956122, the code was also refactored
and simplified. Unfortunately, that simplification broke the
`/api/v1/{owner}/{repo}/issue_templates` route, because it was
previously using a helper function that ignored invalid templates, and
after the refactor, the function it called *always* returned non-nil as
the second return value. This, in turn, results in the aforementioned
end point always returning an internal server error.

This change restores the previous behaviour of ignoring invalid files
returned by `issue.GetTemplatesFromDefaultBranch`, and adds a few test
cases to exercise the endpoint.

Other users of `GetTemplatesFromDefaultBranch` already ignore the second
return value, or handle it correctly, so no changes are necessary there.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
2024-02-05 20:58:41 +01:00
..
action.go Refactor secrets modification logic (#26873) 2023-09-05 15:21:02 +00:00
avatar.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
blob.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
branch.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
collaborators.go Move more functions to db.Find (#28419) 2024-01-15 02:19:25 +00:00
commits.go Update tool dependencies (#29030) 2024-02-02 19:11:39 -05:00
file.go [GITEA] Fix API inconsistencies 2024-02-05 16:09:43 +01:00
flags.go [FEAT] API support for repository flags 2024-02-05 16:09:42 +01:00
fork.go Even more `db.DefaultContext` refactor (#27352) 2023-10-03 10:30:41 +00:00
git_hook.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
git_ref.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
hook.go Use db.Find instead of writing methods for every object (#28084) 2023-11-24 03:49:41 +00:00
hook_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
issue.go [FEAT] allow setting the update date on issues and comments 2024-02-05 14:44:33 +01:00
issue_attachment.go [FEAT] allow setting the update date on issues and comments 2024-02-05 14:44:33 +01:00
issue_comment.go [GITEA] DELETE /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments/{comment} 2024-02-05 16:09:43 +01:00
issue_comment_attachment.go [GITEA] API commentAssignment() to verify the id belongs 2024-02-05 16:09:43 +01:00
issue_dependency.go Fix issue dependencies (#27736) 2024-01-12 16:49:02 +00:00
issue_label.go [FEAT] allow setting the update date on issues and comments 2024-02-05 14:44:33 +01:00
issue_pin.go Even more `db.DefaultContext` refactor (#27352) 2023-10-03 10:30:41 +00:00
issue_reaction.go [GITEA] API commentAssignment() to verify the id belongs 2024-02-05 16:09:43 +01:00
issue_stopwatch.go Final round of `db.DefaultContext` refactor (#27587) 2023-10-14 08:37:24 +00:00
issue_subscription.go Even more `db.DefaultContext` refactor (#27352) 2023-10-03 10:30:41 +00:00
issue_tracked_time.go Final round of `db.DefaultContext` refactor (#27587) 2023-10-14 08:37:24 +00:00
key.go Fix comment permissions (#28213) 2023-11-25 17:21:21 +00:00
label.go Next round of `db.DefaultContext` refactor (#27089) 2023-09-16 14:39:12 +00:00
language.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
migrate.go Remove unnecessary parameter (#27671) 2023-10-18 15:03:10 +00:00
milestone.go Second part of refactor `db.Find` (#28194) 2023-12-11 16:56:48 +08:00
mirror.go Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
notes.go Abstract hash function usage (#28138) 2023-12-13 21:02:00 +00:00
patch.go Updates to the API for archived repos (#27149) 2023-09-21 23:43:29 +00:00
pull.go Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
pull_review.go [GITEA] DELETE /repos/{owner}/{repo}/pulls/{index}/reviews/{id}/comments/{comment} 2024-02-05 16:09:43 +01:00
release.go Move more functions to db.Find (#28419) 2024-01-15 02:19:25 +00:00
release_attachment.go Fix comment permissions (#28213) 2023-11-25 17:21:21 +00:00
release_tags.go Fix comment permissions (#28213) 2023-11-25 17:21:21 +00:00
repo.go Fix `/api/v1/{owner}/{repo}/issue_templates` 2024-02-05 20:58:41 +01:00
repo_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
runners.go Add get actions runner registration token for API routes, repo, org, user and global level (#27144) 2023-12-27 07:57:54 +00:00
star.go More refactoring of `db.DefaultContext` (#27083) 2023-09-15 06:13:19 +00:00
status.go Fix `GetCommitStatuses` (#28787) 2024-01-15 14:07:32 +00:00
subscriber.go More refactoring of `db.DefaultContext` (#27083) 2023-09-15 06:13:19 +00:00
tag.go [GITEA] Document correct status code for creating Tag 2024-02-05 16:09:43 +01:00
teams.go More refactoring of `db.DefaultContext` (#27083) 2023-09-15 06:13:19 +00:00
topic.go Next round of `db.DefaultContext` refactor (#27089) 2023-09-16 14:39:12 +00:00
transfer.go Move some repository transfer functions to service layer (#28855) 2024-02-05 06:17:23 +00:00
tree.go Add missing 404 response to Swagger (#27038) 2023-09-13 10:37:54 +08:00
wiki.go Revert "Fix an actions schedule bug (#28942)" 2024-02-05 16:53:39 +01:00