2023-03-12 16:00:57 +01:00
|
|
|
// GoToSocial
|
|
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
|
|
//
|
|
|
|
// This program is free software: you can redistribute it and/or modify
|
|
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
|
|
// (at your option) any later version.
|
|
|
|
//
|
|
|
|
// This program is distributed in the hope that it will be useful,
|
|
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
// GNU Affero General Public License for more details.
|
|
|
|
//
|
|
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
2021-02-28 15:17:18 +01:00
|
|
|
|
2021-05-30 13:12:00 +02:00
|
|
|
package processing
|
2021-04-01 20:46:45 +02:00
|
|
|
|
2021-05-27 16:06:24 +02:00
|
|
|
import (
|
2021-08-25 15:34:33 +02:00
|
|
|
"context"
|
2023-03-19 13:11:46 +01:00
|
|
|
"errors"
|
2021-05-27 16:06:24 +02:00
|
|
|
"fmt"
|
|
|
|
|
2023-03-19 13:11:46 +01:00
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/config"
|
2021-05-27 16:06:24 +02:00
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/db"
|
2023-03-19 13:11:46 +01:00
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/email"
|
2023-03-20 19:10:08 +01:00
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtserror"
|
2021-05-27 16:06:24 +02:00
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
|
2021-06-13 18:42:28 +02:00
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/id"
|
2021-11-22 19:03:21 +01:00
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/stream"
|
2021-05-27 16:06:24 +02:00
|
|
|
)
|
2021-04-01 20:46:45 +02:00
|
|
|
|
2023-02-22 16:05:26 +01:00
|
|
|
func (p *Processor) notifyStatus(ctx context.Context, status *gtsmodel.Status) error {
|
2021-05-27 16:06:24 +02:00
|
|
|
// if there are no mentions in this status then just bail
|
2021-08-20 12:26:56 +02:00
|
|
|
if len(status.MentionIDs) == 0 {
|
2021-05-27 16:06:24 +02:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2021-08-20 12:26:56 +02:00
|
|
|
if status.Mentions == nil {
|
2021-05-27 16:06:24 +02:00
|
|
|
// there are mentions but they're not fully populated on the status yet so do this
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
mentions, err := p.state.DB.GetMentions(ctx, status.MentionIDs)
|
2021-08-20 12:26:56 +02:00
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("notifyStatus: error getting mentions for status %s from the db: %s", status.ID, err)
|
2021-05-27 16:06:24 +02:00
|
|
|
}
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
|
|
|
|
status.Mentions = mentions
|
2021-05-27 16:06:24 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
// now we have mentions as full gtsmodel.Mention structs on the status we can continue
|
2021-08-20 12:26:56 +02:00
|
|
|
for _, m := range status.Mentions {
|
2021-05-27 16:06:24 +02:00
|
|
|
// make sure this is a local account, otherwise we don't need to create a notification for it
|
2021-08-20 12:26:56 +02:00
|
|
|
if m.TargetAccount == nil {
|
2023-03-01 19:26:53 +01:00
|
|
|
a, err := p.state.DB.GetAccountByID(ctx, m.TargetAccountID)
|
2021-08-20 12:26:56 +02:00
|
|
|
if err != nil {
|
2021-05-27 16:06:24 +02:00
|
|
|
// we don't have the account or there's been an error
|
|
|
|
return fmt.Errorf("notifyStatus: error getting account with id %s from the db: %s", m.TargetAccountID, err)
|
|
|
|
}
|
2021-08-20 12:26:56 +02:00
|
|
|
m.TargetAccount = a
|
2021-05-27 16:06:24 +02:00
|
|
|
}
|
2021-08-20 12:26:56 +02:00
|
|
|
if m.TargetAccount.Domain != "" {
|
2021-05-27 16:06:24 +02:00
|
|
|
// not a local account so skip it
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
// make sure a notif doesn't already exist for this mention
|
2023-03-01 19:26:53 +01:00
|
|
|
if err := p.state.DB.GetWhere(ctx, []db.Where{
|
2021-05-27 16:06:24 +02:00
|
|
|
{Key: "notification_type", Value: gtsmodel.NotificationMention},
|
|
|
|
{Key: "target_account_id", Value: m.TargetAccountID},
|
2021-09-04 13:29:56 +02:00
|
|
|
{Key: "origin_account_id", Value: m.OriginAccountID},
|
|
|
|
{Key: "status_id", Value: m.StatusID},
|
|
|
|
}, >smodel.Notification{}); err == nil {
|
2021-05-27 16:06:24 +02:00
|
|
|
// notification exists already so just continue
|
|
|
|
continue
|
2021-09-04 13:29:56 +02:00
|
|
|
} else if err != db.ErrNoEntries {
|
2021-05-27 16:06:24 +02:00
|
|
|
// there's a real error in the db
|
|
|
|
return fmt.Errorf("notifyStatus: error checking existence of notification for mention with id %s : %s", m.ID, err)
|
|
|
|
}
|
|
|
|
|
|
|
|
// if we've reached this point we know the mention is for a local account, and the notification doesn't exist, so create it
|
|
|
|
notif := >smodel.Notification{
|
2023-02-03 21:03:05 +01:00
|
|
|
ID: id.NewULID(),
|
2021-05-27 16:06:24 +02:00
|
|
|
NotificationType: gtsmodel.NotificationMention,
|
|
|
|
TargetAccountID: m.TargetAccountID,
|
2021-08-20 12:26:56 +02:00
|
|
|
TargetAccount: m.TargetAccount,
|
2021-05-27 16:06:24 +02:00
|
|
|
OriginAccountID: status.AccountID,
|
2021-08-20 12:26:56 +02:00
|
|
|
OriginAccount: status.Account,
|
2021-05-27 16:06:24 +02:00
|
|
|
StatusID: status.ID,
|
2021-08-20 12:26:56 +02:00
|
|
|
Status: status,
|
2021-05-27 16:06:24 +02:00
|
|
|
}
|
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
if err := p.state.DB.PutNotification(ctx, notif); err != nil {
|
2021-05-27 16:06:24 +02:00
|
|
|
return fmt.Errorf("notifyStatus: error putting notification in database: %s", err)
|
|
|
|
}
|
2021-06-19 11:18:55 +02:00
|
|
|
|
|
|
|
// now stream the notification to the user
|
2021-10-04 15:24:19 +02:00
|
|
|
apiNotif, err := p.tc.NotificationToAPINotification(ctx, notif)
|
2021-06-19 11:18:55 +02:00
|
|
|
if err != nil {
|
2021-10-04 15:24:19 +02:00
|
|
|
return fmt.Errorf("notifyStatus: error converting notification to api representation: %s", err)
|
2021-06-19 11:18:55 +02:00
|
|
|
}
|
|
|
|
|
2023-02-22 16:05:26 +01:00
|
|
|
if err := p.stream.Notify(apiNotif, m.TargetAccount); err != nil {
|
2021-06-19 11:18:55 +02:00
|
|
|
return fmt.Errorf("notifyStatus: error streaming notification to account: %s", err)
|
|
|
|
}
|
2021-05-27 16:06:24 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2023-02-22 16:05:26 +01:00
|
|
|
func (p *Processor) notifyFollowRequest(ctx context.Context, followRequest *gtsmodel.FollowRequest) error {
|
2021-10-01 19:08:50 +02:00
|
|
|
// make sure we have the target account pinned on the follow request
|
|
|
|
if followRequest.TargetAccount == nil {
|
2023-03-01 19:26:53 +01:00
|
|
|
a, err := p.state.DB.GetAccountByID(ctx, followRequest.TargetAccountID)
|
2021-10-01 19:08:50 +02:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
followRequest.TargetAccount = a
|
|
|
|
}
|
|
|
|
targetAccount := followRequest.TargetAccount
|
|
|
|
|
2021-05-27 16:06:24 +02:00
|
|
|
// return if this isn't a local account
|
2021-10-01 19:08:50 +02:00
|
|
|
if targetAccount.Domain != "" {
|
|
|
|
// this isn't a local account so we've got nothing to do here
|
2021-05-27 16:06:24 +02:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
notif := >smodel.Notification{
|
2023-02-03 21:03:05 +01:00
|
|
|
ID: id.NewULID(),
|
2021-05-27 16:06:24 +02:00
|
|
|
NotificationType: gtsmodel.NotificationFollowRequest,
|
|
|
|
TargetAccountID: followRequest.TargetAccountID,
|
|
|
|
OriginAccountID: followRequest.AccountID,
|
|
|
|
}
|
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
if err := p.state.DB.PutNotification(ctx, notif); err != nil {
|
2021-05-27 16:06:24 +02:00
|
|
|
return fmt.Errorf("notifyFollowRequest: error putting notification in database: %s", err)
|
|
|
|
}
|
|
|
|
|
2021-06-19 11:18:55 +02:00
|
|
|
// now stream the notification to the user
|
2021-10-04 15:24:19 +02:00
|
|
|
apiNotif, err := p.tc.NotificationToAPINotification(ctx, notif)
|
2021-06-19 11:18:55 +02:00
|
|
|
if err != nil {
|
2021-10-04 15:24:19 +02:00
|
|
|
return fmt.Errorf("notifyStatus: error converting notification to api representation: %s", err)
|
2021-06-19 11:18:55 +02:00
|
|
|
}
|
|
|
|
|
2023-02-22 16:05:26 +01:00
|
|
|
if err := p.stream.Notify(apiNotif, targetAccount); err != nil {
|
2021-06-19 11:18:55 +02:00
|
|
|
return fmt.Errorf("notifyStatus: error streaming notification to account: %s", err)
|
|
|
|
}
|
|
|
|
|
2021-05-17 19:06:58 +02:00
|
|
|
return nil
|
2021-03-22 22:26:54 +01:00
|
|
|
}
|
2021-05-21 15:48:26 +02:00
|
|
|
|
2023-02-22 16:05:26 +01:00
|
|
|
func (p *Processor) notifyFollow(ctx context.Context, follow *gtsmodel.Follow, targetAccount *gtsmodel.Account) error {
|
2021-05-27 16:06:24 +02:00
|
|
|
// return if this isn't a local account
|
2021-08-20 12:26:56 +02:00
|
|
|
if targetAccount.Domain != "" {
|
2021-05-27 16:06:24 +02:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// first remove the follow request notification
|
2023-03-01 19:26:53 +01:00
|
|
|
if err := p.state.DB.DeleteWhere(ctx, []db.Where{
|
2021-05-27 16:06:24 +02:00
|
|
|
{Key: "notification_type", Value: gtsmodel.NotificationFollowRequest},
|
|
|
|
{Key: "target_account_id", Value: follow.TargetAccountID},
|
|
|
|
{Key: "origin_account_id", Value: follow.AccountID},
|
|
|
|
}, >smodel.Notification{}); err != nil {
|
|
|
|
return fmt.Errorf("notifyFollow: error removing old follow request notification from database: %s", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
// now create the new follow notification
|
|
|
|
notif := >smodel.Notification{
|
2023-02-03 21:03:05 +01:00
|
|
|
ID: id.NewULID(),
|
2021-05-27 16:06:24 +02:00
|
|
|
NotificationType: gtsmodel.NotificationFollow,
|
|
|
|
TargetAccountID: follow.TargetAccountID,
|
2021-08-20 12:26:56 +02:00
|
|
|
TargetAccount: follow.TargetAccount,
|
2021-05-27 16:06:24 +02:00
|
|
|
OriginAccountID: follow.AccountID,
|
2021-08-20 12:26:56 +02:00
|
|
|
OriginAccount: follow.Account,
|
2021-05-27 16:06:24 +02:00
|
|
|
}
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
if err := p.state.DB.PutNotification(ctx, notif); err != nil {
|
2021-05-27 16:06:24 +02:00
|
|
|
return fmt.Errorf("notifyFollow: error putting notification in database: %s", err)
|
|
|
|
}
|
|
|
|
|
2021-06-19 11:18:55 +02:00
|
|
|
// now stream the notification to the user
|
2021-10-04 15:24:19 +02:00
|
|
|
apiNotif, err := p.tc.NotificationToAPINotification(ctx, notif)
|
2021-06-19 11:18:55 +02:00
|
|
|
if err != nil {
|
2021-10-04 15:24:19 +02:00
|
|
|
return fmt.Errorf("notifyStatus: error converting notification to api representation: %s", err)
|
2021-06-19 11:18:55 +02:00
|
|
|
}
|
|
|
|
|
2023-02-22 16:05:26 +01:00
|
|
|
if err := p.stream.Notify(apiNotif, targetAccount); err != nil {
|
2021-06-19 11:18:55 +02:00
|
|
|
return fmt.Errorf("notifyStatus: error streaming notification to account: %s", err)
|
|
|
|
}
|
|
|
|
|
2021-05-21 23:04:59 +02:00
|
|
|
return nil
|
2021-05-21 15:48:26 +02:00
|
|
|
}
|
2021-05-24 18:49:48 +02:00
|
|
|
|
2023-02-22 16:05:26 +01:00
|
|
|
func (p *Processor) notifyFave(ctx context.Context, fave *gtsmodel.StatusFave) error {
|
2022-08-30 11:43:29 +02:00
|
|
|
// ignore self-faves
|
|
|
|
if fave.TargetAccountID == fave.AccountID {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2021-09-27 17:42:20 +02:00
|
|
|
if fave.TargetAccount == nil {
|
2023-03-01 19:26:53 +01:00
|
|
|
a, err := p.state.DB.GetAccountByID(ctx, fave.TargetAccountID)
|
2021-09-27 17:42:20 +02:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
fave.TargetAccount = a
|
|
|
|
}
|
|
|
|
targetAccount := fave.TargetAccount
|
|
|
|
|
|
|
|
// just return if target isn't a local account
|
2021-08-20 12:26:56 +02:00
|
|
|
if targetAccount.Domain != "" {
|
2021-05-27 16:06:24 +02:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
notif := >smodel.Notification{
|
2023-02-03 21:03:05 +01:00
|
|
|
ID: id.NewULID(),
|
2021-05-27 16:06:24 +02:00
|
|
|
NotificationType: gtsmodel.NotificationFave,
|
|
|
|
TargetAccountID: fave.TargetAccountID,
|
2021-08-20 12:26:56 +02:00
|
|
|
TargetAccount: fave.TargetAccount,
|
2021-05-27 16:06:24 +02:00
|
|
|
OriginAccountID: fave.AccountID,
|
2021-08-20 12:26:56 +02:00
|
|
|
OriginAccount: fave.Account,
|
2021-05-27 16:06:24 +02:00
|
|
|
StatusID: fave.StatusID,
|
2021-08-20 12:26:56 +02:00
|
|
|
Status: fave.Status,
|
2021-05-27 16:06:24 +02:00
|
|
|
}
|
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
if err := p.state.DB.PutNotification(ctx, notif); err != nil {
|
2021-05-27 16:06:24 +02:00
|
|
|
return fmt.Errorf("notifyFave: error putting notification in database: %s", err)
|
|
|
|
}
|
|
|
|
|
2021-06-19 11:18:55 +02:00
|
|
|
// now stream the notification to the user
|
2021-10-04 15:24:19 +02:00
|
|
|
apiNotif, err := p.tc.NotificationToAPINotification(ctx, notif)
|
2021-06-19 11:18:55 +02:00
|
|
|
if err != nil {
|
2021-10-04 15:24:19 +02:00
|
|
|
return fmt.Errorf("notifyStatus: error converting notification to api representation: %s", err)
|
2021-06-19 11:18:55 +02:00
|
|
|
}
|
|
|
|
|
2023-02-22 16:05:26 +01:00
|
|
|
if err := p.stream.Notify(apiNotif, targetAccount); err != nil {
|
2021-06-19 11:18:55 +02:00
|
|
|
return fmt.Errorf("notifyStatus: error streaming notification to account: %s", err)
|
|
|
|
}
|
|
|
|
|
2021-05-27 16:06:24 +02:00
|
|
|
return nil
|
2021-05-24 18:49:48 +02:00
|
|
|
}
|
2021-05-28 19:57:04 +02:00
|
|
|
|
2023-02-22 16:05:26 +01:00
|
|
|
func (p *Processor) notifyAnnounce(ctx context.Context, status *gtsmodel.Status) error {
|
2021-05-31 17:36:35 +02:00
|
|
|
if status.BoostOfID == "" {
|
|
|
|
// not a boost, nothing to do
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2021-08-20 12:26:56 +02:00
|
|
|
if status.BoostOf == nil {
|
2023-03-01 19:26:53 +01:00
|
|
|
boostedStatus, err := p.state.DB.GetStatusByID(ctx, status.BoostOfID)
|
2021-08-20 12:26:56 +02:00
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("notifyAnnounce: error getting status with id %s: %s", status.BoostOfID, err)
|
|
|
|
}
|
|
|
|
status.BoostOf = boostedStatus
|
2021-05-31 17:36:35 +02:00
|
|
|
}
|
|
|
|
|
2021-08-20 12:26:56 +02:00
|
|
|
if status.BoostOfAccount == nil {
|
2023-03-01 19:26:53 +01:00
|
|
|
boostedAcct, err := p.state.DB.GetAccountByID(ctx, status.BoostOfAccountID)
|
2021-08-20 12:26:56 +02:00
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("notifyAnnounce: error getting account with id %s: %s", status.BoostOfAccountID, err)
|
|
|
|
}
|
|
|
|
status.BoostOf.Account = boostedAcct
|
|
|
|
status.BoostOfAccount = boostedAcct
|
2021-05-31 17:36:35 +02:00
|
|
|
}
|
|
|
|
|
2021-09-04 13:29:56 +02:00
|
|
|
if status.BoostOfAccount.Domain != "" {
|
2021-05-31 17:36:35 +02:00
|
|
|
// remote account, nothing to do
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2021-08-20 12:26:56 +02:00
|
|
|
if status.BoostOfAccountID == status.AccountID {
|
2021-05-31 17:36:35 +02:00
|
|
|
// it's a self boost, nothing to do
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// make sure a notif doesn't already exist for this announce
|
2023-03-01 19:26:53 +01:00
|
|
|
err := p.state.DB.GetWhere(ctx, []db.Where{
|
2021-05-31 17:36:35 +02:00
|
|
|
{Key: "notification_type", Value: gtsmodel.NotificationReblog},
|
2021-08-20 12:26:56 +02:00
|
|
|
{Key: "target_account_id", Value: status.BoostOfAccountID},
|
2021-05-31 17:36:35 +02:00
|
|
|
{Key: "origin_account_id", Value: status.AccountID},
|
|
|
|
{Key: "status_id", Value: status.ID},
|
|
|
|
}, >smodel.Notification{})
|
|
|
|
if err == nil {
|
|
|
|
// notification exists already so just bail
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// now create the new reblog notification
|
|
|
|
notif := >smodel.Notification{
|
2023-02-03 21:03:05 +01:00
|
|
|
ID: id.NewULID(),
|
2021-05-31 17:36:35 +02:00
|
|
|
NotificationType: gtsmodel.NotificationReblog,
|
2021-08-20 12:26:56 +02:00
|
|
|
TargetAccountID: status.BoostOfAccountID,
|
|
|
|
TargetAccount: status.BoostOfAccount,
|
2021-05-31 17:36:35 +02:00
|
|
|
OriginAccountID: status.AccountID,
|
2021-08-20 12:26:56 +02:00
|
|
|
OriginAccount: status.Account,
|
2021-05-31 17:36:35 +02:00
|
|
|
StatusID: status.ID,
|
2021-08-20 12:26:56 +02:00
|
|
|
Status: status,
|
2021-05-31 17:36:35 +02:00
|
|
|
}
|
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
if err := p.state.DB.PutNotification(ctx, notif); err != nil {
|
2021-05-31 17:36:35 +02:00
|
|
|
return fmt.Errorf("notifyAnnounce: error putting notification in database: %s", err)
|
|
|
|
}
|
|
|
|
|
2021-06-19 11:18:55 +02:00
|
|
|
// now stream the notification to the user
|
2021-10-04 15:24:19 +02:00
|
|
|
apiNotif, err := p.tc.NotificationToAPINotification(ctx, notif)
|
2021-06-19 11:18:55 +02:00
|
|
|
if err != nil {
|
2021-10-04 15:24:19 +02:00
|
|
|
return fmt.Errorf("notifyStatus: error converting notification to api representation: %s", err)
|
2021-06-19 11:18:55 +02:00
|
|
|
}
|
|
|
|
|
2023-02-22 16:05:26 +01:00
|
|
|
if err := p.stream.Notify(apiNotif, status.BoostOfAccount); err != nil {
|
2021-06-19 11:18:55 +02:00
|
|
|
return fmt.Errorf("notifyStatus: error streaming notification to account: %s", err)
|
|
|
|
}
|
|
|
|
|
2021-05-28 19:57:04 +02:00
|
|
|
return nil
|
|
|
|
}
|
2023-03-19 13:11:46 +01:00
|
|
|
|
|
|
|
func (p *Processor) notifyReport(ctx context.Context, report *gtsmodel.Report) error {
|
|
|
|
instance, err := p.state.DB.GetInstance(ctx, config.GetHost())
|
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("notifyReport: error getting instance: %w", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
toAddresses, err := p.state.DB.GetInstanceModeratorAddresses(ctx)
|
|
|
|
if err != nil {
|
|
|
|
if errors.Is(err, db.ErrNoEntries) {
|
|
|
|
// No registered moderator addresses.
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
return fmt.Errorf("notifyReport: error getting instance moderator addresses: %w", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
if report.Account == nil {
|
|
|
|
report.Account, err = p.state.DB.GetAccountByID(ctx, report.AccountID)
|
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("notifyReport: error getting report account: %w", err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if report.TargetAccount == nil {
|
|
|
|
report.TargetAccount, err = p.state.DB.GetAccountByID(ctx, report.TargetAccountID)
|
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("notifyReport: error getting report target account: %w", err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
reportData := email.NewReportData{
|
|
|
|
InstanceURL: instance.URI,
|
|
|
|
InstanceName: instance.Title,
|
|
|
|
ReportURL: instance.URI + "/settings/admin/reports/" + report.ID,
|
|
|
|
ReportDomain: report.Account.Domain,
|
|
|
|
ReportTargetDomain: report.TargetAccount.Domain,
|
|
|
|
}
|
|
|
|
|
|
|
|
if err := p.emailSender.SendNewReportEmail(toAddresses, reportData); err != nil {
|
|
|
|
return fmt.Errorf("notifyReport: error emailing instance moderators: %w", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (p *Processor) notifyReportClosed(ctx context.Context, report *gtsmodel.Report) error {
|
|
|
|
user, err := p.state.DB.GetUserByAccountID(ctx, report.Account.ID)
|
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("notifyReportClosed: db error getting user: %w", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
if user.ConfirmedAt.IsZero() || !*user.Approved || *user.Disabled || user.Email == "" {
|
|
|
|
// Only email users who:
|
|
|
|
// - are confirmed
|
|
|
|
// - are approved
|
|
|
|
// - are not disabled
|
|
|
|
// - have an email address
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
instance, err := p.state.DB.GetInstance(ctx, config.GetHost())
|
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("notifyReportClosed: db error getting instance: %w", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
if report.Account == nil {
|
|
|
|
report.Account, err = p.state.DB.GetAccountByID(ctx, report.AccountID)
|
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("notifyReportClosed: error getting report account: %w", err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if report.TargetAccount == nil {
|
|
|
|
report.TargetAccount, err = p.state.DB.GetAccountByID(ctx, report.TargetAccountID)
|
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("notifyReportClosed: error getting report target account: %w", err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
reportClosedData := email.ReportClosedData{
|
|
|
|
Username: report.Account.Username,
|
|
|
|
InstanceURL: instance.URI,
|
|
|
|
InstanceName: instance.Title,
|
|
|
|
ReportTargetUsername: report.TargetAccount.Username,
|
|
|
|
ReportTargetDomain: report.TargetAccount.Domain,
|
|
|
|
ActionTakenComment: report.ActionTaken,
|
|
|
|
}
|
|
|
|
|
|
|
|
return p.emailSender.SendReportClosedEmail(user.Email, reportClosedData)
|
|
|
|
}
|
2021-06-13 18:42:28 +02:00
|
|
|
|
2021-11-22 19:03:21 +01:00
|
|
|
// timelineStatus processes the given new status and inserts it into
|
|
|
|
// the HOME timelines of accounts that follow the status author.
|
2023-02-22 16:05:26 +01:00
|
|
|
func (p *Processor) timelineStatus(ctx context.Context, status *gtsmodel.Status) error {
|
2021-08-20 12:26:56 +02:00
|
|
|
if status.Account == nil {
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
// ensure status fully populated (including account)
|
|
|
|
if err := p.state.DB.PopulateStatus(ctx, status); err != nil {
|
|
|
|
return fmt.Errorf("timelineStatus: error populating status with id %s: %w", status.ID, err)
|
2021-06-13 18:42:28 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
// get local followers of the account that posted the status
|
|
|
|
follows, err := p.state.DB.GetAccountLocalFollowers(ctx, status.AccountID)
|
2021-08-20 12:26:56 +02:00
|
|
|
if err != nil {
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
return fmt.Errorf("timelineStatus: error getting followers for account id %s: %w", status.AccountID, err)
|
2021-06-13 18:42:28 +02:00
|
|
|
}
|
|
|
|
|
2023-03-20 19:10:08 +01:00
|
|
|
// If the poster is also local, add a fake entry for them
|
|
|
|
// so they can see their own status in their timeline.
|
|
|
|
if status.Account.IsLocal() {
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
follows = append(follows, >smodel.Follow{
|
|
|
|
AccountID: status.AccountID,
|
|
|
|
Account: status.Account,
|
|
|
|
})
|
2021-06-13 18:42:28 +02:00
|
|
|
}
|
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
var errs gtserror.MultiError
|
|
|
|
|
|
|
|
for _, follow := range follows {
|
|
|
|
// Timeline the status for each local following account.
|
|
|
|
if err := p.timelineStatusForAccount(ctx, follow.Account, status); err != nil {
|
|
|
|
errs.Append(err)
|
2021-06-13 18:42:28 +02:00
|
|
|
}
|
2023-03-20 19:10:08 +01:00
|
|
|
}
|
2021-06-13 18:42:28 +02:00
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
if len(errs) != 0 {
|
|
|
|
return fmt.Errorf("timelineStatus: one or more errors timelining statuses: %w", errs.Combine())
|
2021-06-13 18:42:28 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2021-11-22 19:03:21 +01:00
|
|
|
// timelineStatusForAccount puts the given status in the HOME timeline
|
|
|
|
// of the account with given accountID, if it's hometimelineable.
|
|
|
|
//
|
|
|
|
// If the status was inserted into the home timeline of the given account,
|
|
|
|
// it will also be streamed via websockets to the user.
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
func (p *Processor) timelineStatusForAccount(ctx context.Context, account *gtsmodel.Account, status *gtsmodel.Status) error {
|
2021-06-17 18:02:33 +02:00
|
|
|
// make sure the status is timelineable
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
if timelineable, err := p.filter.StatusHomeTimelineable(ctx, account, status); err != nil {
|
|
|
|
return fmt.Errorf("timelineStatusForAccount: error getting timelineability for status for timeline with id %s: %w", account.ID, err)
|
2023-03-20 19:10:08 +01:00
|
|
|
} else if !timelineable {
|
|
|
|
return nil
|
2021-06-13 18:42:28 +02:00
|
|
|
}
|
|
|
|
|
2021-06-19 11:18:55 +02:00
|
|
|
// stick the status in the timeline for the account and then immediately prepare it so they can see it right away
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
if inserted, err := p.statusTimelines.IngestAndPrepare(ctx, status, account.ID); err != nil {
|
2023-03-20 19:10:08 +01:00
|
|
|
return fmt.Errorf("timelineStatusForAccount: error ingesting status %s: %w", status.ID, err)
|
|
|
|
} else if !inserted {
|
|
|
|
return nil
|
2021-06-19 11:18:55 +02:00
|
|
|
}
|
|
|
|
|
2021-11-22 19:03:21 +01:00
|
|
|
// the status was inserted so stream it to the user
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
apiStatus, err := p.tc.StatusToAPIStatus(ctx, status, account)
|
2023-03-20 19:10:08 +01:00
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("timelineStatusForAccount: error converting status %s to frontend representation: %w", status.ID, err)
|
|
|
|
}
|
2021-06-19 11:18:55 +02:00
|
|
|
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
if err := p.stream.Update(apiStatus, account, stream.TimelineHome); err != nil {
|
2023-03-20 19:10:08 +01:00
|
|
|
return fmt.Errorf("timelineStatusForAccount: error streaming update for status %s: %w", status.ID, err)
|
2021-06-13 18:42:28 +02:00
|
|
|
}
|
2023-03-20 19:10:08 +01:00
|
|
|
|
|
|
|
return nil
|
2021-06-13 18:42:28 +02:00
|
|
|
}
|
|
|
|
|
2021-11-22 19:03:21 +01:00
|
|
|
// deleteStatusFromTimelines completely removes the given status from all timelines.
|
|
|
|
// It will also stream deletion of the status to all open streams.
|
2023-02-22 16:05:26 +01:00
|
|
|
func (p *Processor) deleteStatusFromTimelines(ctx context.Context, status *gtsmodel.Status) error {
|
2022-02-05 12:47:38 +01:00
|
|
|
if err := p.statusTimelines.WipeItemFromAllTimelines(ctx, status.ID); err != nil {
|
2021-06-21 15:56:00 +02:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2023-02-22 16:05:26 +01:00
|
|
|
return p.stream.Delete(status.ID)
|
2021-06-13 18:42:28 +02:00
|
|
|
}
|
2022-05-18 23:13:03 +02:00
|
|
|
|
|
|
|
// wipeStatus contains common logic used to totally delete a status
|
|
|
|
// + all its attachments, notifications, boosts, and timeline entries.
|
2023-02-22 16:05:26 +01:00
|
|
|
func (p *Processor) wipeStatus(ctx context.Context, statusToDelete *gtsmodel.Status, deleteAttachments bool) error {
|
2022-06-24 17:17:40 +02:00
|
|
|
// either delete all attachments for this status, or simply
|
|
|
|
// unattach all attachments for this status, so they'll be
|
|
|
|
// cleaned later by a separate process; reason to unattach rather
|
|
|
|
// than delete is that the poster might want to reattach them
|
|
|
|
// to another status immediately (in case of delete + redraft)
|
|
|
|
if deleteAttachments {
|
|
|
|
for _, a := range statusToDelete.AttachmentIDs {
|
2023-02-22 16:05:26 +01:00
|
|
|
if err := p.media.Delete(ctx, a); err != nil {
|
2022-06-24 17:17:40 +02:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
for _, a := range statusToDelete.AttachmentIDs {
|
2023-02-22 16:05:26 +01:00
|
|
|
if _, err := p.media.Unattach(ctx, statusToDelete.Account, a); err != nil {
|
2022-06-24 17:17:40 +02:00
|
|
|
return err
|
|
|
|
}
|
2022-05-18 23:13:03 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-09-21 19:55:52 +02:00
|
|
|
// delete all mention entries generated by this status
|
[performance] refactoring + add fave / follow / request / visibility caching (#1607)
* refactor visibility checking, add caching for visibility
* invalidate visibility cache items on account / status deletes
* fix requester ID passed to visibility cache nil ptr
* de-interface caches, fix home / public timeline caching + visibility
* finish adding code comments for visibility filter
* fix angry goconst linter warnings
* actually finish adding filter visibility code comments for timeline functions
* move home timeline status author check to after visibility
* remove now-unused code
* add more code comments
* add TODO code comment, update printed cache start names
* update printed cache names on stop
* start adding separate follow(request) delete db functions, add specific visibility cache tests
* add relationship type caching
* fix getting local account follows / followed-bys, other small codebase improvements
* simplify invalidation using cache hooks, add more GetAccountBy___() functions
* fix boosting to return 404 if not boostable but no error (to not leak status ID)
* remove dead code
* improved placement of cache invalidation
* update license headers
* add example follow, follow-request config entries
* add example visibility cache configuration to config file
* use specific PutFollowRequest() instead of just Put()
* add tests for all GetAccountBy()
* add GetBlockBy() tests
* update block to check primitive fields
* update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests
* fix copy-pasted code
* update envparsing test
* whitespace
* fix bun struct tag
* add license header to gtscontext
* fix old license header
* improved error creation to not use fmt.Errorf() when not needed
* fix various rebase conflicts, fix account test
* remove commented-out code, fix-up mention caching
* fix mention select bun statement
* ensure mention target account populated, pass in context to customrenderer logging
* remove more uncommented code, fix typeutil test
* add statusfave database model caching
* add status fave cache configuration
* add status fave cache example config
* woops, catch missed error. nice catch linter!
* add back testrig panic on nil db
* update example configuration to match defaults, slight tweak to cache configuration defaults
* update envparsing test with new defaults
* fetch followingget to use the follow target account
* use accounnt.IsLocal() instead of empty domain check
* use constants for the cache visibility type check
* use bun.In() for notification type restriction in db query
* include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable())
* use bun query building for nested select statements to ensure working with postgres
* update public timeline future status checks to match visibility filter
* same as previous, for home timeline
* update public timeline tests to dynamically check for appropriate statuses
* migrate accounts to allow unique constraint on public_key
* provide minimal account with publicKey
---------
Signed-off-by: kim <grufwub@gmail.com>
Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
2023-03-28 15:03:14 +02:00
|
|
|
for _, id := range statusToDelete.MentionIDs {
|
|
|
|
if err := p.state.DB.DeleteMentionByID(ctx, id); err != nil {
|
2022-05-18 23:13:03 +02:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-09-21 19:55:52 +02:00
|
|
|
// delete all notification entries generated by this status
|
2023-03-20 19:10:08 +01:00
|
|
|
if err := p.state.DB.DeleteNotificationsForStatus(ctx, statusToDelete.ID); err != nil {
|
2022-05-18 23:13:03 +02:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2023-02-23 23:11:10 +01:00
|
|
|
// delete all bookmarks that point to this status
|
2023-03-20 19:10:08 +01:00
|
|
|
if err := p.state.DB.DeleteStatusBookmarksForStatus(ctx, statusToDelete.ID); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
// delete all faves of this status
|
|
|
|
if err := p.state.DB.DeleteStatusFavesForStatus(ctx, statusToDelete.ID); err != nil {
|
2023-02-23 23:11:10 +01:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2022-05-18 23:13:03 +02:00
|
|
|
// delete all boosts for this status + remove them from timelines
|
2023-03-01 19:26:53 +01:00
|
|
|
if boosts, err := p.state.DB.GetStatusReblogs(ctx, statusToDelete); err == nil {
|
2022-09-21 19:55:52 +02:00
|
|
|
for _, b := range boosts {
|
|
|
|
if err := p.deleteStatusFromTimelines(ctx, b); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
2023-03-01 19:26:53 +01:00
|
|
|
if err := p.state.DB.DeleteStatusByID(ctx, b.ID); err != nil {
|
2022-09-21 19:55:52 +02:00
|
|
|
return err
|
|
|
|
}
|
2022-05-18 23:13:03 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// delete this status from any and all timelines
|
|
|
|
if err := p.deleteStatusFromTimelines(ctx, statusToDelete); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2022-09-21 19:55:52 +02:00
|
|
|
// delete the status itself
|
2023-03-01 19:26:53 +01:00
|
|
|
if err := p.state.DB.DeleteStatusByID(ctx, statusToDelete.ID); err != nil {
|
2022-09-21 19:55:52 +02:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2022-05-18 23:13:03 +02:00
|
|
|
return nil
|
|
|
|
}
|