mirrors
/
gotosocial
mirror of
1
Fork 0
Code Issues Releases Activity

[chore/bugfix] Demote failed inbox forwarding to warn log rather than error return (#1892)

This commit is contained in:
tobi 2023-06-14 15:08:31 +02:00 committed by GitHub
parent 24fbdf2b0a
commit 827cc4df56
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/federation/federatingactor.go
View File

@ -231,8 +231,9 @@ func (f *federatingActor) PostInboxScheme(ctx context.Context, w http.ResponseWr
// is updated, and/or federating callbacks are handled
// properly.
if !errors.Is(err, db.ErrAlreadyExists) {
err = fmt.Errorf("PostInboxScheme: error calling sideEffectActor.InboxForwarding: %w", err)
return false, gtserror.NewErrorInternalError(err)
// Failed inbox forwarding is not a show-stopper,
// and doesn't even necessarily denote a real error.
l.Warnf("error calling sideEffectActor.InboxForwarding: %q", err)
}
}