[feature] Allow editing domain blocks/allows, fix comment import (#3967)
* start implementing editing of existing domain permissions * [feature] Allow editing domain blocks/allows, fix comment import * [bugfix] Use "comment" via /api/v1/instance * fix the stuff
This commit is contained in:
parent
db4b857159
commit
b184432331
|
@ -113,6 +113,27 @@ nothanks.com,suspend,false,false,,false
|
|||
|
||||
JSON lists use content type `application/json`.
|
||||
|
||||
```json
|
||||
[
|
||||
{
|
||||
"domain": "bumfaces.net",
|
||||
"suspended_at": "2020-05-13T13:29:12.000Z",
|
||||
"comment": "big jerks"
|
||||
},
|
||||
{
|
||||
"domain": "peepee.poopoo",
|
||||
"suspended_at": "2020-05-13T13:29:12.000Z",
|
||||
"comment": "harassment"
|
||||
},
|
||||
{
|
||||
"domain": "nothanks.com",
|
||||
"suspended_at": "2020-05-13T13:29:12.000Z"
|
||||
}
|
||||
]
|
||||
```
|
||||
|
||||
As an alternative to `"comment"`, `"public_comment"` will also work:
|
||||
|
||||
```json
|
||||
[
|
||||
{
|
||||
|
|
|
@ -1099,13 +1099,22 @@ definitions:
|
|||
domain:
|
||||
description: Domain represents a remote domain
|
||||
properties:
|
||||
comment:
|
||||
description: |-
|
||||
If the domain is blocked, what's the publicly-stated reason for the block.
|
||||
Alternative to `public_comment` to be used when serializing/deserializing via /api/v1/instance.
|
||||
example: they smell
|
||||
type: string
|
||||
x-go-name: Comment
|
||||
domain:
|
||||
description: The hostname of the domain.
|
||||
example: example.org
|
||||
type: string
|
||||
x-go-name: Domain
|
||||
public_comment:
|
||||
description: If the domain is blocked, what's the publicly-stated reason for the block.
|
||||
description: |-
|
||||
If the domain is blocked, what's the publicly-stated reason for the block.
|
||||
Alternative to `comment` to be used when serializing/deserializing NOT via /api/v1/instance.
|
||||
example: they smell
|
||||
type: string
|
||||
x-go-name: PublicComment
|
||||
|
@ -1124,6 +1133,13 @@ definitions:
|
|||
x-go-package: github.com/superseriousbusiness/gotosocial/internal/api/model
|
||||
domainPermission:
|
||||
properties:
|
||||
comment:
|
||||
description: |-
|
||||
If the domain is blocked, what's the publicly-stated reason for the block.
|
||||
Alternative to `public_comment` to be used when serializing/deserializing via /api/v1/instance.
|
||||
example: they smell
|
||||
type: string
|
||||
x-go-name: Comment
|
||||
created_at:
|
||||
description: Time at which the permission entry was created (ISO 8601 Datetime).
|
||||
example: "2021-07-30T09:20:25+00:00"
|
||||
|
@ -1162,7 +1178,9 @@ definitions:
|
|||
type: string
|
||||
x-go-name: PrivateComment
|
||||
public_comment:
|
||||
description: If the domain is blocked, what's the publicly-stated reason for the block.
|
||||
description: |-
|
||||
If the domain is blocked, what's the publicly-stated reason for the block.
|
||||
Alternative to `comment` to be used when serializing/deserializing NOT via /api/v1/instance.
|
||||
example: they smell
|
||||
type: string
|
||||
x-go-name: PublicComment
|
||||
|
@ -5823,6 +5841,53 @@ paths:
|
|||
summary: View domain allow with the given ID.
|
||||
tags:
|
||||
- admin
|
||||
put:
|
||||
consumes:
|
||||
- multipart/form-data
|
||||
operationId: domainAllowUpdate
|
||||
parameters:
|
||||
- description: The id of the domain allow.
|
||||
in: path
|
||||
name: id
|
||||
required: true
|
||||
type: string
|
||||
- description: Obfuscate the name of the domain when serving it publicly. Eg., `example.org` becomes something like `ex***e.org`.
|
||||
in: formData
|
||||
name: obfuscate
|
||||
type: boolean
|
||||
- description: Public comment about this domain allow. This will be displayed alongside the domain allow if you choose to share allows.
|
||||
in: formData
|
||||
name: public_comment
|
||||
type: string
|
||||
- description: Private comment about this domain allow. Will only be shown to other admins, so this is a useful way of internally keeping track of why a certain domain ended up allowed.
|
||||
in: formData
|
||||
name: private_comment
|
||||
type: string
|
||||
produces:
|
||||
- application/json
|
||||
responses:
|
||||
"200":
|
||||
description: The updated domain allow.
|
||||
schema:
|
||||
$ref: '#/definitions/domainPermission'
|
||||
"400":
|
||||
description: bad request
|
||||
"401":
|
||||
description: unauthorized
|
||||
"403":
|
||||
description: forbidden
|
||||
"404":
|
||||
description: not found
|
||||
"406":
|
||||
description: not acceptable
|
||||
"500":
|
||||
description: internal server error
|
||||
security:
|
||||
- OAuth2 Bearer:
|
||||
- admin:write:domain_allows
|
||||
summary: Update a single domain allow.
|
||||
tags:
|
||||
- admin
|
||||
/api/v1/admin/domain_blocks:
|
||||
get:
|
||||
operationId: domainBlocksGet
|
||||
|
@ -5990,6 +6055,53 @@ paths:
|
|||
summary: View domain block with the given ID.
|
||||
tags:
|
||||
- admin
|
||||
put:
|
||||
consumes:
|
||||
- multipart/form-data
|
||||
operationId: domainBlockUpdate
|
||||
parameters:
|
||||
- description: The id of the domain block.
|
||||
in: path
|
||||
name: id
|
||||
required: true
|
||||
type: string
|
||||
- description: Obfuscate the name of the domain when serving it publicly. Eg., `example.org` becomes something like `ex***e.org`.
|
||||
in: formData
|
||||
name: obfuscate
|
||||
type: boolean
|
||||
- description: Public comment about this domain block. This will be displayed alongside the domain block if you choose to share blocks.
|
||||
in: formData
|
||||
name: public_comment
|
||||
type: string
|
||||
- description: Private comment about this domain block. Will only be shown to other admins, so this is a useful way of internally keeping track of why a certain domain ended up blocked.
|
||||
in: formData
|
||||
name: private_comment
|
||||
type: string
|
||||
produces:
|
||||
- application/json
|
||||
responses:
|
||||
"200":
|
||||
description: The updated domain block.
|
||||
schema:
|
||||
$ref: '#/definitions/domainPermission'
|
||||
"400":
|
||||
description: bad request
|
||||
"401":
|
||||
description: unauthorized
|
||||
"403":
|
||||
description: forbidden
|
||||
"404":
|
||||
description: not found
|
||||
"406":
|
||||
description: not acceptable
|
||||
"500":
|
||||
description: internal server error
|
||||
security:
|
||||
- OAuth2 Bearer:
|
||||
- admin:write:domain_blocks
|
||||
summary: Update a single domain block.
|
||||
tags:
|
||||
- admin
|
||||
/api/v1/admin/domain_keys_expire:
|
||||
post:
|
||||
consumes:
|
||||
|
|
|
@ -102,12 +102,14 @@ func (m *Module) Route(attachHandler func(method string, path string, f ...gin.H
|
|||
attachHandler(http.MethodPost, DomainBlocksPath, m.DomainBlocksPOSTHandler)
|
||||
attachHandler(http.MethodGet, DomainBlocksPath, m.DomainBlocksGETHandler)
|
||||
attachHandler(http.MethodGet, DomainBlocksPathWithID, m.DomainBlockGETHandler)
|
||||
attachHandler(http.MethodPut, DomainBlocksPathWithID, m.DomainBlockUpdatePUTHandler)
|
||||
attachHandler(http.MethodDelete, DomainBlocksPathWithID, m.DomainBlockDELETEHandler)
|
||||
|
||||
// domain allow stuff
|
||||
attachHandler(http.MethodPost, DomainAllowsPath, m.DomainAllowsPOSTHandler)
|
||||
attachHandler(http.MethodGet, DomainAllowsPath, m.DomainAllowsGETHandler)
|
||||
attachHandler(http.MethodGet, DomainAllowsPathWithID, m.DomainAllowGETHandler)
|
||||
attachHandler(http.MethodPut, DomainAllowsPathWithID, m.DomainAllowUpdatePUTHandler)
|
||||
attachHandler(http.MethodDelete, DomainAllowsPathWithID, m.DomainAllowDELETEHandler)
|
||||
|
||||
// domain permission draft stuff
|
||||
|
|
|
@ -0,0 +1,91 @@
|
|||
// GoToSocial
|
||||
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
||||
// SPDX-License-Identifier: AGPL-3.0-or-later
|
||||
//
|
||||
// This program is free software: you can redistribute it and/or modify
|
||||
// it under the terms of the GNU Affero General Public License as published by
|
||||
// the Free Software Foundation, either version 3 of the License, or
|
||||
// (at your option) any later version.
|
||||
//
|
||||
// This program is distributed in the hope that it will be useful,
|
||||
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
// GNU Affero General Public License for more details.
|
||||
//
|
||||
// You should have received a copy of the GNU Affero General Public License
|
||||
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
|
||||
package admin
|
||||
|
||||
import (
|
||||
"github.com/gin-gonic/gin"
|
||||
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
|
||||
)
|
||||
|
||||
// DomainAllowUpdatePUTHandler swagger:operation PUT /api/v1/admin/domain_allows/{id} domainAllowUpdate
|
||||
//
|
||||
// Update a single domain allow.
|
||||
//
|
||||
// ---
|
||||
// tags:
|
||||
// - admin
|
||||
//
|
||||
// consumes:
|
||||
// - multipart/form-data
|
||||
//
|
||||
// produces:
|
||||
// - application/json
|
||||
//
|
||||
// parameters:
|
||||
// -
|
||||
// name: id
|
||||
// type: string
|
||||
// description: The id of the domain allow.
|
||||
// in: path
|
||||
// required: true
|
||||
// -
|
||||
// name: obfuscate
|
||||
// in: formData
|
||||
// description: >-
|
||||
// Obfuscate the name of the domain when serving it publicly.
|
||||
// Eg., `example.org` becomes something like `ex***e.org`.
|
||||
// type: boolean
|
||||
// -
|
||||
// name: public_comment
|
||||
// in: formData
|
||||
// description: >-
|
||||
// Public comment about this domain allow.
|
||||
// This will be displayed alongside the domain allow if you choose to share allows.
|
||||
// type: string
|
||||
// -
|
||||
// name: private_comment
|
||||
// in: formData
|
||||
// description: >-
|
||||
// Private comment about this domain allow. Will only be shown to other admins, so this
|
||||
// is a useful way of internally keeping track of why a certain domain ended up allowed.
|
||||
// type: string
|
||||
//
|
||||
// security:
|
||||
// - OAuth2 Bearer:
|
||||
// - admin:write:domain_allows
|
||||
//
|
||||
// responses:
|
||||
// '200':
|
||||
// description: The updated domain allow.
|
||||
// schema:
|
||||
// "$ref": "#/definitions/domainPermission"
|
||||
// '400':
|
||||
// description: bad request
|
||||
// '401':
|
||||
// description: unauthorized
|
||||
// '403':
|
||||
// description: forbidden
|
||||
// '404':
|
||||
// description: not found
|
||||
// '406':
|
||||
// description: not acceptable
|
||||
// '500':
|
||||
// description: internal server error
|
||||
func (m *Module) DomainAllowUpdatePUTHandler(c *gin.Context) {
|
||||
m.updateDomainPermission(c, gtsmodel.DomainPermissionAllow)
|
||||
}
|
|
@ -0,0 +1,91 @@
|
|||
// GoToSocial
|
||||
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
||||
// SPDX-License-Identifier: AGPL-3.0-or-later
|
||||
//
|
||||
// This program is free software: you can redistribute it and/or modify
|
||||
// it under the terms of the GNU Affero General Public License as published by
|
||||
// the Free Software Foundation, either version 3 of the License, or
|
||||
// (at your option) any later version.
|
||||
//
|
||||
// This program is distributed in the hope that it will be useful,
|
||||
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
// GNU Affero General Public License for more details.
|
||||
//
|
||||
// You should have received a copy of the GNU Affero General Public License
|
||||
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
|
||||
package admin
|
||||
|
||||
import (
|
||||
"github.com/gin-gonic/gin"
|
||||
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
|
||||
)
|
||||
|
||||
// DomainBlockUpdatePUTHandler swagger:operation PUT /api/v1/admin/domain_blocks/{id} domainBlockUpdate
|
||||
//
|
||||
// Update a single domain block.
|
||||
//
|
||||
// ---
|
||||
// tags:
|
||||
// - admin
|
||||
//
|
||||
// consumes:
|
||||
// - multipart/form-data
|
||||
//
|
||||
// produces:
|
||||
// - application/json
|
||||
//
|
||||
// parameters:
|
||||
// -
|
||||
// name: id
|
||||
// type: string
|
||||
// description: The id of the domain block.
|
||||
// in: path
|
||||
// required: true
|
||||
// -
|
||||
// name: obfuscate
|
||||
// in: formData
|
||||
// description: >-
|
||||
// Obfuscate the name of the domain when serving it publicly.
|
||||
// Eg., `example.org` becomes something like `ex***e.org`.
|
||||
// type: boolean
|
||||
// -
|
||||
// name: public_comment
|
||||
// in: formData
|
||||
// description: >-
|
||||
// Public comment about this domain block.
|
||||
// This will be displayed alongside the domain block if you choose to share blocks.
|
||||
// type: string
|
||||
// -
|
||||
// name: private_comment
|
||||
// in: formData
|
||||
// description: >-
|
||||
// Private comment about this domain block. Will only be shown to other admins, so this
|
||||
// is a useful way of internally keeping track of why a certain domain ended up blocked.
|
||||
// type: string
|
||||
//
|
||||
// security:
|
||||
// - OAuth2 Bearer:
|
||||
// - admin:write:domain_blocks
|
||||
//
|
||||
// responses:
|
||||
// '200':
|
||||
// description: The updated domain block.
|
||||
// schema:
|
||||
// "$ref": "#/definitions/domainPermission"
|
||||
// '400':
|
||||
// description: bad request
|
||||
// '401':
|
||||
// description: unauthorized
|
||||
// '403':
|
||||
// description: forbidden
|
||||
// '404':
|
||||
// description: not found
|
||||
// '406':
|
||||
// description: not acceptable
|
||||
// '500':
|
||||
// description: internal server error
|
||||
func (m *Module) DomainBlockUpdatePUTHandler(c *gin.Context) {
|
||||
m.updateDomainPermission(c, gtsmodel.DomainPermissionBlock)
|
||||
}
|
|
@ -29,6 +29,7 @@ import (
|
|||
apiutil "github.com/superseriousbusiness/gotosocial/internal/api/util"
|
||||
"github.com/superseriousbusiness/gotosocial/internal/gtserror"
|
||||
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
|
||||
"github.com/superseriousbusiness/gotosocial/internal/util"
|
||||
)
|
||||
|
||||
type singleDomainPermCreate func(
|
||||
|
@ -112,7 +113,7 @@ func (m *Module) createDomainPermissions(
|
|||
if importing && form.Domains.Size == 0 {
|
||||
err = errors.New("import was specified but list of domains is empty")
|
||||
} else if !importing && form.Domain == "" {
|
||||
err = errors.New("empty domain provided")
|
||||
err = errors.New("no domain provided")
|
||||
}
|
||||
|
||||
if err != nil {
|
||||
|
@ -122,14 +123,14 @@ func (m *Module) createDomainPermissions(
|
|||
|
||||
if !importing {
|
||||
// Single domain permission creation.
|
||||
domainBlock, _, errWithCode := single(
|
||||
perm, _, errWithCode := single(
|
||||
c.Request.Context(),
|
||||
permType,
|
||||
authed.Account,
|
||||
form.Domain,
|
||||
form.Obfuscate,
|
||||
form.PublicComment,
|
||||
form.PrivateComment,
|
||||
util.PtrOrZero(form.Obfuscate),
|
||||
util.PtrOrZero(form.PublicComment),
|
||||
util.PtrOrZero(form.PrivateComment),
|
||||
"", // No sub ID for single perm creation.
|
||||
)
|
||||
|
||||
|
@ -138,7 +139,7 @@ func (m *Module) createDomainPermissions(
|
|||
return
|
||||
}
|
||||
|
||||
apiutil.JSON(c, http.StatusOK, domainBlock)
|
||||
apiutil.JSON(c, http.StatusOK, perm)
|
||||
return
|
||||
}
|
||||
|
||||
|
@ -177,6 +178,82 @@ func (m *Module) createDomainPermissions(
|
|||
apiutil.JSON(c, http.StatusOK, domainPerms)
|
||||
}
|
||||
|
||||
func (m *Module) updateDomainPermission(
|
||||
c *gin.Context,
|
||||
permType gtsmodel.DomainPermissionType,
|
||||
) {
|
||||
// Scope differs based on permType.
|
||||
var requireScope apiutil.Scope
|
||||
if permType == gtsmodel.DomainPermissionBlock {
|
||||
requireScope = apiutil.ScopeAdminWriteDomainBlocks
|
||||
} else {
|
||||
requireScope = apiutil.ScopeAdminWriteDomainAllows
|
||||
}
|
||||
|
||||
authed, errWithCode := apiutil.TokenAuth(c,
|
||||
true, true, true, true,
|
||||
requireScope,
|
||||
)
|
||||
if errWithCode != nil {
|
||||
apiutil.ErrorHandler(c, errWithCode, m.processor.InstanceGetV1)
|
||||
return
|
||||
}
|
||||
|
||||
if !*authed.User.Admin {
|
||||
err := fmt.Errorf("user %s not an admin", authed.User.ID)
|
||||
apiutil.ErrorHandler(c, gtserror.NewErrorForbidden(err, err.Error()), m.processor.InstanceGetV1)
|
||||
return
|
||||
}
|
||||
|
||||
if authed.Account.IsMoving() {
|
||||
apiutil.ForbiddenAfterMove(c)
|
||||
return
|
||||
}
|
||||
|
||||
if _, err := apiutil.NegotiateAccept(c, apiutil.JSONAcceptHeaders...); err != nil {
|
||||
apiutil.ErrorHandler(c, gtserror.NewErrorNotAcceptable(err, err.Error()), m.processor.InstanceGetV1)
|
||||
return
|
||||
}
|
||||
|
||||
permID, errWithCode := apiutil.ParseID(c.Param(apiutil.IDKey))
|
||||
if errWithCode != nil {
|
||||
apiutil.ErrorHandler(c, errWithCode, m.processor.InstanceGetV1)
|
||||
return
|
||||
}
|
||||
|
||||
// Parse + validate form.
|
||||
form := new(apimodel.DomainPermissionRequest)
|
||||
if err := c.ShouldBind(form); err != nil {
|
||||
apiutil.ErrorHandler(c, gtserror.NewErrorBadRequest(err, err.Error()), m.processor.InstanceGetV1)
|
||||
return
|
||||
}
|
||||
|
||||
if form.Obfuscate == nil &&
|
||||
form.PrivateComment == nil &&
|
||||
form.PublicComment == nil {
|
||||
const errText = "empty form submitted"
|
||||
errWithCode := gtserror.NewErrorBadRequest(errors.New(errText), errText)
|
||||
apiutil.ErrorHandler(c, errWithCode, m.processor.InstanceGetV1)
|
||||
return
|
||||
}
|
||||
|
||||
perm, errWithCode := m.processor.Admin().DomainPermissionUpdate(
|
||||
c.Request.Context(),
|
||||
permType,
|
||||
permID,
|
||||
form.Obfuscate,
|
||||
form.PublicComment,
|
||||
form.PrivateComment,
|
||||
nil, // Can't update perm sub ID this way yet.
|
||||
)
|
||||
if errWithCode != nil {
|
||||
apiutil.ErrorHandler(c, errWithCode, m.processor.InstanceGetV1)
|
||||
return
|
||||
}
|
||||
|
||||
apiutil.JSON(c, http.StatusOK, perm)
|
||||
}
|
||||
|
||||
// deleteDomainPermission deletes a single domain permission (block or allow).
|
||||
func (m *Module) deleteDomainPermission(
|
||||
c *gin.Context,
|
||||
|
|
|
@ -26,6 +26,7 @@ import (
|
|||
apimodel "github.com/superseriousbusiness/gotosocial/internal/api/model"
|
||||
apiutil "github.com/superseriousbusiness/gotosocial/internal/api/util"
|
||||
"github.com/superseriousbusiness/gotosocial/internal/gtserror"
|
||||
"github.com/superseriousbusiness/gotosocial/internal/util"
|
||||
)
|
||||
|
||||
// DomainPermissionDraftsPOSTHandler swagger:operation POST /api/v1/admin/domain_permission_drafts domainPermissionDraftCreate
|
||||
|
@ -148,9 +149,9 @@ func (m *Module) DomainPermissionDraftsPOSTHandler(c *gin.Context) {
|
|||
authed.Account,
|
||||
form.Domain,
|
||||
permType,
|
||||
form.Obfuscate,
|
||||
form.PublicComment,
|
||||
form.PrivateComment,
|
||||
util.PtrOrZero(form.Obfuscate),
|
||||
util.PtrOrZero(form.PublicComment),
|
||||
util.PtrOrZero(form.PrivateComment),
|
||||
)
|
||||
if errWithCode != nil {
|
||||
apiutil.ErrorHandler(c, errWithCode, m.processor.InstanceGetV1)
|
||||
|
|
|
@ -97,14 +97,21 @@ func (suite *DomainPermissionSubscriptionTestTestSuite) TestDomainPermissionSubs
|
|||
suite.Equal(`[
|
||||
{
|
||||
"domain": "bumfaces.net",
|
||||
"public_comment": "big jerks"
|
||||
"public_comment": "big jerks",
|
||||
"obfuscate": false,
|
||||
"private_comment": ""
|
||||
},
|
||||
{
|
||||
"domain": "peepee.poopoo",
|
||||
"public_comment": "harassment"
|
||||
"public_comment": "harassment",
|
||||
"obfuscate": false,
|
||||
"private_comment": ""
|
||||
},
|
||||
{
|
||||
"domain": "nothanks.com"
|
||||
"domain": "nothanks.com",
|
||||
"public_comment": "",
|
||||
"obfuscate": false,
|
||||
"private_comment": ""
|
||||
}
|
||||
]`, dst.String())
|
||||
|
||||
|
@ -177,13 +184,22 @@ func (suite *DomainPermissionSubscriptionTestTestSuite) TestDomainPermissionSubs
|
|||
// Ensure expected.
|
||||
suite.Equal(`[
|
||||
{
|
||||
"domain": "bumfaces.net"
|
||||
"domain": "bumfaces.net",
|
||||
"public_comment": "",
|
||||
"obfuscate": false,
|
||||
"private_comment": ""
|
||||
},
|
||||
{
|
||||
"domain": "peepee.poopoo"
|
||||
"domain": "peepee.poopoo",
|
||||
"public_comment": "",
|
||||
"obfuscate": false,
|
||||
"private_comment": ""
|
||||
},
|
||||
{
|
||||
"domain": "nothanks.com"
|
||||
"domain": "nothanks.com",
|
||||
"public_comment": "",
|
||||
"obfuscate": false,
|
||||
"private_comment": ""
|
||||
}
|
||||
]`, dst.String())
|
||||
|
||||
|
|
|
@ -136,7 +136,7 @@ func (suite *InstancePeersGetTestSuite) TestInstancePeersGetOnlySuspended() {
|
|||
{
|
||||
"domain": "replyguys.com",
|
||||
"suspended_at": "2020-05-13T13:29:12.000Z",
|
||||
"public_comment": "reply-guying to tech posts"
|
||||
"comment": "reply-guying to tech posts"
|
||||
}
|
||||
]`, dst.String())
|
||||
}
|
||||
|
@ -186,7 +186,7 @@ func (suite *InstancePeersGetTestSuite) TestInstancePeersGetOnlySuspendedAuthori
|
|||
{
|
||||
"domain": "replyguys.com",
|
||||
"suspended_at": "2020-05-13T13:29:12.000Z",
|
||||
"public_comment": "reply-guying to tech posts"
|
||||
"comment": "reply-guying to tech posts"
|
||||
}
|
||||
]`, dst.String())
|
||||
}
|
||||
|
@ -219,7 +219,7 @@ func (suite *InstancePeersGetTestSuite) TestInstancePeersGetAll() {
|
|||
{
|
||||
"domain": "replyguys.com",
|
||||
"suspended_at": "2020-05-13T13:29:12.000Z",
|
||||
"public_comment": "reply-guying to tech posts"
|
||||
"comment": "reply-guying to tech posts"
|
||||
}
|
||||
]`, dst.String())
|
||||
}
|
||||
|
@ -263,12 +263,12 @@ func (suite *InstancePeersGetTestSuite) TestInstancePeersGetAllWithObfuscated()
|
|||
{
|
||||
"domain": "o*g.*u**.t**.*or*t.*r**ev**",
|
||||
"suspended_at": "2021-06-09T10:34:55.000Z",
|
||||
"public_comment": "just absolutely the worst, wowza"
|
||||
"comment": "just absolutely the worst, wowza"
|
||||
},
|
||||
{
|
||||
"domain": "replyguys.com",
|
||||
"suspended_at": "2020-05-13T13:29:12.000Z",
|
||||
"public_comment": "reply-guying to tech posts"
|
||||
"comment": "reply-guying to tech posts"
|
||||
}
|
||||
]`, dst.String())
|
||||
}
|
||||
|
|
|
@ -33,8 +33,13 @@ type Domain struct {
|
|||
// example: 2021-07-30T09:20:25+00:00
|
||||
SilencedAt string `json:"silenced_at,omitempty"`
|
||||
// If the domain is blocked, what's the publicly-stated reason for the block.
|
||||
// Alternative to `public_comment` to be used when serializing/deserializing via /api/v1/instance.
|
||||
// example: they smell
|
||||
PublicComment string `form:"public_comment" json:"public_comment,omitempty"`
|
||||
Comment *string `form:"comment" json:"comment,omitempty"`
|
||||
// If the domain is blocked, what's the publicly-stated reason for the block.
|
||||
// Alternative to `comment` to be used when serializing/deserializing NOT via /api/v1/instance.
|
||||
// example: they smell
|
||||
PublicComment *string `form:"public_comment" json:"public_comment,omitempty"`
|
||||
}
|
||||
|
||||
// DomainPermission represents a permission applied to one domain (explicit block/allow).
|
||||
|
@ -48,10 +53,10 @@ type DomainPermission struct {
|
|||
ID string `json:"id,omitempty"`
|
||||
// Obfuscate the domain name when serving this domain permission entry publicly.
|
||||
// example: false
|
||||
Obfuscate bool `json:"obfuscate,omitempty"`
|
||||
Obfuscate *bool `json:"obfuscate,omitempty"`
|
||||
// Private comment for this permission entry, visible to this instance's admins only.
|
||||
// example: they are poopoo
|
||||
PrivateComment string `json:"private_comment,omitempty"`
|
||||
PrivateComment *string `json:"private_comment,omitempty"`
|
||||
// If applicable, the ID of the subscription that caused this domain permission entry to be created.
|
||||
// example: 01FBW25TF5J67JW3HFHZCSD23K
|
||||
SubscriptionID string `json:"subscription_id,omitempty"`
|
||||
|
@ -80,14 +85,14 @@ type DomainPermissionRequest struct {
|
|||
// Obfuscate the domain name when displaying this permission entry publicly.
|
||||
// Ie., instead of 'example.org' show something like 'e**mpl*.or*'.
|
||||
// example: false
|
||||
Obfuscate bool `form:"obfuscate" json:"obfuscate"`
|
||||
Obfuscate *bool `form:"obfuscate" json:"obfuscate"`
|
||||
// Private comment for other admins on why this permission entry was created.
|
||||
// example: don't like 'em!!!!
|
||||
PrivateComment string `form:"private_comment" json:"private_comment"`
|
||||
PrivateComment *string `form:"private_comment" json:"private_comment"`
|
||||
// Public comment on why this permission entry was created.
|
||||
// Will be visible to requesters at /api/v1/instance/peers if this endpoint is exposed.
|
||||
// example: foss dorks 😫
|
||||
PublicComment string `form:"public_comment" json:"public_comment"`
|
||||
PublicComment *string `form:"public_comment" json:"public_comment"`
|
||||
// Permission type to create (only applies to domain permission drafts, not explicit blocks and allows).
|
||||
PermissionType string `form:"permission_type" json:"permission_type"`
|
||||
}
|
||||
|
|
|
@ -36,7 +36,7 @@ type domainDB struct {
|
|||
state *state.State
|
||||
}
|
||||
|
||||
func (d *domainDB) CreateDomainAllow(ctx context.Context, allow *gtsmodel.DomainAllow) (err error) {
|
||||
func (d *domainDB) PutDomainAllow(ctx context.Context, allow *gtsmodel.DomainAllow) (err error) {
|
||||
// Normalize the domain as punycode, note the extra
|
||||
// validation step for domain name write operations.
|
||||
allow.Domain, err = util.PunifySafely(allow.Domain)
|
||||
|
@ -162,7 +162,7 @@ func (d *domainDB) DeleteDomainAllow(ctx context.Context, domain string) error {
|
|||
return nil
|
||||
}
|
||||
|
||||
func (d *domainDB) CreateDomainBlock(ctx context.Context, block *gtsmodel.DomainBlock) error {
|
||||
func (d *domainDB) PutDomainBlock(ctx context.Context, block *gtsmodel.DomainBlock) error {
|
||||
var err error
|
||||
|
||||
// Normalize the domain as punycode, note the extra
|
||||
|
|
|
@ -46,7 +46,7 @@ func (suite *DomainTestSuite) TestIsDomainBlocked() {
|
|||
suite.NoError(err)
|
||||
suite.False(blocked)
|
||||
|
||||
err = suite.db.CreateDomainBlock(ctx, domainBlock)
|
||||
err = suite.db.PutDomainBlock(ctx, domainBlock)
|
||||
suite.NoError(err)
|
||||
|
||||
// domain block now exists
|
||||
|
@ -75,7 +75,7 @@ func (suite *DomainTestSuite) TestIsDomainBlockedWithAllow() {
|
|||
suite.False(blocked)
|
||||
|
||||
// Block this domain.
|
||||
if err := suite.db.CreateDomainBlock(ctx, domainBlock); err != nil {
|
||||
if err := suite.db.PutDomainBlock(ctx, domainBlock); err != nil {
|
||||
suite.FailNow(err.Error())
|
||||
}
|
||||
|
||||
|
@ -96,7 +96,7 @@ func (suite *DomainTestSuite) TestIsDomainBlockedWithAllow() {
|
|||
CreatedByAccount: suite.testAccounts["admin_account"],
|
||||
}
|
||||
|
||||
if err := suite.db.CreateDomainAllow(ctx, domainAllow); err != nil {
|
||||
if err := suite.db.PutDomainAllow(ctx, domainAllow); err != nil {
|
||||
suite.FailNow(err.Error())
|
||||
}
|
||||
|
||||
|
@ -124,7 +124,7 @@ func (suite *DomainTestSuite) TestIsDomainBlockedWildcard() {
|
|||
suite.NoError(err)
|
||||
suite.False(blocked)
|
||||
|
||||
err = suite.db.CreateDomainBlock(ctx, domainBlock)
|
||||
err = suite.db.PutDomainBlock(ctx, domainBlock)
|
||||
suite.NoError(err)
|
||||
|
||||
// Start with the base block domain
|
||||
|
@ -164,7 +164,7 @@ func (suite *DomainTestSuite) TestIsDomainBlockedNonASCII() {
|
|||
suite.NoError(err)
|
||||
suite.False(blocked)
|
||||
|
||||
err = suite.db.CreateDomainBlock(ctx, domainBlock)
|
||||
err = suite.db.PutDomainBlock(ctx, domainBlock)
|
||||
suite.NoError(err)
|
||||
|
||||
// domain block now exists
|
||||
|
@ -200,7 +200,7 @@ func (suite *DomainTestSuite) TestIsDomainBlockedNonASCII2() {
|
|||
suite.NoError(err)
|
||||
suite.False(blocked)
|
||||
|
||||
err = suite.db.CreateDomainBlock(ctx, domainBlock)
|
||||
err = suite.db.PutDomainBlock(ctx, domainBlock)
|
||||
suite.NoError(err)
|
||||
|
||||
// domain block now exists
|
||||
|
@ -232,7 +232,7 @@ func (suite *DomainTestSuite) TestIsOtherDomainBlockedWildcardAndExplicit() {
|
|||
}
|
||||
|
||||
for _, block := range blocks {
|
||||
if err := suite.db.CreateDomainBlock(ctx, block); err != nil {
|
||||
if err := suite.db.PutDomainBlock(ctx, block); err != nil {
|
||||
suite.FailNow(err.Error())
|
||||
}
|
||||
}
|
||||
|
|
|
@ -80,7 +80,7 @@ func (suite *DomainPermissionSubscriptionTestSuite) TestCount() {
|
|||
|
||||
// Whack the perms in the db.
|
||||
for _, perm := range perms {
|
||||
if err := suite.state.DB.CreateDomainBlock(ctx, perm); err != nil {
|
||||
if err := suite.state.DB.PutDomainBlock(ctx, perm); err != nil {
|
||||
suite.FailNow(err.Error())
|
||||
}
|
||||
}
|
||||
|
|
|
@ -31,8 +31,8 @@ type Domain interface {
|
|||
Block/allow storage + retrieval functions.
|
||||
*/
|
||||
|
||||
// CreateDomainAllow puts the given instance-level domain allow into the database.
|
||||
CreateDomainAllow(ctx context.Context, allow *gtsmodel.DomainAllow) error
|
||||
// PutDomainAllow puts the given instance-level domain allow into the database.
|
||||
PutDomainAllow(ctx context.Context, allow *gtsmodel.DomainAllow) error
|
||||
|
||||
// GetDomainAllow returns one instance-level domain allow with the given domain, if it exists.
|
||||
GetDomainAllow(ctx context.Context, domain string) (*gtsmodel.DomainAllow, error)
|
||||
|
@ -49,8 +49,8 @@ type Domain interface {
|
|||
// DeleteDomainAllow deletes an instance-level domain allow with the given domain, if it exists.
|
||||
DeleteDomainAllow(ctx context.Context, domain string) error
|
||||
|
||||
// CreateDomainBlock puts the given instance-level domain block into the database.
|
||||
CreateDomainBlock(ctx context.Context, block *gtsmodel.DomainBlock) error
|
||||
// PutDomainBlock puts the given instance-level domain block into the database.
|
||||
PutDomainBlock(ctx context.Context, block *gtsmodel.DomainBlock) error
|
||||
|
||||
// GetDomainBlock returns one instance-level domain block with the given domain, if it exists.
|
||||
GetDomainBlock(ctx context.Context, domain string) (*gtsmodel.DomainBlock, error)
|
||||
|
|
|
@ -26,7 +26,7 @@ type DomainAllow struct {
|
|||
UpdatedAt time.Time `bun:"type:timestamptz,nullzero,notnull,default:current_timestamp"` // when was item last updated
|
||||
Domain string `bun:",nullzero,notnull"` // domain to allow. Eg. 'whatever.com'
|
||||
CreatedByAccountID string `bun:"type:CHAR(26),nullzero,notnull"` // Account ID of the creator of this allow
|
||||
CreatedByAccount *Account `bun:"rel:belongs-to"` // Account corresponding to createdByAccountID
|
||||
CreatedByAccount *Account `bun:"-"` // Account corresponding to createdByAccountID
|
||||
PrivateComment string `bun:""` // Private comment on this allow, viewable to admins
|
||||
PublicComment string `bun:""` // Public comment on this allow, viewable (optionally) by everyone
|
||||
Obfuscate *bool `bun:",nullzero,notnull,default:false"` // whether the domain name should appear obfuscated when displaying it publicly
|
||||
|
|
|
@ -26,7 +26,7 @@ type DomainBlock struct {
|
|||
UpdatedAt time.Time `bun:"type:timestamptz,nullzero,notnull,default:current_timestamp"` // when was item last updated
|
||||
Domain string `bun:",nullzero,notnull"` // domain to block. Eg. 'whatever.com'
|
||||
CreatedByAccountID string `bun:"type:CHAR(26),nullzero,notnull"` // Account ID of the creator of this block
|
||||
CreatedByAccount *Account `bun:"rel:belongs-to"` // Account corresponding to createdByAccountID
|
||||
CreatedByAccount *Account `bun:"-"` // Account corresponding to createdByAccountID
|
||||
PrivateComment string `bun:""` // Private comment on this block, viewable to admins
|
||||
PublicComment string `bun:""` // Public comment on this block, viewable (optionally) by everyone
|
||||
Obfuscate *bool `bun:",nullzero,notnull,default:false"` // whether the domain name should appear obfuscated when displaying it publicly
|
||||
|
|
|
@ -60,7 +60,7 @@ func (p *Processor) createDomainAllow(
|
|||
}
|
||||
|
||||
// Insert the new allow into the database.
|
||||
if err := p.state.DB.CreateDomainAllow(ctx, domainAllow); err != nil {
|
||||
if err := p.state.DB.PutDomainAllow(ctx, domainAllow); err != nil {
|
||||
err = gtserror.Newf("db error putting domain allow %s: %w", domain, err)
|
||||
return nil, "", gtserror.NewErrorInternalError(err)
|
||||
}
|
||||
|
@ -92,6 +92,54 @@ func (p *Processor) createDomainAllow(
|
|||
return apiDomainAllow, action.ID, nil
|
||||
}
|
||||
|
||||
func (p *Processor) updateDomainAllow(
|
||||
ctx context.Context,
|
||||
domainAllowID string,
|
||||
obfuscate *bool,
|
||||
publicComment *string,
|
||||
privateComment *string,
|
||||
subscriptionID *string,
|
||||
) (*apimodel.DomainPermission, gtserror.WithCode) {
|
||||
domainAllow, err := p.state.DB.GetDomainAllowByID(ctx, domainAllowID)
|
||||
if err != nil {
|
||||
if !errors.Is(err, db.ErrNoEntries) {
|
||||
// Real error.
|
||||
err = gtserror.Newf("db error getting domain allow: %w", err)
|
||||
return nil, gtserror.NewErrorInternalError(err)
|
||||
}
|
||||
|
||||
// There are just no entries for this ID.
|
||||
err = fmt.Errorf("no domain allow entry exists with ID %s", domainAllowID)
|
||||
return nil, gtserror.NewErrorNotFound(err, err.Error())
|
||||
}
|
||||
|
||||
var columns []string
|
||||
if obfuscate != nil {
|
||||
domainAllow.Obfuscate = obfuscate
|
||||
columns = append(columns, "obfuscate")
|
||||
}
|
||||
if publicComment != nil {
|
||||
domainAllow.PublicComment = *publicComment
|
||||
columns = append(columns, "public_comment")
|
||||
}
|
||||
if privateComment != nil {
|
||||
domainAllow.PrivateComment = *privateComment
|
||||
columns = append(columns, "private_comment")
|
||||
}
|
||||
if subscriptionID != nil {
|
||||
domainAllow.SubscriptionID = *subscriptionID
|
||||
columns = append(columns, "subscription_id")
|
||||
}
|
||||
|
||||
// Update the domain allow.
|
||||
if err := p.state.DB.UpdateDomainAllow(ctx, domainAllow, columns...); err != nil {
|
||||
err = gtserror.Newf("db error updating domain allow: %w", err)
|
||||
return nil, gtserror.NewErrorInternalError(err)
|
||||
}
|
||||
|
||||
return p.apiDomainPerm(ctx, domainAllow, false)
|
||||
}
|
||||
|
||||
func (p *Processor) deleteDomainAllow(
|
||||
ctx context.Context,
|
||||
adminAcct *gtsmodel.Account,
|
||||
|
|
|
@ -60,7 +60,7 @@ func (p *Processor) createDomainBlock(
|
|||
}
|
||||
|
||||
// Insert the new block into the database.
|
||||
if err := p.state.DB.CreateDomainBlock(ctx, domainBlock); err != nil {
|
||||
if err := p.state.DB.PutDomainBlock(ctx, domainBlock); err != nil {
|
||||
err = gtserror.Newf("db error putting domain block %s: %w", domain, err)
|
||||
return nil, "", gtserror.NewErrorInternalError(err)
|
||||
}
|
||||
|
@ -93,6 +93,54 @@ func (p *Processor) createDomainBlock(
|
|||
return apiDomainBlock, action.ID, nil
|
||||
}
|
||||
|
||||
func (p *Processor) updateDomainBlock(
|
||||
ctx context.Context,
|
||||
domainBlockID string,
|
||||
obfuscate *bool,
|
||||
publicComment *string,
|
||||
privateComment *string,
|
||||
subscriptionID *string,
|
||||
) (*apimodel.DomainPermission, gtserror.WithCode) {
|
||||
domainBlock, err := p.state.DB.GetDomainBlockByID(ctx, domainBlockID)
|
||||
if err != nil {
|
||||
if !errors.Is(err, db.ErrNoEntries) {
|
||||
// Real error.
|
||||
err = gtserror.Newf("db error getting domain block: %w", err)
|
||||
return nil, gtserror.NewErrorInternalError(err)
|
||||
}
|
||||
|
||||
// There are just no entries for this ID.
|
||||
err = fmt.Errorf("no domain block entry exists with ID %s", domainBlockID)
|
||||
return nil, gtserror.NewErrorNotFound(err, err.Error())
|
||||
}
|
||||
|
||||
var columns []string
|
||||
if obfuscate != nil {
|
||||
domainBlock.Obfuscate = obfuscate
|
||||
columns = append(columns, "obfuscate")
|
||||
}
|
||||
if publicComment != nil {
|
||||
domainBlock.PublicComment = *publicComment
|
||||
columns = append(columns, "public_comment")
|
||||
}
|
||||
if privateComment != nil {
|
||||
domainBlock.PrivateComment = *privateComment
|
||||
columns = append(columns, "private_comment")
|
||||
}
|
||||
if subscriptionID != nil {
|
||||
domainBlock.SubscriptionID = *subscriptionID
|
||||
columns = append(columns, "subscription_id")
|
||||
}
|
||||
|
||||
// Update the domain block.
|
||||
if err := p.state.DB.UpdateDomainBlock(ctx, domainBlock, columns...); err != nil {
|
||||
err = gtserror.Newf("db error updating domain block: %w", err)
|
||||
return nil, gtserror.NewErrorInternalError(err)
|
||||
}
|
||||
|
||||
return p.apiDomainPerm(ctx, domainBlock, false)
|
||||
}
|
||||
|
||||
func (p *Processor) deleteDomainBlock(
|
||||
ctx context.Context,
|
||||
adminAcct *gtsmodel.Account,
|
||||
|
|
|
@ -18,6 +18,7 @@
|
|||
package admin
|
||||
|
||||
import (
|
||||
"cmp"
|
||||
"context"
|
||||
"encoding/json"
|
||||
"errors"
|
||||
|
@ -29,6 +30,7 @@ import (
|
|||
"github.com/superseriousbusiness/gotosocial/internal/db"
|
||||
"github.com/superseriousbusiness/gotosocial/internal/gtserror"
|
||||
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
|
||||
"github.com/superseriousbusiness/gotosocial/internal/util"
|
||||
)
|
||||
|
||||
// DomainPermissionCreate creates an instance-level permission
|
||||
|
@ -84,6 +86,50 @@ func (p *Processor) DomainPermissionCreate(
|
|||
}
|
||||
}
|
||||
|
||||
// DomainPermissionUpdate updates a domain permission
|
||||
// of the given permissionType, with the given ID.
|
||||
func (p *Processor) DomainPermissionUpdate(
|
||||
ctx context.Context,
|
||||
permissionType gtsmodel.DomainPermissionType,
|
||||
permID string,
|
||||
obfuscate *bool,
|
||||
publicComment *string,
|
||||
privateComment *string,
|
||||
subscriptionID *string,
|
||||
) (*apimodel.DomainPermission, gtserror.WithCode) {
|
||||
switch permissionType {
|
||||
|
||||
// Explicitly block a domain.
|
||||
case gtsmodel.DomainPermissionBlock:
|
||||
return p.updateDomainBlock(
|
||||
ctx,
|
||||
permID,
|
||||
obfuscate,
|
||||
publicComment,
|
||||
privateComment,
|
||||
subscriptionID,
|
||||
)
|
||||
|
||||
// Explicitly allow a domain.
|
||||
case gtsmodel.DomainPermissionAllow:
|
||||
return p.updateDomainAllow(
|
||||
ctx,
|
||||
permID,
|
||||
obfuscate,
|
||||
publicComment,
|
||||
privateComment,
|
||||
subscriptionID,
|
||||
)
|
||||
|
||||
// 🎵 Why don't we all strap bombs to our chests,
|
||||
// and ride our bikes to the next G7 picnic?
|
||||
// Seems easier with every clock-tick. 🎵
|
||||
default:
|
||||
err := gtserror.Newf("unrecognized permission type %d", permissionType)
|
||||
return nil, gtserror.NewErrorInternalError(err)
|
||||
}
|
||||
}
|
||||
|
||||
// DomainPermissionDelete removes one domain block with the given ID,
|
||||
// and processes side effects of removing the block asynchronously.
|
||||
//
|
||||
|
@ -153,14 +199,14 @@ func (p *Processor) DomainPermissionsImport(
|
|||
}
|
||||
defer file.Close()
|
||||
|
||||
// Parse file as slice of domain blocks.
|
||||
domainPerms := make([]*apimodel.DomainPermission, 0)
|
||||
if err := json.NewDecoder(file).Decode(&domainPerms); err != nil {
|
||||
// Parse file as slice of domain permissions.
|
||||
apiDomainPerms := make([]*apimodel.DomainPermission, 0)
|
||||
if err := json.NewDecoder(file).Decode(&apiDomainPerms); err != nil {
|
||||
err = gtserror.Newf("error parsing attachment as domain permissions: %w", err)
|
||||
return nil, gtserror.NewErrorBadRequest(err, err.Error())
|
||||
}
|
||||
|
||||
count := len(domainPerms)
|
||||
count := len(apiDomainPerms)
|
||||
if count == 0 {
|
||||
err = gtserror.New("error importing domain permissions: 0 entries provided")
|
||||
return nil, gtserror.NewErrorBadRequest(err, err.Error())
|
||||
|
@ -170,52 +216,97 @@ func (p *Processor) DomainPermissionsImport(
|
|||
// between successes and errors so that the caller can
|
||||
// try failed imports again if desired.
|
||||
multiStatusEntries := make([]apimodel.MultiStatusEntry, 0, count)
|
||||
|
||||
for _, domainPerm := range domainPerms {
|
||||
var (
|
||||
domain = domainPerm.Domain.Domain
|
||||
obfuscate = domainPerm.Obfuscate
|
||||
publicComment = domainPerm.PublicComment
|
||||
privateComment = domainPerm.PrivateComment
|
||||
subscriptionID = "" // No sub ID for imports.
|
||||
errWithCode gtserror.WithCode
|
||||
for _, apiDomainPerm := range apiDomainPerms {
|
||||
multiStatusEntries = append(
|
||||
multiStatusEntries,
|
||||
p.importOrUpdateDomainPerm(
|
||||
ctx,
|
||||
permissionType,
|
||||
account,
|
||||
apiDomainPerm,
|
||||
),
|
||||
)
|
||||
|
||||
domainPerm, _, errWithCode = p.DomainPermissionCreate(
|
||||
ctx,
|
||||
permissionType,
|
||||
account,
|
||||
domain,
|
||||
obfuscate,
|
||||
publicComment,
|
||||
privateComment,
|
||||
subscriptionID,
|
||||
)
|
||||
|
||||
var entry *apimodel.MultiStatusEntry
|
||||
|
||||
if errWithCode != nil {
|
||||
entry = &apimodel.MultiStatusEntry{
|
||||
// Use the failed domain entry as the resource value.
|
||||
Resource: domain,
|
||||
Message: errWithCode.Safe(),
|
||||
Status: errWithCode.Code(),
|
||||
}
|
||||
} else {
|
||||
entry = &apimodel.MultiStatusEntry{
|
||||
// Use successfully created API model domain block as the resource value.
|
||||
Resource: domainPerm,
|
||||
Message: http.StatusText(http.StatusOK),
|
||||
Status: http.StatusOK,
|
||||
}
|
||||
}
|
||||
|
||||
multiStatusEntries = append(multiStatusEntries, *entry)
|
||||
}
|
||||
|
||||
return apimodel.NewMultiStatus(multiStatusEntries), nil
|
||||
}
|
||||
|
||||
func (p *Processor) importOrUpdateDomainPerm(
|
||||
ctx context.Context,
|
||||
permType gtsmodel.DomainPermissionType,
|
||||
account *gtsmodel.Account,
|
||||
apiDomainPerm *apimodel.DomainPermission,
|
||||
) apimodel.MultiStatusEntry {
|
||||
var (
|
||||
domain = apiDomainPerm.Domain.Domain
|
||||
obfuscate = apiDomainPerm.Obfuscate
|
||||
publicComment = cmp.Or(apiDomainPerm.PublicComment, apiDomainPerm.Comment)
|
||||
privateComment = apiDomainPerm.PrivateComment
|
||||
subscriptionID = "" // No sub ID for imports.
|
||||
)
|
||||
|
||||
// Check if this domain
|
||||
// perm already exists.
|
||||
var (
|
||||
domainPerm gtsmodel.DomainPermission
|
||||
err error
|
||||
)
|
||||
if permType == gtsmodel.DomainPermissionBlock {
|
||||
domainPerm, err = p.state.DB.GetDomainBlock(ctx, domain)
|
||||
} else {
|
||||
domainPerm, err = p.state.DB.GetDomainAllow(ctx, domain)
|
||||
}
|
||||
|
||||
if err != nil && !errors.Is(err, db.ErrNoEntries) {
|
||||
// Real db error.
|
||||
return apimodel.MultiStatusEntry{
|
||||
Resource: domain,
|
||||
Message: "db error checking for existence of domain permission",
|
||||
Status: http.StatusInternalServerError,
|
||||
}
|
||||
}
|
||||
|
||||
var errWithCode gtserror.WithCode
|
||||
if domainPerm != nil {
|
||||
// Permission already exists, update it.
|
||||
apiDomainPerm, errWithCode = p.DomainPermissionUpdate(
|
||||
ctx,
|
||||
permType,
|
||||
domainPerm.GetID(),
|
||||
obfuscate,
|
||||
publicComment,
|
||||
privateComment,
|
||||
nil,
|
||||
)
|
||||
} else {
|
||||
// Permission didn't exist yet, create it.
|
||||
apiDomainPerm, _, errWithCode = p.DomainPermissionCreate(
|
||||
ctx,
|
||||
permType,
|
||||
account,
|
||||
domain,
|
||||
util.PtrOrZero(obfuscate),
|
||||
util.PtrOrZero(publicComment),
|
||||
util.PtrOrZero(privateComment),
|
||||
subscriptionID,
|
||||
)
|
||||
}
|
||||
|
||||
if errWithCode != nil {
|
||||
return apimodel.MultiStatusEntry{
|
||||
Resource: domain,
|
||||
Message: errWithCode.Safe(),
|
||||
Status: errWithCode.Code(),
|
||||
}
|
||||
}
|
||||
|
||||
return apimodel.MultiStatusEntry{
|
||||
Resource: apiDomainPerm,
|
||||
Message: http.StatusText(http.StatusOK),
|
||||
Status: http.StatusOK,
|
||||
}
|
||||
}
|
||||
|
||||
// DomainPermissionsGet returns all existing domain
|
||||
// permissions of the requested type. If export is
|
||||
// true, the format will be suitable for writing out
|
||||
|
|
|
@ -106,9 +106,9 @@ func (p *Processor) InstancePeersGet(ctx context.Context, includeSuspended bool,
|
|||
}
|
||||
|
||||
domains = append(domains, &apimodel.Domain{
|
||||
Domain: d,
|
||||
SuspendedAt: util.FormatISO8601(domainBlock.CreatedAt),
|
||||
PublicComment: domainBlock.PublicComment,
|
||||
Domain: d,
|
||||
SuspendedAt: util.FormatISO8601(domainBlock.CreatedAt),
|
||||
Comment: &domainBlock.PublicComment,
|
||||
})
|
||||
}
|
||||
}
|
||||
|
|
|
@ -438,7 +438,7 @@ func (s *Subscriptions) processDomainPermission(
|
|||
Obfuscate: wantedPerm.GetObfuscate(),
|
||||
SubscriptionID: permSub.ID,
|
||||
}
|
||||
insertF = func() error { return s.state.DB.CreateDomainBlock(ctx, domainBlock) }
|
||||
insertF = func() error { return s.state.DB.PutDomainBlock(ctx, domainBlock) }
|
||||
|
||||
action = >smodel.AdminAction{
|
||||
ID: id.NewULID(),
|
||||
|
@ -461,7 +461,7 @@ func (s *Subscriptions) processDomainPermission(
|
|||
Obfuscate: wantedPerm.GetObfuscate(),
|
||||
SubscriptionID: permSub.ID,
|
||||
}
|
||||
insertF = func() error { return s.state.DB.CreateDomainAllow(ctx, domainAllow) }
|
||||
insertF = func() error { return s.state.DB.PutDomainAllow(ctx, domainAllow) }
|
||||
|
||||
action = >smodel.AdminAction{
|
||||
ID: id.NewULID(),
|
||||
|
@ -564,13 +564,13 @@ func permsFromCSV(
|
|||
|
||||
for i, columnHeader := range columnHeaders {
|
||||
// Remove leading # if present.
|
||||
normal := strings.TrimLeft(columnHeader, "#")
|
||||
columnHeader = strings.TrimLeft(columnHeader, "#")
|
||||
|
||||
// Find index of each column header we
|
||||
// care about, ensuring no duplicates.
|
||||
switch normal {
|
||||
switch {
|
||||
|
||||
case "domain":
|
||||
case columnHeader == "domain":
|
||||
if domainI != nil {
|
||||
body.Close()
|
||||
err := gtserror.NewfAt(3, "duplicate domain column header in csv: %+v", columnHeaders)
|
||||
|
@ -578,7 +578,7 @@ func permsFromCSV(
|
|||
}
|
||||
domainI = &i
|
||||
|
||||
case "severity":
|
||||
case columnHeader == "severity":
|
||||
if severityI != nil {
|
||||
body.Close()
|
||||
err := gtserror.NewfAt(3, "duplicate severity column header in csv: %+v", columnHeaders)
|
||||
|
@ -586,15 +586,15 @@ func permsFromCSV(
|
|||
}
|
||||
severityI = &i
|
||||
|
||||
case "public_comment":
|
||||
case columnHeader == "public_comment" || columnHeader == "comment":
|
||||
if publicCommentI != nil {
|
||||
body.Close()
|
||||
err := gtserror.NewfAt(3, "duplicate public_comment column header in csv: %+v", columnHeaders)
|
||||
err := gtserror.NewfAt(3, "duplicate public_comment or comment column header in csv: %+v", columnHeaders)
|
||||
return nil, err
|
||||
}
|
||||
publicCommentI = &i
|
||||
|
||||
case "obfuscate":
|
||||
case columnHeader == "obfuscate":
|
||||
if obfuscateI != nil {
|
||||
body.Close()
|
||||
err := gtserror.NewfAt(3, "duplicate obfuscate column header in csv: %+v", columnHeaders)
|
||||
|
@ -674,15 +674,15 @@ func permsFromCSV(
|
|||
perm.SetPublicComment(record[*publicCommentI])
|
||||
}
|
||||
|
||||
var obfuscate bool
|
||||
if obfuscateI != nil {
|
||||
obfuscate, err := strconv.ParseBool(record[*obfuscateI])
|
||||
obfuscate, err = strconv.ParseBool(record[*obfuscateI])
|
||||
if err != nil {
|
||||
l.Warnf("couldn't parse obfuscate field of record: %+v", record)
|
||||
continue
|
||||
}
|
||||
|
||||
perm.SetObfuscate(&obfuscate)
|
||||
}
|
||||
perm.SetObfuscate(&obfuscate)
|
||||
|
||||
// We're done.
|
||||
perms = append(perms, perm)
|
||||
|
@ -742,8 +742,9 @@ func permsFromJSON(
|
|||
}
|
||||
|
||||
// Set remaining fields.
|
||||
perm.SetPublicComment(apiPerm.PublicComment)
|
||||
perm.SetObfuscate(&apiPerm.Obfuscate)
|
||||
publicComment := cmp.Or(apiPerm.PublicComment, apiPerm.Comment)
|
||||
perm.SetPublicComment(util.PtrOrZero(publicComment))
|
||||
perm.SetObfuscate(util.Ptr(util.PtrOrZero(apiPerm.Obfuscate)))
|
||||
|
||||
// We're done.
|
||||
perms = append(perms, perm)
|
||||
|
@ -792,9 +793,15 @@ func permsFromPlain(
|
|||
var perm gtsmodel.DomainPermission
|
||||
switch permType {
|
||||
case gtsmodel.DomainPermissionBlock:
|
||||
perm = >smodel.DomainBlock{Domain: domain}
|
||||
perm = >smodel.DomainBlock{
|
||||
Domain: domain,
|
||||
Obfuscate: util.Ptr(false),
|
||||
}
|
||||
case gtsmodel.DomainPermissionAllow:
|
||||
perm = >smodel.DomainAllow{Domain: domain}
|
||||
perm = >smodel.DomainAllow{
|
||||
Domain: domain,
|
||||
Obfuscate: util.Ptr(false),
|
||||
}
|
||||
}
|
||||
|
||||
// We're done.
|
||||
|
|
|
@ -775,7 +775,7 @@ func (suite *SubscriptionsTestSuite) TestAdoption() {
|
|||
existingBlock2,
|
||||
existingBlock3,
|
||||
} {
|
||||
if err := testStructs.State.DB.CreateDomainBlock(
|
||||
if err := testStructs.State.DB.PutDomainBlock(
|
||||
ctx, block,
|
||||
); err != nil {
|
||||
suite.FailNow(err.Error())
|
||||
|
@ -876,7 +876,7 @@ func (suite *SubscriptionsTestSuite) TestDomainAllowsAndBlocks() {
|
|||
}
|
||||
|
||||
// Store existing allow.
|
||||
if err := testStructs.State.DB.CreateDomainAllow(ctx, existingAllow); err != nil {
|
||||
if err := testStructs.State.DB.PutDomainAllow(ctx, existingAllow); err != nil {
|
||||
suite.FailNow(err.Error())
|
||||
}
|
||||
|
||||
|
|
|
@ -2182,7 +2182,7 @@ func (c *Converter) DomainPermToAPIDomainPerm(
|
|||
domainPerm := &apimodel.DomainPermission{
|
||||
Domain: apimodel.Domain{
|
||||
Domain: domain,
|
||||
PublicComment: d.GetPublicComment(),
|
||||
PublicComment: util.Ptr(d.GetPublicComment()),
|
||||
},
|
||||
}
|
||||
|
||||
|
@ -2193,8 +2193,8 @@ func (c *Converter) DomainPermToAPIDomainPerm(
|
|||
}
|
||||
|
||||
domainPerm.ID = d.GetID()
|
||||
domainPerm.Obfuscate = util.PtrOrZero(d.GetObfuscate())
|
||||
domainPerm.PrivateComment = d.GetPrivateComment()
|
||||
domainPerm.Obfuscate = d.GetObfuscate()
|
||||
domainPerm.PrivateComment = util.Ptr(d.GetPrivateComment())
|
||||
domainPerm.SubscriptionID = d.GetSubscriptionID()
|
||||
domainPerm.CreatedBy = d.GetCreatedByAccountID()
|
||||
if createdAt := d.GetCreatedAt(); !createdAt.IsZero() {
|
||||
|
|
|
@ -627,7 +627,7 @@ nothanks.com`
|
|||
{
|
||||
"domain": "bumfaces.net",
|
||||
"suspended_at": "2020-05-13T13:29:12.000Z",
|
||||
"public_comment": "big jerks"
|
||||
"comment": "big jerks"
|
||||
},
|
||||
{
|
||||
"domain": "peepee.poopoo",
|
||||
|
|
|
@ -40,39 +40,19 @@ function importEntriesProcessor(formData: ImportDomainPermsParams): (_entry: Dom
|
|||
|
||||
// Override each obfuscate entry if necessary.
|
||||
if (formData.obfuscate !== undefined) {
|
||||
const obfuscateEntry = (entry: DomainPerm) => {
|
||||
processingFuncs.push((entry: DomainPerm) => {
|
||||
entry.obfuscate = formData.obfuscate;
|
||||
};
|
||||
processingFuncs.push(obfuscateEntry);
|
||||
});
|
||||
}
|
||||
|
||||
// Check whether we need to append or replace
|
||||
// private_comment and public_comment.
|
||||
// Check whether we need to replace
|
||||
// private_comment and/or public_comment.
|
||||
["private_comment","public_comment"].forEach((commentType) => {
|
||||
let text = formData.commentType?.trim();
|
||||
if (!text) {
|
||||
return;
|
||||
}
|
||||
|
||||
switch(formData[`${commentType}_behavior`]) {
|
||||
case "append":
|
||||
const appendComment = (entry: DomainPerm) => {
|
||||
if (entry.commentType == undefined) {
|
||||
entry.commentType = text;
|
||||
} else {
|
||||
entry.commentType = [entry.commentType, text].join("\n");
|
||||
}
|
||||
};
|
||||
|
||||
processingFuncs.push(appendComment);
|
||||
break;
|
||||
case "replace":
|
||||
const replaceComment = (entry: DomainPerm) => {
|
||||
entry.commentType = text;
|
||||
};
|
||||
|
||||
processingFuncs.push(replaceComment);
|
||||
break;
|
||||
if (formData[`replace_${commentType}`]) {
|
||||
const text = formData[commentType]?.trim();
|
||||
processingFuncs.push((entry: DomainPerm) => {
|
||||
entry[commentType] = text;
|
||||
});
|
||||
}
|
||||
});
|
||||
|
||||
|
|
|
@ -22,6 +22,7 @@ import { gtsApi } from "../../gts-api";
|
|||
import {
|
||||
replaceCacheOnMutation,
|
||||
removeFromCacheOnMutation,
|
||||
updateCacheOnMutation,
|
||||
} from "../../query-modifiers";
|
||||
import { listToKeyedObject } from "../../transforms";
|
||||
import type {
|
||||
|
@ -55,6 +56,36 @@ const extended = gtsApi.injectEndpoints({
|
|||
...replaceCacheOnMutation("domainAllows")
|
||||
}),
|
||||
|
||||
updateDomainBlock: build.mutation<DomainPerm, any>({
|
||||
query: ({ id, ...formData}) => ({
|
||||
method: "PUT",
|
||||
url: `/api/v1/admin/domain_blocks/${id}`,
|
||||
asForm: true,
|
||||
body: formData,
|
||||
discardEmpty: false
|
||||
}),
|
||||
...updateCacheOnMutation("domainBlocks", {
|
||||
key: (_draft, newData) => {
|
||||
return newData.domain;
|
||||
}
|
||||
})
|
||||
}),
|
||||
|
||||
updateDomainAllow: build.mutation<DomainPerm, any>({
|
||||
query: ({ id, ...formData}) => ({
|
||||
method: "PUT",
|
||||
url: `/api/v1/admin/domain_allows/${id}`,
|
||||
asForm: true,
|
||||
body: formData,
|
||||
discardEmpty: false
|
||||
}),
|
||||
...updateCacheOnMutation("domainAllows", {
|
||||
key: (_draft, newData) => {
|
||||
return newData.domain;
|
||||
}
|
||||
})
|
||||
}),
|
||||
|
||||
removeDomainBlock: build.mutation<DomainPerm, string>({
|
||||
query: (id) => ({
|
||||
method: "DELETE",
|
||||
|
@ -91,6 +122,16 @@ const useAddDomainBlockMutation = extended.useAddDomainBlockMutation;
|
|||
*/
|
||||
const useAddDomainAllowMutation = extended.useAddDomainAllowMutation;
|
||||
|
||||
/**
|
||||
* Update a single domain permission (block) by PUTing to `/api/v1/admin/domain_blocks/{id}`.
|
||||
*/
|
||||
const useUpdateDomainBlockMutation = extended.useUpdateDomainBlockMutation;
|
||||
|
||||
/**
|
||||
* Update a single domain permission (allow) by PUTing to `/api/v1/admin/domain_allows/{id}`.
|
||||
*/
|
||||
const useUpdateDomainAllowMutation = extended.useUpdateDomainAllowMutation;
|
||||
|
||||
/**
|
||||
* Remove a single domain permission (block) by DELETEing to `/api/v1/admin/domain_blocks/{id}`.
|
||||
*/
|
||||
|
@ -104,6 +145,8 @@ const useRemoveDomainAllowMutation = extended.useRemoveDomainAllowMutation;
|
|||
export {
|
||||
useAddDomainBlockMutation,
|
||||
useAddDomainAllowMutation,
|
||||
useUpdateDomainBlockMutation,
|
||||
useUpdateDomainAllowMutation,
|
||||
useRemoveDomainBlockMutation,
|
||||
useRemoveDomainAllowMutation
|
||||
};
|
||||
|
|
|
@ -46,8 +46,8 @@ export interface DomainPerm {
|
|||
valid?: boolean;
|
||||
checked?: boolean;
|
||||
commentType?: string;
|
||||
private_comment_behavior?: "append" | "replace";
|
||||
public_comment_behavior?: "append" | "replace";
|
||||
replace_private_comment?: boolean;
|
||||
replace_public_comment?: boolean;
|
||||
}
|
||||
|
||||
/**
|
||||
|
@ -65,8 +65,8 @@ const domainPermStripOnImport: Set<keyof DomainPerm> = new Set([
|
|||
"valid",
|
||||
"checked",
|
||||
"commentType",
|
||||
"private_comment_behavior",
|
||||
"public_comment_behavior",
|
||||
"replace_private_comment",
|
||||
"replace_public_comment",
|
||||
]);
|
||||
|
||||
/**
|
||||
|
|
|
@ -618,6 +618,15 @@ span.form-info {
|
|||
}
|
||||
}
|
||||
|
||||
section > div.domain-block,
|
||||
section > div.domain-allow {
|
||||
height: 100%;
|
||||
|
||||
> a {
|
||||
margin-top: auto;
|
||||
}
|
||||
}
|
||||
|
||||
.domain-permissions-list {
|
||||
p {
|
||||
margin-top: 0;
|
||||
|
@ -976,32 +985,26 @@ button.tab-button {
|
|||
|
||||
.domain-perm-import-list {
|
||||
.checkbox-list-wrapper {
|
||||
overflow-x: auto;
|
||||
display: grid;
|
||||
gap: 1rem;
|
||||
}
|
||||
|
||||
.checkbox-list {
|
||||
overflow-x: auto;
|
||||
|
||||
.header {
|
||||
align-items: center;
|
||||
input[type="checkbox"] {
|
||||
align-self: start;
|
||||
height: 1.5rem;
|
||||
}
|
||||
}
|
||||
|
||||
.entry {
|
||||
gap: 0;
|
||||
width: 100%;
|
||||
grid-template-columns: auto minmax(25ch, 2fr) minmax(40ch, 1fr);
|
||||
grid-template-rows: auto 1fr;
|
||||
|
||||
input[type="checkbox"] {
|
||||
margin-right: 1rem;
|
||||
}
|
||||
grid-template-columns: auto max(50%, 14rem) 1fr;
|
||||
column-gap: 1rem;
|
||||
align-items: center;
|
||||
|
||||
.domain-input {
|
||||
margin-right: 0.5rem;
|
||||
display: grid;
|
||||
grid-template-columns: 1fr $fa-fw;
|
||||
gap: 0.5rem;
|
||||
|
@ -1020,13 +1023,21 @@ button.tab-button {
|
|||
}
|
||||
|
||||
p {
|
||||
align-self: center;
|
||||
margin: 0;
|
||||
grid-column: 4;
|
||||
grid-row: 1 / span 2;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
.set-comment-checkbox {
|
||||
display: flex;
|
||||
flex-direction: column;
|
||||
gap: 0.25rem;
|
||||
|
||||
padding: 0.5rem 1rem 1rem 1rem;
|
||||
width: 100%;
|
||||
border: 0.1rem solid var(--gray1);
|
||||
border-radius: 0.1rem;
|
||||
}
|
||||
}
|
||||
|
||||
.import-export {
|
||||
|
@ -1406,6 +1417,7 @@ button.tab-button {
|
|||
}
|
||||
}
|
||||
|
||||
.domain-permission-details,
|
||||
.domain-permission-draft-details,
|
||||
.domain-permission-exclude-details,
|
||||
.domain-permission-subscription-details {
|
||||
|
@ -1414,6 +1426,7 @@ button.tab-button {
|
|||
}
|
||||
}
|
||||
|
||||
.domain-permission-details,
|
||||
.domain-permission-drafts-view,
|
||||
.domain-permission-draft-details,
|
||||
.domain-permission-subscriptions-view,
|
||||
|
|
|
@ -32,8 +32,18 @@ import Loading from "../../../components/loading";
|
|||
import BackButton from "../../../components/back-button";
|
||||
import MutationButton from "../../../components/form/mutation-button";
|
||||
|
||||
import { useDomainAllowsQuery, useDomainBlocksQuery } from "../../../lib/query/admin/domain-permissions/get";
|
||||
import { useAddDomainAllowMutation, useAddDomainBlockMutation, useRemoveDomainAllowMutation, useRemoveDomainBlockMutation } from "../../../lib/query/admin/domain-permissions/update";
|
||||
import {
|
||||
useDomainAllowsQuery,
|
||||
useDomainBlocksQuery,
|
||||
} from "../../../lib/query/admin/domain-permissions/get";
|
||||
import {
|
||||
useAddDomainAllowMutation,
|
||||
useAddDomainBlockMutation,
|
||||
useRemoveDomainAllowMutation,
|
||||
useRemoveDomainBlockMutation,
|
||||
useUpdateDomainAllowMutation,
|
||||
useUpdateDomainBlockMutation,
|
||||
} from "../../../lib/query/admin/domain-permissions/update";
|
||||
import { DomainPerm } from "../../../lib/types/domain-permission";
|
||||
import { NoArg } from "../../../lib/types/query";
|
||||
import { Error } from "../../../components/error";
|
||||
|
@ -41,8 +51,10 @@ import { useBaseUrl } from "../../../lib/navigation/util";
|
|||
import { PermType } from "../../../lib/types/perm";
|
||||
import { useCapitalize } from "../../../lib/util";
|
||||
import { formDomainValidator } from "../../../lib/util/formvalidators";
|
||||
import UsernameLozenge from "../../../components/username-lozenge";
|
||||
import { FormSubmitEvent } from "../../../lib/form/types";
|
||||
|
||||
export default function DomainPermDetail() {
|
||||
export default function DomainPermView() {
|
||||
const baseUrl = useBaseUrl();
|
||||
const search = useSearch();
|
||||
|
||||
|
@ -101,33 +113,16 @@ export default function DomainPermDetail() {
|
|||
? blocks[domain]
|
||||
: allows[domain];
|
||||
|
||||
// Render different into content depending on
|
||||
// if we have a perm already for this domain.
|
||||
let infoContent: React.JSX.Element;
|
||||
if (existingPerm === undefined) {
|
||||
infoContent = (
|
||||
<span>
|
||||
No stored {permType} yet, you can add one below:
|
||||
</span>
|
||||
);
|
||||
} else {
|
||||
infoContent = (
|
||||
<div className="info">
|
||||
<i className="fa fa-fw fa-exclamation-triangle" aria-hidden="true"></i>
|
||||
<b>Editing existing domain {permTypeRaw} isn't implemented yet, <a href="https://github.com/superseriousbusiness/gotosocial/issues/1198" target="_blank" rel="noopener noreferrer">check here for progress</a></b>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
const title = <span>Domain {permType} for {domain}</span>;
|
||||
|
||||
return (
|
||||
<div>
|
||||
<h1 className="text-cutoff">
|
||||
<BackButton to={`~${baseUrl}/${permTypeRaw}`} />
|
||||
{" "}
|
||||
Domain {permType} for {domain}
|
||||
</h1>
|
||||
{infoContent}
|
||||
<DomainPermForm
|
||||
<div className="domain-permission-details">
|
||||
<h1><BackButton to={`~${baseUrl}/${permTypeRaw}`} /> {title}</h1>
|
||||
{ existingPerm
|
||||
? <DomainPermDetails perm={existingPerm} permType={permType} />
|
||||
: <span>No stored {permType} yet, you can add one below:</span>
|
||||
}
|
||||
<CreateOrUpdateDomainPerm
|
||||
defaultDomain={domain}
|
||||
perm={existingPerm}
|
||||
permType={permType}
|
||||
|
@ -136,23 +131,75 @@ export default function DomainPermDetail() {
|
|||
);
|
||||
}
|
||||
|
||||
interface DomainPermFormProps {
|
||||
interface DomainPermDetailsProps {
|
||||
perm: DomainPerm,
|
||||
permType: PermType,
|
||||
}
|
||||
|
||||
function DomainPermDetails({
|
||||
perm,
|
||||
permType
|
||||
}: DomainPermDetailsProps) {
|
||||
const baseUrl = useBaseUrl();
|
||||
const [ location ] = useLocation();
|
||||
|
||||
const created = useMemo(() => {
|
||||
if (perm.created_at) {
|
||||
return new Date(perm.created_at).toDateString();
|
||||
}
|
||||
return "unknown";
|
||||
}, [perm.created_at]);
|
||||
|
||||
return (
|
||||
<dl className="info-list">
|
||||
<div className="info-list-entry">
|
||||
<dt>Created</dt>
|
||||
<dd><time dateTime={perm.created_at}>{created}</time></dd>
|
||||
</div>
|
||||
<div className="info-list-entry">
|
||||
<dt>Created By</dt>
|
||||
<dd>
|
||||
<UsernameLozenge
|
||||
account={perm.created_by}
|
||||
linkTo={`~/settings/moderation/accounts/${perm.created_by}`}
|
||||
backLocation={`~${baseUrl}${location}`}
|
||||
/>
|
||||
</dd>
|
||||
</div>
|
||||
<div className="info-list-entry">
|
||||
<dt>Domain</dt>
|
||||
<dd>{perm.domain}</dd>
|
||||
</div>
|
||||
<div className="info-list-entry">
|
||||
<dt>Permission type</dt>
|
||||
<dd className={`permission-type ${permType}`}>
|
||||
<i
|
||||
aria-hidden={true}
|
||||
className={`fa fa-${permType === "allow" ? "check" : "close"}`}
|
||||
></i>
|
||||
{permType}
|
||||
</dd>
|
||||
</div>
|
||||
<div className="info-list-entry">
|
||||
<dt>Subscription ID</dt>
|
||||
<dd>{perm.subscription_id ?? "[none]"}</dd>
|
||||
</div>
|
||||
</dl>
|
||||
);
|
||||
}
|
||||
|
||||
interface CreateOrUpdateDomainPermProps {
|
||||
defaultDomain: string;
|
||||
perm?: DomainPerm;
|
||||
permType: PermType;
|
||||
}
|
||||
|
||||
function DomainPermForm({ defaultDomain, perm, permType }: DomainPermFormProps) {
|
||||
function CreateOrUpdateDomainPerm({
|
||||
defaultDomain,
|
||||
perm,
|
||||
permType
|
||||
}: CreateOrUpdateDomainPermProps) {
|
||||
const isExistingPerm = perm !== undefined;
|
||||
const disabledForm = isExistingPerm
|
||||
? {
|
||||
disabled: true,
|
||||
title: "Domain permissions currently cannot be edited."
|
||||
}
|
||||
: {
|
||||
disabled: false,
|
||||
title: "",
|
||||
};
|
||||
|
||||
const form = {
|
||||
domain: useTextInput("domain", {
|
||||
|
@ -161,8 +208,8 @@ function DomainPermForm({ defaultDomain, perm, permType }: DomainPermFormProps)
|
|||
validator: formDomainValidator,
|
||||
}),
|
||||
obfuscate: useBoolInput("obfuscate", { source: perm }),
|
||||
commentPrivate: useTextInput("private_comment", { source: perm }),
|
||||
commentPublic: useTextInput("public_comment", { source: perm })
|
||||
privateComment: useTextInput("private_comment", { source: perm }),
|
||||
publicComment: useTextInput("public_comment", { source: perm })
|
||||
};
|
||||
|
||||
// Check which perm type we're meant to be handling
|
||||
|
@ -171,112 +218,132 @@ function DomainPermForm({ defaultDomain, perm, permType }: DomainPermFormProps)
|
|||
// react is like "weh" (mood), but we can decide
|
||||
// which ones to use conditionally.
|
||||
const [ addBlock, addBlockResult ] = useAddDomainBlockMutation();
|
||||
const [ updateBlock, updateBlockResult ] = useUpdateDomainBlockMutation({ fixedCacheKey: perm?.id });
|
||||
const [ removeBlock, removeBlockResult] = useRemoveDomainBlockMutation({ fixedCacheKey: perm?.id });
|
||||
const [ addAllow, addAllowResult ] = useAddDomainAllowMutation();
|
||||
const [ updateAllow, updateAllowResult ] = useUpdateDomainAllowMutation({ fixedCacheKey: perm?.id });
|
||||
const [ removeAllow, removeAllowResult ] = useRemoveDomainAllowMutation({ fixedCacheKey: perm?.id });
|
||||
|
||||
const [
|
||||
addTrigger,
|
||||
addResult,
|
||||
createOrUpdateTrigger,
|
||||
createOrUpdateResult,
|
||||
removeTrigger,
|
||||
removeResult,
|
||||
] = useMemo(() => {
|
||||
return permType == "block"
|
||||
? [
|
||||
addBlock,
|
||||
addBlockResult,
|
||||
removeBlock,
|
||||
removeBlockResult,
|
||||
]
|
||||
: [
|
||||
addAllow,
|
||||
addAllowResult,
|
||||
removeAllow,
|
||||
removeAllowResult,
|
||||
];
|
||||
}, [permType,
|
||||
addBlock, addBlockResult, removeBlock, removeBlockResult,
|
||||
addAllow, addAllowResult, removeAllow, removeAllowResult,
|
||||
switch (true) {
|
||||
case (permType === "block" && !isExistingPerm):
|
||||
return [ addBlock, addBlockResult, removeBlock, removeBlockResult ];
|
||||
case (permType === "block"):
|
||||
return [ updateBlock, updateBlockResult, removeBlock, removeBlockResult ];
|
||||
case !isExistingPerm:
|
||||
return [ addAllow, addAllowResult, removeAllow, removeAllowResult ];
|
||||
default:
|
||||
return [ updateAllow, updateAllowResult, removeAllow, removeAllowResult ];
|
||||
}
|
||||
}, [permType, isExistingPerm,
|
||||
addBlock, addBlockResult, updateBlock, updateBlockResult, removeBlock, removeBlockResult,
|
||||
addAllow, addAllowResult, updateAllow, updateAllowResult, removeAllow, removeAllowResult,
|
||||
]);
|
||||
|
||||
// Use appropriate submission params for this permType.
|
||||
const [submitForm, submitFormResult] = useFormSubmit(form, [addTrigger, addResult], { changedOnly: false });
|
||||
// Use appropriate submission params for this
|
||||
// permType, and whether we're creating or updating.
|
||||
const [submit, submitResult] = useFormSubmit(
|
||||
form,
|
||||
[ createOrUpdateTrigger, createOrUpdateResult ],
|
||||
{
|
||||
changedOnly: isExistingPerm,
|
||||
// If we're updating an existing perm,
|
||||
// insert the perm ID into the mutation
|
||||
// data before submitting. Otherwise just
|
||||
// return the mutationData unmodified.
|
||||
customizeMutationArgs: (mutationData) => {
|
||||
if (isExistingPerm) {
|
||||
return {
|
||||
id: perm?.id,
|
||||
...mutationData,
|
||||
};
|
||||
} else {
|
||||
return mutationData;
|
||||
}
|
||||
},
|
||||
},
|
||||
);
|
||||
|
||||
// Uppercase first letter of given permType.
|
||||
const permTypeUpper = useCapitalize(permType);
|
||||
|
||||
const [location, setLocation] = useLocation();
|
||||
|
||||
function verifyUrlThenSubmit(e) {
|
||||
function onSubmit(e: FormSubmitEvent) {
|
||||
// Adding a new domain permissions happens on a url like
|
||||
// "/settings/admin/domain-permissions/:permType/domain.com",
|
||||
// but if domain input changes, that doesn't match anymore
|
||||
// and causes issues later on so, before submitting the form,
|
||||
// silently change url, and THEN submit.
|
||||
let correctUrl = `/${permType}s/${form.domain.value}`;
|
||||
if (location != correctUrl) {
|
||||
setLocation(correctUrl);
|
||||
if (!isExistingPerm) {
|
||||
let correctUrl = `/${permType}s/${form.domain.value}`;
|
||||
if (location != correctUrl) {
|
||||
setLocation(correctUrl);
|
||||
}
|
||||
}
|
||||
return submitForm(e);
|
||||
return submit(e);
|
||||
}
|
||||
|
||||
return (
|
||||
<form onSubmit={verifyUrlThenSubmit}>
|
||||
<TextInput
|
||||
field={form.domain}
|
||||
label="Domain"
|
||||
placeholder="example.com"
|
||||
autoCapitalize="none"
|
||||
spellCheck="false"
|
||||
{...disabledForm}
|
||||
/>
|
||||
<form onSubmit={onSubmit}>
|
||||
{ !isExistingPerm &&
|
||||
<TextInput
|
||||
field={form.domain}
|
||||
label="Domain"
|
||||
placeholder="example.com"
|
||||
autoCapitalize="none"
|
||||
spellCheck="false"
|
||||
/>
|
||||
}
|
||||
|
||||
<Checkbox
|
||||
field={form.obfuscate}
|
||||
label="Obfuscate domain in public lists"
|
||||
{...disabledForm}
|
||||
/>
|
||||
|
||||
<TextArea
|
||||
field={form.commentPrivate}
|
||||
field={form.privateComment}
|
||||
label="Private comment"
|
||||
autoCapitalize="sentences"
|
||||
rows={3}
|
||||
{...disabledForm}
|
||||
/>
|
||||
|
||||
<TextArea
|
||||
field={form.commentPublic}
|
||||
field={form.publicComment}
|
||||
label="Public comment"
|
||||
autoCapitalize="sentences"
|
||||
rows={3}
|
||||
{...disabledForm}
|
||||
/>
|
||||
|
||||
<div className="action-buttons row">
|
||||
<MutationButton
|
||||
label={permTypeUpper}
|
||||
result={submitFormResult}
|
||||
showError={false}
|
||||
{...disabledForm}
|
||||
label={isExistingPerm ? "Update " + permType.toString() : permTypeUpper}
|
||||
result={submitResult}
|
||||
disabled={
|
||||
isExistingPerm &&
|
||||
!form.obfuscate.hasChanged() &&
|
||||
!form.privateComment.hasChanged() &&
|
||||
!form.publicComment.hasChanged()
|
||||
}
|
||||
/>
|
||||
|
||||
{
|
||||
isExistingPerm &&
|
||||
<MutationButton
|
||||
{ isExistingPerm &&
|
||||
<button
|
||||
type="button"
|
||||
onClick={() => removeTrigger(perm.id?? "")}
|
||||
label="Remove"
|
||||
result={removeResult}
|
||||
className="button danger"
|
||||
showError={false}
|
||||
disabled={!isExistingPerm}
|
||||
/>
|
||||
>
|
||||
Remove {permType.toString()}
|
||||
</button>
|
||||
}
|
||||
</div>
|
||||
|
||||
<>
|
||||
{addResult.error && <Error error={addResult.error} />}
|
||||
{createOrUpdateResult.error && <Error error={createOrUpdateResult.error} />}
|
||||
{removeResult.error && <Error error={removeResult.error} />}
|
||||
</>
|
||||
|
||||
|
|
|
@ -61,7 +61,7 @@ export default function ImportExport() {
|
|||
>
|
||||
< back
|
||||
</span>
|
||||
Confirm import of domain {form.permType.value}s:
|
||||
Confirm {form.permType.value}s:
|
||||
</h1>
|
||||
<ProcessImport
|
||||
list={parseResult.data}
|
||||
|
|
|
@ -24,14 +24,12 @@ import { isValidDomainPermission, hasBetterScope } from "../../../lib/util/domai
|
|||
import {
|
||||
useTextInput,
|
||||
useBoolInput,
|
||||
useRadioInput,
|
||||
useCheckListInput,
|
||||
} from "../../../lib/form";
|
||||
|
||||
import {
|
||||
Select,
|
||||
TextArea,
|
||||
RadioGroup,
|
||||
Checkbox,
|
||||
TextInput,
|
||||
} from "../../../components/form/inputs";
|
||||
|
@ -113,84 +111,81 @@ function ImportList({ list, data: domainPerms, permType }: ImportListProps) {
|
|||
privateComment: useTextInput("private_comment", {
|
||||
defaultValue: `Imported on ${new Date().toLocaleString()}`
|
||||
}),
|
||||
privateCommentBehavior: useRadioInput("private_comment_behavior", {
|
||||
defaultValue: "append",
|
||||
options: {
|
||||
append: "Append to",
|
||||
replace: "Replace"
|
||||
}
|
||||
}),
|
||||
replacePrivateComment: useBoolInput("replace_private_comment", { defaultValue: false }),
|
||||
publicComment: useTextInput("public_comment"),
|
||||
publicCommentBehavior: useRadioInput("public_comment_behavior", {
|
||||
defaultValue: "append",
|
||||
options: {
|
||||
append: "Append to",
|
||||
replace: "Replace"
|
||||
}
|
||||
}),
|
||||
replacePublicComment: useBoolInput("replace_public_comment", { defaultValue: false }),
|
||||
permType: permType,
|
||||
};
|
||||
|
||||
const [importDomains, importResult] = useFormSubmit(form, useImportDomainPermsMutation(), { changedOnly: false });
|
||||
const [importDomains, importResult] = useFormSubmit(
|
||||
form,
|
||||
useImportDomainPermsMutation(),
|
||||
{ changedOnly: false },
|
||||
);
|
||||
|
||||
return (
|
||||
<>
|
||||
<form
|
||||
onSubmit={importDomains}
|
||||
className="domain-perm-import-list"
|
||||
>
|
||||
<span>{list.length} domain{list.length != 1 ? "s" : ""} in this list</span>
|
||||
<form
|
||||
onSubmit={importDomains}
|
||||
className="domain-perm-import-list"
|
||||
>
|
||||
<span>{list.length} domain{list.length != 1 ? "s" : ""} in this list</span>
|
||||
|
||||
{hasComment.both &&
|
||||
{hasComment.both &&
|
||||
<Select field={showComment} options={
|
||||
<>
|
||||
<option value="public_comment">Show public comments</option>
|
||||
<option value="private_comment">Show private comments</option>
|
||||
</>
|
||||
} />
|
||||
}
|
||||
}
|
||||
|
||||
<div className="checkbox-list-wrapper">
|
||||
<DomainCheckList
|
||||
field={form.domains}
|
||||
domainPerms={domainPerms}
|
||||
commentType={showComment.value as "public_comment" | "private_comment"}
|
||||
permType={form.permType}
|
||||
/>
|
||||
</div>
|
||||
<div className="checkbox-list-wrapper">
|
||||
<DomainCheckList
|
||||
field={form.domains}
|
||||
domainPerms={domainPerms}
|
||||
commentType={showComment.value as "public_comment" | "private_comment"}
|
||||
permType={form.permType}
|
||||
/>
|
||||
</div>
|
||||
|
||||
<Checkbox
|
||||
field={form.obfuscate}
|
||||
label="Obfuscate domains in public lists"
|
||||
/>
|
||||
|
||||
<div className="set-comment-checkbox">
|
||||
<Checkbox
|
||||
field={form.replacePrivateComment}
|
||||
label="Set/replace private comment(s) to:"
|
||||
/>
|
||||
<TextArea
|
||||
field={form.privateComment}
|
||||
label="Private comment"
|
||||
rows={3}
|
||||
disabled={!form.replacePrivateComment.value}
|
||||
placeholder="Private comment"
|
||||
/>
|
||||
<RadioGroup
|
||||
field={form.privateCommentBehavior}
|
||||
label="imported private comment"
|
||||
/>
|
||||
</div>
|
||||
|
||||
<div className="set-comment-checkbox">
|
||||
<Checkbox
|
||||
field={form.replacePublicComment}
|
||||
label="Set/replace public comment(s) to:"
|
||||
/>
|
||||
<TextArea
|
||||
field={form.publicComment}
|
||||
label="Public comment"
|
||||
rows={3}
|
||||
disabled={!form.replacePublicComment.value}
|
||||
placeholder="Public comment"
|
||||
/>
|
||||
<RadioGroup
|
||||
field={form.publicCommentBehavior}
|
||||
label="imported public comment"
|
||||
/>
|
||||
</div>
|
||||
|
||||
<Checkbox
|
||||
field={form.obfuscate}
|
||||
label="Obfuscate domains in public lists"
|
||||
/>
|
||||
|
||||
<MutationButton
|
||||
label="Import"
|
||||
disabled={false}
|
||||
result={importResult}
|
||||
/>
|
||||
</form>
|
||||
</>
|
||||
<MutationButton
|
||||
label="Import"
|
||||
disabled={false}
|
||||
result={importResult}
|
||||
/>
|
||||
</form>
|
||||
);
|
||||
}
|
||||
|
||||
|
|
|
@ -25,7 +25,7 @@ import ReportDetail from "./reports/detail";
|
|||
import { ErrorBoundary } from "../../lib/navigation/error";
|
||||
import ImportExport from "./domain-permissions/import-export";
|
||||
import DomainPermissionsOverview from "./domain-permissions/overview";
|
||||
import DomainPermDetail from "./domain-permissions/detail";
|
||||
import DomainPermView from "./domain-permissions/detail";
|
||||
import AccountsSearch from "./accounts";
|
||||
import AccountsPending from "./accounts/pending";
|
||||
import AccountDetail from "./accounts/detail";
|
||||
|
@ -160,7 +160,7 @@ function ModerationDomainPermsRouter() {
|
|||
<Route path="/subscriptions/preview" component={DomainPermissionSubscriptionsPreview} />
|
||||
<Route path="/subscriptions/:permSubId" component={DomainPermissionSubscriptionDetail} />
|
||||
<Route path="/:permType" component={DomainPermissionsOverview} />
|
||||
<Route path="/:permType/:domain" component={DomainPermDetail} />
|
||||
<Route path="/:permType/:domain" component={DomainPermView} />
|
||||
<Route><Redirect to="/blocks"/></Route>
|
||||
</Switch>
|
||||
</ErrorBoundary>
|
||||
|
|
Loading…
Reference in New Issue