mirror of
1
Fork 0
gotosocial/internal/api/client/statuses
ewwwin 424f62dd70
[bugfix] Store and expose status content type (#3870)
* Add ContentType to internal models

* Add ContentType to API models StatusSource and StatusEdit

* Add helpers to convert between API/internal StatusContentType

* Write status content type on create/edit

* Add migration

* Update API docs

go run github.com/go-swagger/go-swagger/cmd/swagger generate spec --scan-models --exclude-deps --output docs/api/swagger.yaml

* ensure ContentType is updated anywhere Text is

* Update docs, take care of TODOs

* Set ContentType in more places where Text is set

* We don't actually use ContentType on the API status model

* Update StatusSource test

* Remove unused helper function I copied

* Revert change to StatusContentType swagger annotation

I'm going to include this in a follow-on PR instead.

* Add test for updating content type in edits

* Return a value from processContentType instead of modifying the existing status

Fixes an issue that was caught by the test I just added - the recorded edit would be marked with the *new* content type instead of the old one, which is obviously bad

* Add test for handling of statuses with no stored content type

* repurpose an existing test status instead of adding a new one to avoid breaking other tests

* Add test to ensure newly created statuses always have content type saved

* Do include content type on status API model actually

This is mostly important when deleting and redrafting.

The comment on `apimodel.Status.Text` implies that it's not sent except in response to status deletion, but actually this doesn't seem to be the case; it also appears to be present in responses to creations and normal fetches and stuff. So I'm treating `ContentType` the same here.

* Update new tests to check content type on API statuses

* Check content type of API statuses in all tests where text is checked

* update other api tests with status content type field

* Add test ensuring text and content type are returned when deleting a status

* Convert processContentType to free function and remove unused parameter

* check for the correct value in the deletion test

* Be explicit about this test status having an empty content type

* Use omitempty consistently on API models

* clean up the final diff a bit

* one more swagger regen for the road

* Handle nil statuses in processContentType

* Don't pass processContentType the entire edit form, it doesn't need it

* Move processContentType to common.go and use for creation as well

* Remove unused parameters to ContentTypeToAPIContentType
2025-03-06 16:31:52 +00:00
..
status.go [feature] add support for clients editing statuses and fetching status revision history (#3628) 2024-12-23 17:54:44 +00:00
status_test.go [feature] Refactor tokens, allow multiple app redirect_uris (#3849) 2025-03-03 15:03:36 +00:00
statusbookmark.go [feature] Enforce OAuth token scopes (#3835) 2025-02-26 13:04:55 +01:00
statusbookmark_test.go [chore] Improve copyright header handling (#1608) 2023-03-12 16:00:57 +01:00
statusboost.go [feature] Enforce OAuth token scopes (#3835) 2025-02-26 13:04:55 +01:00
statusboost_test.go [bugfix] Store and expose status content type (#3870) 2025-03-06 16:31:52 +00:00
statusboostedby.go [feature] Enforce OAuth token scopes (#3835) 2025-02-26 13:04:55 +01:00
statusboostedby_test.go [chore] Improve copyright header handling (#1608) 2023-03-12 16:00:57 +01:00
statuscontext.go [feature] Enforce OAuth token scopes (#3835) 2025-02-26 13:04:55 +01:00
statuscreate.go [feature] Enforce OAuth token scopes (#3835) 2025-02-26 13:04:55 +01:00
statuscreate_test.go [bugfix] Store and expose status content type (#3870) 2025-03-06 16:31:52 +00:00
statusdelete.go [feature] Enforce OAuth token scopes (#3835) 2025-02-26 13:04:55 +01:00
statusdelete_test.go [bugfix] Store and expose status content type (#3870) 2025-03-06 16:31:52 +00:00
statusedit.go [feature] Enforce OAuth token scopes (#3835) 2025-02-26 13:04:55 +01:00
statusedit_test.go [feature] add support for clients editing statuses and fetching status revision history (#3628) 2024-12-23 17:54:44 +00:00
statusfave.go [feature] Enforce OAuth token scopes (#3835) 2025-02-26 13:04:55 +01:00
statusfave_test.go [bugfix] Store and expose status content type (#3870) 2025-03-06 16:31:52 +00:00
statusfavedby.go [feature] Enforce OAuth token scopes (#3835) 2025-02-26 13:04:55 +01:00
statusfavedby_test.go [chore] Improve copyright header handling (#1608) 2023-03-12 16:00:57 +01:00
statusget.go [feature] Enforce OAuth token scopes (#3835) 2025-02-26 13:04:55 +01:00
statusget_test.go [chore] Improve copyright header handling (#1608) 2023-03-12 16:00:57 +01:00
statushistory.go [feature] Enforce OAuth token scopes (#3835) 2025-02-26 13:04:55 +01:00
statushistory_test.go [bug] Add missing `group` property to the Account model (#3746) 2025-02-08 13:04:30 +01:00
statusmute.go [feature] Enforce OAuth token scopes (#3835) 2025-02-26 13:04:55 +01:00
statusmute_test.go [bugfix] Store and expose status content type (#3870) 2025-03-06 16:31:52 +00:00
statuspin.go [feature] Enforce OAuth token scopes (#3835) 2025-02-26 13:04:55 +01:00
statuspin_test.go [chore] Add interaction policy gtsmodels (#3075) 2024-07-11 15:44:29 +01:00
statussource.go [feature] Enforce OAuth token scopes (#3835) 2025-02-26 13:04:55 +01:00
statussource_test.go [bugfix] Store and expose status content type (#3870) 2025-03-06 16:31:52 +00:00
statusunbookmark.go [feature] Enforce OAuth token scopes (#3835) 2025-02-26 13:04:55 +01:00
statusunbookmark_test.go [chore] Improve copyright header handling (#1608) 2023-03-12 16:00:57 +01:00
statusunboost.go [feature] Enforce OAuth token scopes (#3835) 2025-02-26 13:04:55 +01:00
statusunfave.go [feature] Enforce OAuth token scopes (#3835) 2025-02-26 13:04:55 +01:00
statusunfave_test.go [chore] Improve copyright header handling (#1608) 2023-03-12 16:00:57 +01:00
statusunmute.go [feature] Enforce OAuth token scopes (#3835) 2025-02-26 13:04:55 +01:00
statusunpin.go [feature] Enforce OAuth token scopes (#3835) 2025-02-26 13:04:55 +01:00
statusunpin_test.go [feature] add support for polls + receiving federated status edits (#2330) 2023-11-08 14:32:17 +00:00