mirror of
1
Fork 0
gotosocial/internal/processing
ewwwin 424f62dd70
[bugfix] Store and expose status content type (#3870)
* Add ContentType to internal models

* Add ContentType to API models StatusSource and StatusEdit

* Add helpers to convert between API/internal StatusContentType

* Write status content type on create/edit

* Add migration

* Update API docs

go run github.com/go-swagger/go-swagger/cmd/swagger generate spec --scan-models --exclude-deps --output docs/api/swagger.yaml

* ensure ContentType is updated anywhere Text is

* Update docs, take care of TODOs

* Set ContentType in more places where Text is set

* We don't actually use ContentType on the API status model

* Update StatusSource test

* Remove unused helper function I copied

* Revert change to StatusContentType swagger annotation

I'm going to include this in a follow-on PR instead.

* Add test for updating content type in edits

* Return a value from processContentType instead of modifying the existing status

Fixes an issue that was caught by the test I just added - the recorded edit would be marked with the *new* content type instead of the old one, which is obviously bad

* Add test for handling of statuses with no stored content type

* repurpose an existing test status instead of adding a new one to avoid breaking other tests

* Add test to ensure newly created statuses always have content type saved

* Do include content type on status API model actually

This is mostly important when deleting and redrafting.

The comment on `apimodel.Status.Text` implies that it's not sent except in response to status deletion, but actually this doesn't seem to be the case; it also appears to be present in responses to creations and normal fetches and stuff. So I'm treating `ContentType` the same here.

* Update new tests to check content type on API statuses

* Check content type of API statuses in all tests where text is checked

* update other api tests with status content type field

* Add test ensuring text and content type are returned when deleting a status

* Convert processContentType to free function and remove unused parameter

* check for the correct value in the deletion test

* Be explicit about this test status having an empty content type

* Use omitempty consistently on API models

* clean up the final diff a bit

* one more swagger regen for the road

* Handle nil statuses in processContentType

* Don't pass processContentType the entire edit form, it doesn't need it

* Move processContentType to common.go and use for creation as well

* Remove unused parameters to ContentTypeToAPIContentType
2025-03-06 16:31:52 +00:00
..
account [feature] Add token review / delete to backend + settings panel (#3845) 2025-03-04 10:01:25 +00:00
admin [feature] Refactor tokens, allow multiple app redirect_uris (#3849) 2025-03-03 15:03:36 +00:00
advancedmigrations [feature] Conversations API (#3013) 2024-07-23 20:44:31 +01:00
common [feature] add support for clients editing statuses and fetching status revision history (#3628) 2024-12-23 17:54:44 +00:00
conversations [feature] Refactor tokens, allow multiple app redirect_uris (#3849) 2025-03-03 15:03:36 +00:00
fedi [chore] github.com/superseriousbusiness/activity -> codeberg.org/superseriousbusiness/activity (#3853) 2025-03-02 12:48:00 +01:00
filters [bugfix] Allow unsetting filter expiration dates (#3560) 2024-11-26 08:23:00 -08:00
interactionrequests [feature] Process `Reject` of interaction via fedi API, put rejected statuses in the "sin bin" 😈 (#3271) 2024-09-10 12:34:49 +00:00
list [performance] cache more database calls, reduce required database calls overall (#3290) 2024-09-16 16:46:09 +00:00
markers [chore] deinterface the typeutils.Converter and update to use state structure (#2217) 2023-09-23 18:44:11 +02:00
media [feature] Refactor tokens, allow multiple app redirect_uris (#3849) 2025-03-03 15:03:36 +00:00
polls [bugfix] update fedi api to support multiple separate votes in same multiple choice poll (#3809) 2025-02-20 11:13:07 +01:00
push [feature] Implement Web Push notification policy (#3721) 2025-02-03 10:25:53 +00:00
report [feature/frontend] Reports frontend v2 (#3022) 2024-06-18 18:18:00 +02:00
search [feature] Implement following hashtags (#3141) 2024-07-29 19:26:31 +01:00
status [bugfix] Store and expose status content type (#3870) 2025-03-06 16:31:52 +00:00
stream [feature] Refactor tokens, allow multiple app redirect_uris (#3849) 2025-03-03 15:03:36 +00:00
tags [feature] Implement following hashtags (#3141) 2024-07-29 19:26:31 +01:00
timeline [feature] Enforce OAuth token scopes (#3835) 2025-02-26 13:04:55 +01:00
user [feature] Refactor tokens, allow multiple app redirect_uris (#3849) 2025-03-03 15:03:36 +00:00
workers [feature] Refactor tokens, allow multiple app redirect_uris (#3849) 2025-03-03 15:03:36 +00:00
app.go [feature] Refactor tokens, allow multiple app redirect_uris (#3849) 2025-03-03 15:03:36 +00:00
followrequest_test.go [performance] massively improved ActivityPub delivery worker efficiency (#2812) 2024-04-11 11:45:35 +02:00
instance.go [feature] add support for clients editing statuses and fetching status revision history (#3628) 2024-12-23 17:54:44 +00:00
oauth.go [chore] migrate oauth2 -> codeberg (#3857) 2025-03-02 16:42:51 +01:00
parsemention.go [bugfix] Refactor parse mention, fix local mention bug (#2657) 2024-02-19 03:48:20 +00:00
parsemention_test.go [bugfix] Refactor parse mention, fix local mention bug (#2657) 2024-02-19 03:48:20 +00:00
preferences.go [performance] convert enum strings to ints (#3558) 2024-11-25 14:48:59 +01:00
preferences_test.go [feature] Implement the preferences client API (#1740) 2023-05-06 17:42:58 +02:00
processor.go [feature] Push notifications (#3587) 2025-01-23 16:47:30 -08:00
processor_test.go [feature] Refactor tokens, allow multiple app redirect_uris (#3849) 2025-03-03 15:03:36 +00:00