27f8f955bf
Merge pull request 's/Gitea/Forgejo in various log messages and comments' ( #3353 ) from 0ko/forgejo:forgejo-forgejo-forgejo-forgejo-forgejo-forgejo-forgejo-forgejo-forgejo-forgejo into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3353
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-04-22 07:54:30 +00:00
f4716de5b6
Merge pull request '[PORT] gitea#30546: Add form field id generation, remove duplicated ids' ( #3361 ) from algernon/forgejo:gitea/port/30546 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3361
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-04-22 07:43:25 +00:00
a01387f5b1
Add form field id generation, remove duplicated ids ( #30546 )
...
Fixes: https://github.com/go-gitea/gitea/issues/30384
On repo settings page, there id `repo_name` was used 5 times on the same
page, some in modal and such. I think we are better off just
auto-generating these IDs in the future so that labels link up with
their form element.
Ideally this id generation would be done in backend in a subtemplate,
but seeing that we already have similar JS patches for checkboxes, I
took the easy path for now.
I also checked that these `#repo_name` were not in use in JS and the
only case where this id appears in JS is on the migration page where
it's still there.
---------
Co-authored-by: Giteabot <teabot@gitea.io>
(cherry picked from commit d4ec6b3d16496ce3b479d5a08f79823122dc2b7b)
Conflicts:
- templates/repo/settings/options.tmpl
Conflict resolved by manually removing all `id` and `for`
attributes from elements that had `repo_name` as their id.
2024-04-22 08:09:00 +02:00
438efc9ca2
Merge pull request '[UI] Fix and refactor for milestone headers' ( #3340 ) from 0ko/forgejo:mileston-inconsist into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3340
Reviewed-by: Otto <otto@codeberg.org>
2024-04-21 16:39:38 +00:00
469c214ec8
s/Gitea/Forgejo in various log messages and comments
2024-04-21 21:26:15 +05:00
f0f8210279
[I18N] Translations update from Weblate ( #3244 )
...
Translations update from [Weblate](https://translate.codeberg.org ) for [Forgejo/forgejo](https://translate.codeberg.org/projects/forgejo/forgejo/ ).
Current translation status:
Co-authored-by: Justman10000 <Justman10000@users.noreply.translate.codeberg.org>
Co-authored-by: earl-warren <earl-warren@users.noreply.translate.codeberg.org>
Co-authored-by: 0ko <0ko@users.noreply.translate.codeberg.org>
Co-authored-by: Fjuro <fjuro@alius.cz>
Co-authored-by: Dirk <Dirk@users.noreply.translate.codeberg.org>
Co-authored-by: hankskyjames777 <hankskyjames777@users.noreply.translate.codeberg.org>
Co-authored-by: emansije <emansije@users.noreply.translate.codeberg.org>
Co-authored-by: Kita Ikuyo <searinminecraft@courvix.com>
Co-authored-by: Salif Mehmed <mail@salif.eu>
Co-authored-by: fnetX <otto@codeberg.org>
Co-authored-by: EssGeeEich <EssGeeEich@users.noreply.translate.codeberg.org>
Co-authored-by: Zughy <Zughy@users.noreply.translate.codeberg.org>
Co-authored-by: Xinayder <Xinayder@users.noreply.translate.codeberg.org>
Co-authored-by: m0s <m0s@users.noreply.translate.codeberg.org>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3244
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Co-authored-by: Codeberg Translate <translate@noreply.codeberg.org>
Co-committed-by: Codeberg Translate <translate@noreply.codeberg.org>
2024-04-21 14:02:21 +00:00
bb11bf8748
Merge pull request 'cleanup(tests): remove manual testing submodule' ( #3347 ) from earl-warren/forgejo:wip-manual-testing into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3347
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
2024-04-21 08:46:02 +00:00
69c614162f
cleanup(tests): remove manual testing submodule
...
It is not effective, a different approach is needed
2024-04-21 10:13:51 +02:00
d029796e1e
Merge pull request 'Fix some edge cases with permalink rendering' ( #3286 ) from Mai-Lapyst/forgejo:fix-permalink-rendering-edgecases into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3286
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-04-20 10:24:05 +00:00
38f2aa871e
[UI] Refactor display of milestone issue list header
2024-04-20 14:11:38 +05:00
592367c43a
[UI] Fix milestone header inconsistencies with issues/PRs
2024-04-20 14:06:26 +05:00
41e0507cd3
Merge pull request 'hooks: Harden when we accept push options that change repo settings' ( #3314 ) from earl-warren/forgejo:wip-push-options into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3314
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
Reviewed-by: Gergely Nagy <algernon@noreply.codeberg.org>
2024-04-20 05:57:35 +00:00
8947948a0a
Merge pull request 'Various improvements to pages: notifications and subscriptions' ( #3175 ) from 0ko/forgejo:meet-your-subscribtions into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3175
Reviewed-by: Otto <otto@codeberg.org>
2024-04-20 05:27:15 +00:00
acfae43253
Fix panic where now a third link breaks everything
2024-04-19 23:54:46 +02:00
e9eacdecd2
Fix issue where rendering stops after the first invalid parmalink
2024-04-19 18:21:21 +02:00
8eba631f8d
hooks: Harden when we accept push options that change repo settings
...
It is possible to change some repo settings (its visibility, and
template status) via `git push` options: `-o repo.private=true`, `-o
repo.template=true`.
Previously, there weren't sufficient permission checks on these, and
anyone who could `git push` to a repository - including via an AGit
workflow! - was able to change either of these settings. To guard
against this, the pre-receive hook will now check if either of these
options are present, and if so, will perform additional permission
checks to ensure that these can only be set by a repository owner or
an administrator. Additionally, changing these settings is disabled for
forks, even for the fork's owner.
There's still a case where the owner of a repository can change the
visibility of it, and it will not propagate to forks (it propagates to
forks when changing the visibility via the API), but that's an
inconsistency, not a security issue.
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
Signed-off-by: Earl Warren <contact@earl-warren.org>
2024-04-19 16:53:14 +02:00
67d6c674df
Merge pull request 'Remove EasyMDE from various areas' ( #2916 ) from 0ko/forgejo:easymde into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2916
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-04-19 13:48:34 +00:00
b05a7809b5
Merge pull request 'fix(tests): 30s to cancel processes to avoid false negatives' ( #3317 ) from earl-warren/forgejo:wip-cancel-test into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3317
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
Reviewed-by: Otto <otto@codeberg.org>
2024-04-19 12:48:41 +00:00
0342b7fdcd
Merge pull request '[RELEASE] v1.21.11-1 release notes' ( #3330 ) from earl-warren/forgejo:wip-release-notes-1.21 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3330
Reviewed-by: twenty-panda <twenty-panda@noreply.codeberg.org>
2024-04-19 11:49:03 +00:00
af7decae18
Merge pull request 'Update citation-js monorepo to v0.7.11' ( #3321 ) from renovate/citation-js-monorepo into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3321
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-04-19 11:08:57 +00:00
080f1e8250
[RELEASE] v1.21.11-1 release notes
2024-04-19 13:00:57 +02:00
b6992ed6b9
Merge pull request 'services: Use proper Message-IDs for release mails' ( #3309 ) from algernon/forgejo:are-we-dot-atom-text-yet into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3309
Reviewed-by: Otto <otto@codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-04-19 08:35:17 +00:00
82ec2a65e0
Update citation-js monorepo to v0.7.11
2024-04-19 00:02:54 +00:00
9a80f6b57e
Merge pull request 'v1.21.11-0 release notes' ( #3287 ) from crystal/forgejo:pr/releasenotes-1.21.11-0 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3287
Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-04-18 20:14:21 +00:00
77843135b0
slight wording change and most serious fix first
2024-04-18 21:57:53 +02:00
2b2c0f1ae2
add security fixes details, link to compare
2024-04-18 12:37:59 -06:00
d335a3330f
Merge pull request 'ci(renovate): fix step names (take 2)' ( #3318 ) from earl-warren/forgejo:wip-renovate-run into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3318
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-04-18 18:17:16 +00:00
9303f8e72d
ci(renovate): fix step names (take 2)
2024-04-18 20:08:27 +02:00
6316e21be2
fix(tests): 30s to cancel processes to avoid false negatives
...
on slower machines it can take more than 1 second to cancel leftover
tasks
2024-04-18 18:47:49 +02:00
c7b8a434c3
Merge pull request 'ci(renovate): fix step names' ( #3311 ) from viceice/forgejo:ci/renovate/fix-step-names into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3311
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-04-18 14:04:19 +00:00
b58474173a
Merge pull request 'Update ghcr.io/visualon/renovate Docker tag to v37.305.0' ( #3312 ) from renovate/ghcr.io-visualon-renovate-37.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3312
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-04-18 13:54:22 +00:00
95fa27374b
typo
2024-04-18 07:27:48 -06:00
b0c0167c54
services: Use proper Message-IDs for release mails
...
When sending notification emails about a release, use a properly
formatted, RFC-compliant message id, rather than the release's HTML URL
wrapped in angle brackets (which would not be compliant).
Fixes #3105 .
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
2024-04-18 13:44:18 +02:00
0f078ba4c9
Update ghcr.io/visualon/renovate Docker tag to v37.305.0
2024-04-18 11:25:53 +00:00
1f4915692b
ci(renovate): fix step names
2024-04-18 13:22:51 +02:00
ca2473e895
Update ghcr.io/visualon/renovate Docker tag to v37.303.2
2024-04-17 16:05:21 +00:00
bc3e66097c
Merge pull request 'fix(release): add missing ARG RELEASE_VERSION' ( #3290 ) from earl-warren/forgejo:wip-oci-labels into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3290
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-04-17 15:51:36 +00:00
97189d41f3
fix(release): add missing ARG RELEASE_VERSION
...
The ARG RELEASE_VERSION set in the build-env image does not propagate
to the images that follow. As a result the value of the version label
is always empty.
This should have been caught by the test in the CI but although it
notified the problem in the output, it did not fail. Upgrade to the
forgejo-build-publish version that fixes this false positive.
2024-04-17 17:16:53 +02:00
0ff5be49ab
[RELEASE] v1.21.11-0 release notes
2024-04-17 05:45:41 -06:00
d07f12e010
Merge pull request 'Do not require login_name & source_id for /admin/user/{username}' ( #3278 ) from algernon/forgejo:leave-your-name-at-the-door into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3278
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-04-17 11:05:13 +00:00
5b6b3f3fb3
Fix some edge cases; closes #3232
...
- Fixes wrong usage of AppURL
- Fixes wrong rendering with extra path segments when AppSubURL is empty
- Now also renders all links when 2+ permalinks are present
2024-04-17 13:02:48 +02:00
618e517d4c
Merge pull request 'Update dependency vue to v3.4.23' ( #3280 ) from renovate/vue-monorepo into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3280
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-04-17 10:32:43 +00:00
c2f2858363
Merge pull request 'chore(renovate): schedule some deps quarterly' ( #3284 ) from viceice/forgejo:chore/renovate-schedule into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3284
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-04-17 10:16:50 +00:00
d07c8c821c
Do not require login_name & source_id for /admin/user/{username}
...
When editing a user via the API, do not require setting `login_name` or
`source_id`: for local accounts, these do not matter. However, when
editing a non-local account, require *both*, as before.
Fixes #1861 .
Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
2024-04-17 10:33:52 +02:00
bb0daa9522
chore(renovate): schedule some deps quarterly
2024-04-17 09:24:59 +02:00
e4aa7bd511
Merge pull request 'webhook: improve UX for sourcehut and matrix' ( #3156 ) from oliverpool/forgejo:webhook_sourcehut_polish into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3156
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-04-17 06:39:54 +00:00
ea4071ca9f
Allow admins to fork repos even when creation limits are exhausted ( #3277 )
...
This is a continuation of #2728 , with a test case added.
Fixes #2633 .
I kept @zareck 's commit as is, because I believe it is correct. We can't move the check to `owner.CanForkRepo()`, because `owner` is the future owner of the forked repo, and may be an organization. We need to check the admin permission of the `doer`, like in the case of repository creation.
I verified that the test fails without the `ForkRepository` change, and passes with it.
Co-authored-by: Cassio Zareck <cassiomilczareck@gmail.com>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3277
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Gergely Nagy <forgejo@gergo.csillger.hu>
Co-committed-by: Gergely Nagy <forgejo@gergo.csillger.hu>
2024-04-17 05:52:02 +00:00
33d0617538
Merge pull request 'feat(release): add OCI labels to container images' ( #3261 ) from earl-warren/forgejo:wip-oci-labels into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3261
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-04-17 05:46:36 +00:00
a003691c7b
Merge pull request 'Allow changing global wiki editability via the API' ( #3276 ) from algernon/forgejo:let-the-api-control-your-wiki-editability into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3276
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-04-17 05:46:10 +00:00
a5c0643d13
Update dependency vue to v3.4.23
2024-04-17 00:04:27 +00:00
Earl Warren
