mirror of
1
Fork 0
forgejo/templates/repo/issue
oliverpool 07bc099401 [BUG] split code conversations in diff tab (#2306)
Follow-up of #2282 and #2296 (which tried to address #2278)

One of the issue with the previous PR is that when a conversation on the Files tab was marked as "resolved", it would fetch all the comments for that line (even the outdated ones, which should not be shown on this page - except when explicitly activated).

To properly fix this, I have changed `FetchCodeCommentsByLine` to `FetchCodeConversation`. Its role is to fetch all comments related to a given (review, path, line) and reverted my changes in the template (which were based on a misunderstanding).

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2306
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
2024-02-16 14:06:43 +01:00
..
fields Fix required checkboxes in issue forms (#27592) (#27692) 2023-10-19 15:35:29 +02:00
labels Hide archived labels by default from the suggestions when assigning labels for an issue (#27451) (#27661) 2023-10-17 14:46:35 +00:00
milestone Backport ctx locale refactoring manually (#27231) (#27259) (#27260) 2023-09-25 13:15:51 +00:00
view_content [BUG] split code conversations in diff tab (#2306) 2024-02-16 14:06:43 +01:00
branch_selector_field.tmpl Backport ctx locale refactoring manually (#27231) (#27259) (#27260) 2023-09-25 13:15:51 +00:00
card.tmpl [GITEA] Fix issue card links on projects 2023-11-13 14:06:30 +01:00
choose.tmpl Backport ctx locale refactoring manually (#27231) (#27259) (#27260) 2023-09-25 13:15:51 +00:00
comment_tab.tmpl Backport ctx locale refactoring manually (#27231) (#27259) (#27260) 2023-09-25 13:15:51 +00:00
filter_actions.tmpl Hide archived labels by default from the suggestions when assigning labels for an issue (#27451) (#27661) 2023-10-17 14:46:35 +00:00
filters.tmpl Refactor template empty checks (#28351) (#28354) 2023-12-08 13:41:16 +01:00
label_precolors.tmpl Refactor some CSS styles and simplify code (#26771) 2023-08-28 22:14:51 +08:00
labels.tmpl Backport ctx locale refactoring manually (#27231) (#27259) (#27260) 2023-09-25 13:15:51 +00:00
list.tmpl Hide archived labels when filtering by labels on the issue list (#27115) (#27381) 2023-10-01 22:56:48 -04:00
milestone_issues.tmpl Backport ctx locale refactoring manually (#27231) (#27259) (#27260) 2023-09-25 13:15:51 +00:00
milestone_new.tmpl Backport ctx locale refactoring manually (#27231) (#27259) (#27260) 2023-09-25 13:15:51 +00:00
milestones.tmpl Backport ctx locale refactoring manually (#27231) (#27259) (#27260) 2023-09-25 13:15:51 +00:00
navbar.tmpl Backport ctx locale refactoring manually (#27231) (#27259) (#27260) 2023-09-25 13:15:51 +00:00
new.tmpl Make Issue/PR/projects more compact, misc CSS tweaks (#24459) 2023-05-03 17:58:59 -04:00
new_form.tmpl Backport manually for a tmpl issue in v1.21 (#27612) 2023-10-14 11:51:58 +00:00
openclose.tmpl Hide archived labels when filtering by labels on the issue list (#27115) (#27381) 2023-10-01 22:56:48 -04:00
search.tmpl Backport ctx locale refactoring manually (#27231) (#27259) (#27260) 2023-09-25 13:15:51 +00:00
view.tmpl Make Issue/PR/projects more compact, misc CSS tweaks (#24459) 2023-05-03 17:58:59 -04:00
view_content.tmpl Remove set tabindex on view issue (#27892) (#27896) 2023-11-03 23:25:11 +08:00
view_title.tmpl Rework markup link rendering (#26745) (#28803) 2024-01-16 14:41:11 +00:00