mirror of
1
Fork 0
forgejo/templates/repo/issue/view_content
oliverpool 07bc099401 [BUG] split code conversations in diff tab (#2306)
Follow-up of #2282 and #2296 (which tried to address #2278)

One of the issue with the previous PR is that when a conversation on the Files tab was marked as "resolved", it would fetch all the comments for that line (even the outdated ones, which should not be shown on this page - except when explicitly activated).

To properly fix this, I have changed `FetchCodeCommentsByLine` to `FetchCodeConversation`. Its role is to fetch all comments related to a given (review, path, line) and reverted my changes in the template (which were based on a misunderstanding).

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2306
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
2024-02-16 14:06:43 +01:00
..
add_reaction.tmpl Improve and fix bugs surrounding reactions (#24760) 2023-05-28 01:34:18 +00:00
attachments.tmpl Backport ctx locale refactoring manually (#27231) (#27259) (#27260) 2023-09-25 13:15:51 +00:00
comments.tmpl Don't reload timeline page when (un)resolving or replying conversation (#28654) (#28917) 2024-01-31 14:18:26 +01:00
comments_delete_time.tmpl Backport ctx locale refactoring manually (#27231) (#27259) (#27260) 2023-09-25 13:15:51 +00:00
context_menu.tmpl Revert "[GITEA] Make reference URL absolute" 2024-01-16 13:42:39 +00:00
conversation.tmpl [BUG] split code conversations in diff tab (#2306) 2024-02-16 14:06:43 +01:00
pull.tmpl Restore warning commit status (#27504) (#27529) 2023-10-09 11:56:02 +08:00
pull_merge_instruction.tmpl cleanup locale function usage (#27227) (#27240) 2023-09-25 00:21:38 +00:00
reactions.tmpl Backport ctx locale refactoring manually (#27231) (#27259) (#27260) 2023-09-25 13:15:51 +00:00
reference_issue_dialog.tmpl Backport ctx locale refactoring manually (#27231) (#27259) (#27260) 2023-09-25 13:15:51 +00:00
show_role.tmpl Add `member`, `collaborator`, `contributor`, and `first-time contributor` roles and tooltips (#26658) 2023-08-24 13:06:17 +08:00
sidebar.tmpl Refactor template empty checks (#28351) (#28354) 2023-12-08 13:41:16 +01:00
update_branch_by_merge.tmpl Backport ctx locale refactoring manually (#27231) (#27259) (#27260) 2023-09-25 13:15:51 +00:00